[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682364652 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3899/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682364823 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2158/

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682365316 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3905: [CARBONDATA-3964] Fixed null pointer excption for select * and select count(*) without filter.

CarbonDataQA1 commented on pull request #3905: URL: https://github.com/apache/carbondata/pull/3905#issuecomment-682366182 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2159/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3905: [CARBONDATA-3964] Fixed null pointer excption for select * and select count(*) without filter.

CarbonDataQA1 commented on pull request #3905: URL: https://github.com/apache/carbondata/pull/3905#issuecomment-682366329 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3900/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [CARBONDATA-3956] Reindex command on SI table

CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-682366851 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3901/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [CARBONDATA-3956] Reindex command on SI table

CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-682370365 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2160/

[GitHub] [carbondata] akashrn5 commented on pull request #3890: [CARBONDATA-3952] After reset query not hitting MV

akashrn5 commented on pull request #3890: URL: https://github.com/apache/carbondata/pull/3890#issuecomment-682373676 @ShreelekhyaG i feel, instead of fixing the impacted MV issue, we need to check why reset changes the warehouse and carbon store, because now if we just fix MV, may be later

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

VenuReddy2103 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r47920 ## File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/AvroCarbonWriterTest.java ## @@ -603,4 +605,161 @@ public void testWriteBasic

[GitHub] [carbondata] Zhangshunyu commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

Zhangshunyu commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-682379495 set 'no_sort' for cdc is for better load performance during merge, but i think we should keep same as target table. -

[GitHub] [carbondata] ajantha-bhat commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

ajantha-bhat commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-682380195 > set 'no_sort' for cdc is for better load performance during merge, but i think we should keep same as target table. @Zhangshunyu : But the target table itself ca

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

ajantha-bhat edited a comment on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-682380195 > set 'no_sort' for cdc is for better load performance during merge, but i think we should keep same as target table. @Zhangshunyu : But the target table it

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

ajantha-bhat edited a comment on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-682380195 > set 'no_sort' for cdc is for better load performance during merge, but i think we should keep same as target table. @Zhangshunyu : to have a faster CDC me

[GitHub] [carbondata] Zhangshunyu commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

Zhangshunyu commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-682381033 @ajantha-bhat yes, agree with this pr's change, to keep same as target. This is an automated message from

[GitHub] [carbondata] Zhangshunyu commented on pull request #3889: Fix a spelling mistake

Zhangshunyu commented on pull request #3889: URL: https://github.com/apache/carbondata/pull/3889#issuecomment-682383172 @Kejian-Li please check the other PRs format like title, description, etc. This is an automated message f

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3904: [CARBONDATA-3962]Remove unwanted empty fact directory in case of flat_folder table

CarbonDataQA1 commented on pull request #3904: URL: https://github.com/apache/carbondata/pull/3904#issuecomment-682388107 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2161/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3904: [CARBONDATA-3962]Remove unwanted empty fact directory in case of flat_folder table

CarbonDataQA1 commented on pull request #3904: URL: https://github.com/apache/carbondata/pull/3904#issuecomment-682389096 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3902/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

CarbonDataQA1 commented on pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#issuecomment-682393514 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3903/ -

[GitHub] [carbondata] akashrn5 commented on pull request #3904: [CARBONDATA-3962]Remove unwanted empty fact directory in case of flat_folder table

akashrn5 commented on pull request #3904: URL: https://github.com/apache/carbondata/pull/3904#issuecomment-682394145 @kunal642 i have fixed failures, please review and merge This is an automated message from the Apache Git Se

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

akashrn5 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r478884183 ## File path: docs/index/secondary-index-guide.md ## @@ -188,4 +188,25 @@ where we have old stores. Syntax ``` REGISTER INDEX TABLE index_name

[GitHub] [carbondata] akashrn5 commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

akashrn5 commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-682408178 @ajantha-bhat if the target table is no sort and since we are inserting new segment as a separate segment during merge, we can sort this segment and write which will help i

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

CarbonDataQA1 commented on pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#issuecomment-682412709 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2162/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682414402 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2163/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

VenuReddy2103 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r478989788 ## File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/ORCCarbonWriterTest.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] ajantha-bhat commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

ajantha-bhat commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-682419143 > @ajantha-bhat if the target table is no sort and since we are inserting new segment as a separate segment during merge, we can sort this segment and write which will h

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682420207 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3904/ -

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

VenuReddy2103 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r479000935 ## File path: sdk/sdk/src/test/java/org/apache/carbondata/sdk/file/ParquetCarbonWriterTest.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apa

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r479003111 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ## @@ -660,13 +1113,42 @@ public CarbonWriter build() th

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

akashrn5 commented on a change in pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#discussion_r478994240 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala ## @@ -693,7 +693,7 @@ class CarbonSpark2SqlPa

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682481657 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2164/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682485142 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3905/ -

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682491192 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] VenuReddy2103 commented on pull request #3903: [CARBONDATA-3963]Fix hive timestamp data mismatch issue and empty data during query issue

VenuReddy2103 commented on pull request #3903: URL: https://github.com/apache/carbondata/pull/3903#issuecomment-682593629 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682596474 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3906/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682598563 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2165/

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-682791961 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] kunal642 commented on pull request #3904: [CARBONDATA-3962]Remove unwanted empty fact directory in case of flat_folder table

kunal642 commented on pull request #3904: URL: https://github.com/apache/carbondata/pull/3904#issuecomment-682801505 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] asfgit closed pull request #3904: [CARBONDATA-3962]Remove unwanted empty fact directory in case of flat_folder table

asfgit closed pull request #3904: URL: https://github.com/apache/carbondata/pull/3904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Resolved] (CARBONDATA-3962) Empty fact dirs are present in case of flat folder, which are unnecessary

[ https://issues.apache.org/jira/browse/CARBONDATA-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3962. -- Fix Version/s: 2.1.0 Resolution: Fixed > Empty fact dirs are present in cas

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3902: [WIP][CARBONDATA-3961] reorder filter expression based on storage ordinal

CarbonDataQA1 commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-682990756 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2166/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3902: [WIP][CARBONDATA-3961] reorder filter expression based on storage ordinal

CarbonDataQA1 commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-682991866 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3907/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-683005547 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2167/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-683007336 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3908/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3906: [WIP] Added test cases for hive read complex types and handled other issues

CarbonDataQA1 commented on pull request #3906: URL: https://github.com/apache/carbondata/pull/3906#issuecomment-683073566 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3909/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3906: [WIP] Added test cases for hive read complex types and handled other issues

CarbonDataQA1 commented on pull request #3906: URL: https://github.com/apache/carbondata/pull/3906#issuecomment-683075255 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2168/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3902: [WIP][CARBONDATA-3961] reorder filter expression based on storage ordinal

CarbonDataQA1 commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-683137391 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3910/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3902: [WIP][CARBONDATA-3961] reorder filter expression based on storage ordinal

CarbonDataQA1 commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-683138098 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2169/

[GitHub] [carbondata] QiangCai commented on a change in pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

QiangCai commented on a change in pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#discussion_r479598589 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala ## @@ -693,7 +693,7 @@ class CarbonSpark2SqlPa

[GitHub] [carbondata] ajantha-bhat commented on pull request #3895: [WIP]SI fix for not equal to filter

ajantha-bhat commented on pull request #3895: URL: https://github.com/apache/carbondata/pull/3895#issuecomment-683232625 @vikramahuja1001 : I have handled in my existing open order by limit PR [#3861 ] which can cause this issue using a flag. I think you can check and close this.

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

CarbonDataQA1 commented on pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#issuecomment-683243184 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3911/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

CarbonDataQA1 commented on pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#issuecomment-683243862 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2170/