[GitHub] [carbondata] marchpure commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox


marchpure commented on pull request #3998:
URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716341256


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3998:
URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716397293


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2930/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3998:
URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716339510







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3998: [WIP] Fix delete externaltable dataloss issue

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3998:
URL: https://github.com/apache/carbondata/pull/3998#issuecomment-716392135


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4687/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716396690


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2931/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox


marchpure commented on pull request #3977:
URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716394909


   > @marchpure please update the PR description for MergeIndex changes also
   
   I have updated the PR description  for MergeIndex changes



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716394910


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4688/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on a change in pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox


marchpure commented on a change in pull request #3977:
URL: https://github.com/apache/carbondata/pull/3977#discussion_r511786746



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/events/MergeIndexEventListener.scala
##
@@ -43,11 +43,6 @@ class MergeIndexEventListener extends OperationEventListener 
with Logging {
   override def onEvent(event: Event, operationContext: OperationContext): Unit 
= {
 event match {
   case preStatusUpdateEvent: LoadTablePreStatusUpdateEvent =>
-// skip merge index in case of insert stage flow
-if (null != 
operationContext.getProperty(CarbonCommonConstants.IS_INSERT_STAGE) &&

Review comment:
   I have modified code according to your suggestion





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3912: [CARBONDATA-3977] Global sort partitions should be determined dynamically

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3912:
URL: https://github.com/apache/carbondata/pull/3912#issuecomment-716994984


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2939/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [CARBONDATA-4044] Fix dirty data in indexfile while IUD with stale data in segment folder

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716961859


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4694/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [CARBONDATA-4044] Fix dirty data in indexfile while IUD with stale data in segment folder

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716962034


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2937/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-716969729


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4695/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] asfgit closed pull request #3875: [CARBONDATA-3934]Support write transactional table with presto.

2020-10-26 Thread GitBox


asfgit closed pull request #3875:
URL: https://github.com/apache/carbondata/pull/3875


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] kunal642 commented on pull request #3970: [CARBONDATA-4007] Fix multiple issues in SDK

2020-10-26 Thread GitBox


kunal642 commented on pull request #3970:
URL: https://github.com/apache/carbondata/pull/3970#issuecomment-717002495


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on pull request #3994: [CARBONDATA-4040] Fix data mismatch incase of compaction failure and retry success

2020-10-26 Thread GitBox


ajantha-bhat commented on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-716998184


> Hi, Ajantha. I have fixed this in #3999 , please have a check.
   
   @marchpure: I think your PR is not handling all the scenarios, so update 
scenario and test case will fail (even mine also)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat commented on pull request #3875: [CARBONDATA-3934]Support write transactional table with presto.

2020-10-26 Thread GitBox


ajantha-bhat commented on pull request #3875:
URL: https://github.com/apache/carbondata/pull/3875#issuecomment-716996636


   LGTM
   
   can be an alpha feature until we support the create table. (because until 
spark dependency is removed for write, it won't help much for production 
environments)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (CARBONDATA-3934) Support insert into command for transactional support

2020-10-26 Thread Ajantha Bhat (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ajantha Bhat resolved CARBONDATA-3934.
--
Fix Version/s: 2.1.0
   Resolution: Fixed

> Support insert into command for transactional support
> -
>
> Key: CARBONDATA-3934
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3934
> Project: CarbonData
>  Issue Type: Sub-task
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: Presto_write_flow.pdf
>
>  Time Spent: 13h 20m
>  Remaining Estimate: 0h
>
> Support insert into command for transactional support.
> Should support writing table status file, segment files, all the folder 
> structure similar to transactional carbon table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] ajantha-bhat commented on pull request #3916: [CARBONDATA-3935]Support partition table transactional write in presto

2020-10-26 Thread GitBox


ajantha-bhat commented on pull request #3916:
URL: https://github.com/apache/carbondata/pull/3916#issuecomment-717003123


   @akashrn5 : please rebase as presto write PR is merged



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] kunal642 commented on pull request #3996: [DOC] Adjust document for partition table

2020-10-26 Thread GitBox


kunal642 commented on pull request #3996:
URL: https://github.com/apache/carbondata/pull/3996#issuecomment-717002812


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (CARBONDATA-4045) Add TPCDS TestCase

2020-10-26 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-4045:
---

 Summary: Add TPCDS TestCase
 Key: CARBONDATA-4045
 URL: https://issues.apache.org/jira/browse/CARBONDATA-4045
 Project: CarbonData
  Issue Type: Test
Reporter: Xingjun Hao


There is no TPC-DS TestCase in the current source code. It is difficult to 
debug TPC-DS on small dataset. Also, TPC-DS TestCase would help to find 
possible issues



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CARBONDATA-4044) Fix dirty data in indexfile while IUD with stale data in segment folder

2020-10-26 Thread Xingjun Hao (Jira)
Xingjun Hao created CARBONDATA-4044:
---

 Summary: Fix dirty data in indexfile while IUD with stale data in 
segment folder
 Key: CARBONDATA-4044
 URL: https://issues.apache.org/jira/browse/CARBONDATA-4044
 Project: CarbonData
  Issue Type: Bug
Reporter: Xingjun Hao


XX.mergecarbonindex and XX..segment records the indexfiles list of a segment. 
now, we generate xx.mergeindexfile and xx.segment  based on filter out all 
indexfiles(including carbonindex and mergecarbonindex), which will leading 
dirty data when there is stale data in segment folder.

For example, there are a stale index file in segment_0 folder, 
"0_1603763776.carbonindex".

While loading, a new carbonindex "0_16037752342.carbonindex" is wrote, when 
merge carbonindex files, we expect to only merge 0_16037752342.carbonindex, But 
If we filter out all carbonindex in segment folder, both 
"0_1603763776.carbonindex" and 0_16037752342.carbonindex will be merged and 
recorded into segment file.

 

While updating, there has same problem. 

 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] marchpure commented on pull request #3994: [CARBONDATA-4040] Fix data mismatch incase of compaction failure and retry success

2020-10-26 Thread GitBox


marchpure commented on pull request #3994:
URL: https://github.com/apache/carbondata/pull/3994#issuecomment-716933491


   Hi, Ajantha. I have fixed this in #3999 , please have a check.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#issuecomment-716970186


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2938/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox


akashrn5 commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716977104


   @marchpure please correct the PR title and please give detailed explanation 
of the issue and the fix in the PR description.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox


marchpure commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716981130


   > @marchpure please correct the PR title and please give detailed 
explanation of the issue and the fix in the PR description.
   
   Yes. I have modified the PR desc as your suggestion



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3912: [CARBONDATA-3977] Global sort partitions should be determined dynamically

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3912:
URL: https://github.com/apache/carbondata/pull/3912#issuecomment-716994724


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4696/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3875: [CARBONDATA-3934]Support write transactional table with presto.

2020-10-26 Thread GitBox


ajantha-bhat edited a comment on pull request #3875:
URL: https://github.com/apache/carbondata/pull/3875#issuecomment-716996636


   LGTM
   
   can be an alpha feature until we support the create table. (because until 
spark dependency is removed for write, it won't help much for production 
environments)
   
   Also prestodb compile might have broken, need to handle in same version



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716466945


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4691/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716460174


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2934/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox


marchpure commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716406534


   > please do rebase
   
   I have do rebase according to your suggestion



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716451904


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2932/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716455767


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2933/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3981: [CARBONDATA-4031] Incorrect query result after Update/Delete and Inse…

2020-10-26 Thread GitBox


marchpure commented on pull request #3981:
URL: https://github.com/apache/carbondata/pull/3981#issuecomment-716406302


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3999: [WIP] Segment listfile issue

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3999:
URL: https://github.com/apache/carbondata/pull/3999#issuecomment-716449317


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4689/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716454832


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4690/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox


Indhumathi27 commented on pull request #3977:
URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716504631


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3977:
URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716555787


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4692/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3977:
URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716556388


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2935/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716562736


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4693/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3997: [WIP] Add TPCDS TestCase

2020-10-26 Thread GitBox


CarbonDataQA1 commented on pull request #3997:
URL: https://github.com/apache/carbondata/pull/3997#issuecomment-716563917


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2936/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Indhumathi27 commented on pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox


Indhumathi27 commented on pull request #3977:
URL: https://github.com/apache/carbondata/pull/3977#issuecomment-716593613


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] asfgit closed pull request #3977: [CARBONDATA-4027] Fix the wrong modifiedtime of loading files in inse…

2020-10-26 Thread GitBox


asfgit closed pull request #3977:
URL: https://github.com/apache/carbondata/pull/3977


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (CARBONDATA-4027) Fix the wrong modifiedtime of loading files in insert stage

2020-10-26 Thread Indhumathi Muthu Murugesh (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Indhumathi Muthu Murugesh resolved CARBONDATA-4027.
---
Fix Version/s: 2.1.0
   Resolution: Fixed

> Fix the wrong modifiedtime of loading files in insert stage
> ---
>
> Key: CARBONDATA-4027
> URL: https://issues.apache.org/jira/browse/CARBONDATA-4027
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Xingjun Hao
>Priority: Minor
> Fix For: 2.1.0
>
>  Time Spent: 14h 10m
>  Remaining Estimate: 0h
>
> In the insertstage flow, there is a empty file with suffix '.loading' to mark 
> the stage in the status of 'in processing'. We update the modifiedtime of 
> '.loading' file for monitoring the insertstage start time, which can be used 
> for calculate TIMEOUT, help to retry and recovery.
> Before, we use setModifiedTime function to update the modifiedtime, which has 
> a serious bug.
> For S3 file, setModifiedTime operation do not take effect. leading to the 
> incorrect inserstage starttime of 'loading' file.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)