[GitHub] [carbondata] vikramahuja1001 commented on pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

vikramahuja1001 commented on pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#issuecomment-792624555 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] ajantha-bhat commented on pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

ajantha-bhat commented on pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#issuecomment-792594384 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

ShreelekhyaG commented on a change in pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#discussion_r589272680 ## File path: core/src/main/java/org/apache/carbondata/core/index/Segment.java ## @@ -79,7 +79,9 @@ /** * Path of segment where it exists

[GitHub] [carbondata] Karan980 commented on a change in pull request #4099: [CARBONDATA-4141] Index Server is not caching indexes for external tables with sdk segments.

Karan980 commented on a change in pull request #4099: URL: https://github.com/apache/carbondata/pull/4099#discussion_r589323912 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexUtil.java ## @@ -112,15 +116,31 @@ public static IndexJob

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

CarbonDataQA2 commented on pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#issuecomment-792688228 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5116/

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

ShreelekhyaG commented on a change in pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#discussion_r589273380 ## File path: core/src/main/java/org/apache/carbondata/core/index/Segment.java ## @@ -378,11 +382,10 @@ public void write(DataOutput out) throws

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

ShreelekhyaG commented on a change in pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#discussion_r589273743 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlockletWrapper.java ## @@ -121,8 +121,9 @@ public

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

CarbonDataQA2 commented on pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#issuecomment-792734488 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3357/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4098: [CARBONDATA-4143] UT with index server

CarbonDataQA2 commented on pull request #4098: URL: https://github.com/apache/carbondata/pull/4098#issuecomment-792734276 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3355/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4099: [CARBONDATA-4141] Index Server is not caching indexes for external tables with sdk segments.

CarbonDataQA2 commented on pull request #4099: URL: https://github.com/apache/carbondata/pull/4099#issuecomment-792733994 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5113/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

CarbonDataQA2 commented on pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#issuecomment-792736871 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5115/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4098: [CARBONDATA-4143] UT with index server

CarbonDataQA2 commented on pull request #4098: URL: https://github.com/apache/carbondata/pull/4098#issuecomment-792736994 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5114/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

CarbonDataQA2 commented on pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#issuecomment-792743166 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3356/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

Indhumathi27 commented on a change in pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#discussion_r589412990 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java ## @@ -225,25 +223,15 @@ public void

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4099: [CARBONDATA-4141] Index Server is not caching indexes for external tables with sdk segments.

CarbonDataQA2 commented on pull request #4099: URL: https://github.com/apache/carbondata/pull/4099#issuecomment-792735786 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3354/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

CarbonDataQA2 commented on pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#issuecomment-793005147 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5117/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

CarbonDataQA2 commented on pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#issuecomment-793005760 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3358/

[GitHub] [carbondata] QiangCai commented on pull request #4100: [CARBONDATA-4138] Reordering Carbon Expression instead of Spark Filter

QiangCai commented on pull request #4100: URL: https://github.com/apache/carbondata/pull/4100#issuecomment-793243858 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

vikramahuja1001 commented on a change in pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#discussion_r589996949 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala ## @@ -41,6

[GitHub] [carbondata] vikramahuja1001 commented on pull request #4099: [CARBONDATA-4141] Index Server is not caching indexes for external tables with sdk segments.

vikramahuja1001 commented on pull request #4099: URL: https://github.com/apache/carbondata/pull/4099#issuecomment-793477512 please correct the splits path of getSplits in case of External Tables in DistributedPruneRDD as well

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

akashrn5 commented on a change in pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#discussion_r590016222 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -87,13 +106,53 @@ object DataTrashManager {

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

akashrn5 commented on a change in pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#discussion_r590016320 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -87,13 +106,53 @@ object DataTrashManager {

[GitHub] [carbondata] Indhumathi27 commented on pull request #4096: [CARBONDATA-4133] Concurrent Insert Overwrite with static partition on Index server fails

Indhumathi27 commented on pull request #4096: URL: https://github.com/apache/carbondata/pull/4096#issuecomment-793425074 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] vikramahuja1001 commented on pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

vikramahuja1001 commented on pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#issuecomment-793427100 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4072: [CARBONDATA-4110] Support clean files dry run operation and show statistics after clean files operation

akashrn5 commented on a change in pull request #4072: URL: https://github.com/apache/carbondata/pull/4072#discussion_r589969086 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala ## @@ -41,6 +43,26 @@