[GitHub] carbondata issue #1385: [CARBONDATA-1492] Alter add and remove struct Column...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1385
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1149/



---


[GitHub] carbondata issue #1419: [CARBONDATA-1601] Add carbondata-store module

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1148/



---


[GitHub] carbondata issue #1385: [CARBONDATA-1492] Alter add and remove struct Column...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1385
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/520/



---


[GitHub] carbondata issue #1419: [CARBONDATA-1601] Add carbondata-store module

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/519/



---


[GitHub] carbondata issue #1385: [CARBONDATA-1492] Alter add and remove struct Column...

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1385
  
retest this please


---


[jira] [Created] (CARBONDATA-1602) Remove unused declaration in spark-common module

2017-10-19 Thread Jacky Li (JIRA)
Jacky Li created CARBONDATA-1602:


 Summary: Remove unused declaration in spark-common module
 Key: CARBONDATA-1602
 URL: https://issues.apache.org/jira/browse/CARBONDATA-1602
 Project: CarbonData
  Issue Type: Improvement
 Environment: Remove unused declaration in spark-common module
Reporter: Jacky Li
 Fix For: 1.3.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] carbondata issue #1419: [CARBONDATA-1601] Add carbondata-store module

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1147/



---


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1145/



---


[GitHub] carbondata pull request #1413: [CARBONDATA-1548] resolved bug for creating t...

2017-10-19 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1413#discussion_r145876968
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala ---
@@ -233,10 +233,17 @@ object CarbonSource {
* @return
*/
   def updateCatalogTableWithCarbonSchema(tableDesc: CatalogTable,
-  sparkSession: SparkSession): CatalogTable = {
+ sparkSession: SparkSession): 
CatalogTable = {
 val metaStore = CarbonEnv.getInstance(sparkSession).carbonMetastore
 val storageFormat = tableDesc.storage
 val properties = storageFormat.properties
+tableDesc.storage.properties.get("tableName") match {
--- End diff --

@ravipesala 1.tableName validation does not take place in parser when you 
datasource ddl
2.test case is already there in carbondatasource suite i just modified it 
to check that when exception is thrown table should not be there in store


---


[GitHub] carbondata issue #1419: [CARBONDATA-1601] Add carbondata-store module

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/518/



---


[jira] [Created] (CARBONDATA-1601) Add carbon store module

2017-10-19 Thread Jacky Li (JIRA)
Jacky Li created CARBONDATA-1601:


 Summary: Add carbon store module
 Key: CARBONDATA-1601
 URL: https://issues.apache.org/jira/browse/CARBONDATA-1601
 Project: CarbonData
  Issue Type: Sub-task
Reporter: Jacky Li
 Fix For: 1.3.0


Add carbondata-store module and move corresponding code from integration module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/517/



---


[GitHub] carbondata issue #1400: [CARBONDATA-1537] Added back Adaptive delta encoding...

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1400
  
please rebase


---


[jira] [Assigned] (CARBONDATA-1600) Carbon store abstraction

2017-10-19 Thread Jacky Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Li reassigned CARBONDATA-1600:


Assignee: Jacky Li

> Carbon store abstraction
> 
>
> Key: CARBONDATA-1600
> URL: https://issues.apache.org/jira/browse/CARBONDATA-1600
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Jacky Li
>Assignee: Jacky Li
> Fix For: 1.3.0
>
>
> There should be a carbondata-store module to abstract all functionalities 
> that above file format, and provide developer API to support different 
> compute engine to integrate with carbon



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (CARBONDATA-1600) Carbon store abstraction

2017-10-19 Thread Jacky Li (JIRA)
Jacky Li created CARBONDATA-1600:


 Summary: Carbon store abstraction
 Key: CARBONDATA-1600
 URL: https://issues.apache.org/jira/browse/CARBONDATA-1600
 Project: CarbonData
  Issue Type: Improvement
Reporter: Jacky Li
 Fix For: 1.3.0


There should be a carbondata-store module to abstract all functionalities that 
above file format, and provide developer API to support different compute 
engine to integrate with carbon



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1144/



---


[GitHub] carbondata issue #1424: [WIP] Remove unused declaration in spark-common modu...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1424
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1143/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1142/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1141/



---


[GitHub] carbondata issue #1390: [CARBONDATA-1360] fix for update table failures for ...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1390
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1140/



---


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/516/



---


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread chenliang613
Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
retest this please


---


[GitHub] carbondata issue #1388: [CARBONDATA-1512] Fixed bug for failing of concurren...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1388
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1139/



---


[GitHub] carbondata issue #1424: [WIP] Remove unused declaration in spark-common modu...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1424
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/515/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1138/



---


[GitHub] carbondata pull request #1424: [WIP] Remove unused declaration in spark-comm...

2017-10-19 Thread jackylk
GitHub user jackylk opened a pull request:

https://github.com/apache/carbondata/pull/1424

[WIP] Remove unused declaration in spark-common module



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jackylk/incubator-carbondata clean

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1424


commit 0876f93eec4d67457d170db1beabae12e7281694
Author: Jacky Li 
Date:   2017-10-20T01:50:18Z

clean up spark-common module




---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/514/



---


[GitHub] carbondata pull request #1418: [WIP] Support db location

2017-10-19 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan reopened a pull request:

https://github.com/apache/carbondata/pull/1418

[WIP] Support db location

**Problem:**
Currently carbon stores the database and tables at the fixed configured 
location “carbon.storeLocation”.  So even though in case of federated 
cluster i.e. multiple independent Namespaces/ Namenodes only one Namespace/ 
Namenode can be used as storage for the database and tables.
The requirement is to support when create database can specify the 
LOCATION; the location can be viewfs path, name service path.  
Using database location attribute configuration different name nodes can be 
used to store different databases. Having different name nodes for different 
databases will scale the read/write throughput.
**Solution:**
Setting the LOCATION attribute for a new database is a way to work with 
sets of files in an HDFS directory structure outside the fixed carbon store 
location.
In Create database command user can specify the location, the location 
where database and table under that database namespace could be stored.
1.  The database at specified location could be created at defined location 
using create database command with location attribute.
Syntax:
CREATE DATABASE [IF NOT EXISTS] database_name[COMMENT 'database_comment']   
 [LOCATION hdfs_path];
The HDFS path can be viewfs path, nameservice path.
2.  The database name and database location will be retrieved from the 
HiveSessionCatalog. The tables will be retrieved by scanning the table folders.
3.  The read/write operation on old databases/ new databases created 
without specifying the LOCATION attribute should be performed the fixed carbon 
store location.
4.  The table path formation will be same as the hive. The table path 
should be formed from database location or fixed Carbon store location and 
table name as given below. 
The will be three possible scenarios:
I.  Table path for the databases defined with location attribute.
  tablePath = databaseLocation +”/” + tableName

II. Table path for the databases defined without location attribute.
 tablePath = carbon.storeLocation + “/” + 
database_Name+”.db” +”/”  + tableName

III.New table path for the default database.
  tablePath = carbon.storeLocation +”/”  + tableName

5.  The carbon should support hybrid Nameservice path i.e. different 
operation could be performed in different name service. For example in load 
command the raw CSV files could be read from the nameservice ns1 i.e.  
“hdfs://ns1/user/data.csv” and database location could point to viewfs path 
“viewfs://federation_cluster/dir1/carbonstore”.

Example:
CREATE DATABASE carbon LOCATION 
“viewfs://federation_cluster/dir1/carbonstore”;
CREATE TABLE carbon.carbon_table (c1 string, c2 int) stored by 
‘carbondata’;
LOAD DATA INPATH ‘hdfs://ns1/user/data.csv’ into table 
carbon.carbon_table;


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata 
support_db_location

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1418


commit efc5edb8f721bc22edcaa8af16179b5ed734d32b
Author: mohammadshahidkhan 
Date:   2017-10-10T05:20:11Z

Support database location:
The database name and database location will be retrieved from the 
HiveSessionCatalog. The tables will be retrieved by scanning the table folders.
The read/write operation on old databases/ new databases created without 
specifying the LOCATION attribute should be performed the fixed carbon store 
location.

commit bdb11c9a57bb5b7adc77a7d73ff242ef438be7cc
Author: mohammadshahidkhan 
Date:   2017-10-10T06:00:43Z

Support configurable path for the store modification info file 
(modifiedTime.mdt).

commit 8bf6ac4b37d40bde6c9223e2b06609e2c771c004
Author: mohammadshahidkhan 
Date:   2017-10-10T10:17:00Z

Fixed drop database issue

commit 6a336153297c6edc38010f6d871511a85b916531
Author: mohammadshahidkhan 
Date:   2017-10-11T10:00:51Z

Corrected lock file location

commit b60a874ca6ba60f71ec030c96b397d0d20562fbe
Author: mohammadshahidkhan 
Date:   2017-10-16T08:58:07Z

Making carbon table path same as hive.

commit d0d15148c0c4cc3f9a7c53c725138bb64def3e61
Author: mohammadshahidkhan 
Date:   2017-10-18T15:31:13Z

fixed failing test cases

commit 3a32d6ba03b1a813cf348db21c9e5190ba442c7f
Author: mohammadshahidkhan 

[GitHub] carbondata pull request #1418: [WIP] Support db location

2017-10-19 Thread mohammadshahidkhan
Github user mohammadshahidkhan closed the pull request at:

https://github.com/apache/carbondata/pull/1418


---


[GitHub] carbondata issue #1388: [CARBONDATA-1512] Fixed bug for failing of concurren...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1388
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/512/



---


[GitHub] carbondata issue #1420: [CARBONDATA-1596] Fixed IntermediateFileMerger for d...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1420
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1137/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/510/



---


[GitHub] carbondata issue #1420: [CARBONDATA-1596] Fixed IntermediateFileMerger for d...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1420
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/509/



---


[GitHub] carbondata issue #1390: [CARBONDATA-1360] fix for update table failures for ...

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1390
  
retest this please


---


[GitHub] carbondata issue #1388: [CARBONDATA-1512] Fixed bug for failing of concurren...

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1388
  
retest this please


---


[GitHub] carbondata pull request #1412: [CARBONDATA-1510] UDF test case added

2017-10-19 Thread jackylk
Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1412#discussion_r145858296
  
--- Diff: integration/spark-common-test/pom.xml ---
@@ -116,7 +116,6 @@
   
 
   
-src/test/scala
--- End diff --

Is it required to remove this?


---


[GitHub] carbondata pull request #1412: [CARBONDATA-1510] UDF test case added

2017-10-19 Thread jackylk
Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1412#discussion_r145858244
  
--- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/udf/TestUdf.scala
 ---
@@ -0,0 +1,103 @@
+package org.apache.carbondata.spark.testsuite.udf
+
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.test.util.QueryTest
+import org.apache.spark.sql.types.{DataType, StringType, StructField, 
StructType}
+import org.scalatest.BeforeAndAfterAll
+
+class TestUdf extends QueryTest with BeforeAndAfterAll {
--- End diff --

Can you rename to mention it is for complex type UDF test?


---


[jira] [Updated] (CARBONDATA-1568) Optimize annotation of code

2017-10-19 Thread Jacky Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Li updated CARBONDATA-1568:
-
Fix Version/s: 1.3.0

> Optimize annotation of code
> ---
>
> Key: CARBONDATA-1568
> URL: https://issues.apache.org/jira/browse/CARBONDATA-1568
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: xubo245
>Assignee: xubo245
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: 1.PNG
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> There are some improper places in code annotation  by IDEA inspect code
> We need to optimize annotation of code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (CARBONDATA-1568) Optimize annotation of code

2017-10-19 Thread Jacky Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Li resolved CARBONDATA-1568.
--
Resolution: Fixed

> Optimize annotation of code
> ---
>
> Key: CARBONDATA-1568
> URL: https://issues.apache.org/jira/browse/CARBONDATA-1568
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: xubo245
>Assignee: xubo245
>Priority: Minor
> Attachments: 1.PNG
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> There are some improper places in code annotation  by IDEA inspect code
> We need to optimize annotation of code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (CARBONDATA-1444) CarbonData unsupport Boolean data type

2017-10-19 Thread Jacky Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Li resolved CARBONDATA-1444.
--
Resolution: Fixed

> CarbonData unsupport Boolean data type
> --
>
> Key: CARBONDATA-1444
> URL: https://issues.apache.org/jira/browse/CARBONDATA-1444
> Project: CarbonData
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 1.2.0
>Reporter: xubo245
>Assignee: xubo245
>Priority: Minor
> Fix For: 1.3.0
>
>   Original Estimate: 240h
>  Time Spent: 21h 10m
>  Remaining Estimate: 218h 50m
>
>   Spark/Hive table support Boolean data type, the internal table also should 
> support Boolean data type.
>Boolean data type Range: TRUE or FALSE. Do not use quotation marks around 
> the TRUE and FALSE literal values. You can write the literal values in 
> uppercase, lowercase, or mixed case. The values queried from a table are 
> always returned in lowercase, true or false.
> In implementing this function, we employ:
> #   endcoding: RLE
> #   data expression: byte array
> 
> CarbonData should support boolean data type in following aspects:
> #   create table: support Boolean data type
> #   insert into table values: support insert Boolean column 
> #   insert overwrite
> #   insert into table select from another table
> #   select from a table
> #   load data: from a local csv file
> #   filter: including >=, >, =, <=, <, =, !=, in, not in
> #   describle: should show boolean data type
> We also add some test cases in booleantype directory of spark2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1408
  
LGTM


---


[GitHub] carbondata issue #1416: [WIP] [CARBONDATA-1592] Adding event listener interf...

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1416
  
Can you explain more on the intention of this PR?


---


[GitHub] carbondata issue #1420: [CARBONDATA-1596] Fixed IntermediateFileMerger for d...

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1420
  
retest this please


---


[GitHub] carbondata issue #1362: [CARBONDATA-1444] Support Boolean data type

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1362
  
Thanks for working on this


---


[GitHub] carbondata pull request #1362: [CARBONDATA-1444] Support Boolean data type

2017-10-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1362


---


[GitHub] carbondata issue #1362: [CARBONDATA-1444] Support Boolean data type

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1362
  
LGTM


---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/508/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1136/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1135/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/507/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1134/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/506/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1132/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/505/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/504/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/503/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1131/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1130/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1129/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/502/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1128/



---


[GitHub] carbondata issue #1417: [CARBONDATA-1594] Add precision and scale to Decimal...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1417
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1127/



---


[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1408
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1126/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/501/



---


[GitHub] carbondata issue #1419: [WIP] Refactor on relation provider

2017-10-19 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1419
  
retest this please


---


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1125/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1124/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/500/



---


[GitHub] carbondata issue #1417: [CARBONDATA-1594] Add precision and scale to Decimal...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1417
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1123/



---


[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code

2017-10-19 Thread chenliang613
Github user chenliang613 commented on the issue:

https://github.com/apache/carbondata/pull/1408
  
LGTM


---


[GitHub] carbondata issue #1417: [CARBONDATA-1594] Add precision and scale to Decimal...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1417
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/499/



---


[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1408
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1122/



---


[GitHub] carbondata issue #1362: [CARBONDATA-1444] Support Boolean data type

2017-10-19 Thread xubo245
Github user xubo245 commented on the issue:

https://github.com/apache/carbondata/pull/1362
  
@jackylk Please review it.


---


[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1408
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/498/



---


[GitHub] carbondata issue #1362: [CARBONDATA-1444] Support Boolean data type

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1362
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1121/



---


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/497/



---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/496/



---


[GitHub] carbondata issue #1417: [CARBONDATA-1594] Add precision and scale to Decimal...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1417
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/495/



---


[GitHub] carbondata issue #1423: [CARBONDATA-1598] Remove all spark 1.x info(CI, READ...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1423
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/373/



---


[GitHub] carbondata pull request #1423: [CARBONDATA-1598] Remove all spark 1.x info(C...

2017-10-19 Thread chenliang613
GitHub user chenliang613 opened a pull request:

https://github.com/apache/carbondata/pull/1423

[CARBONDATA-1598] Remove all spark 1.x info(CI, README, documents)

Remove all spark 1.x info(CI, README, documents)

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[CARBONDATA-] Description of pull request`
   
 - [ ] Make sure to add PR description including

- the root cause/problem statement
- What is the implemented solution

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
 
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
 
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
 
---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenliang613/carbondata remove_spark1.6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1423


commit 4d65323cfe260d404720194e24e1d65465265c24
Author: chenliang613 
Date:   2017-10-19T12:40:29Z

[CARBONDATA-1598] Remove all spark 1.x info(CI, readme, documents)




---


[GitHub] carbondata issue #1418: [WIP] Support db location

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1418
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/372/



---


[GitHub] carbondata issue #1422: [CARBONDATA-1599] Optimize pull request template

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1422
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1120/



---


[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1408
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/494/



---


[jira] [Resolved] (CARBONDATA-1599) Optimize pull request template for reminding contributors to provide full info.

2017-10-19 Thread Cao, Lionel (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cao, Lionel resolved CARBONDATA-1599.
-
Resolution: Fixed

> Optimize pull request template for reminding contributors to provide full 
> info.
> ---
>
> Key: CARBONDATA-1599
> URL: https://issues.apache.org/jira/browse/CARBONDATA-1599
> Project: CarbonData
>  Issue Type: Improvement
>  Components: other
>Reporter: Liang Chen
>Assignee: Liang Chen
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] carbondata issue #1417: [CARBONDATA-1594] Add precision and scale to Decimal...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1417
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/371/



---


[GitHub] carbondata issue #1362: [CARBONDATA-1444] Support Boolean data type

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1362
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/493/



---


[GitHub] carbondata pull request #1422: [CARBONDATA-1599] Optimize pull request templ...

2017-10-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1422


---


[GitHub] carbondata issue #1408: [CARBONDATA-1568] Optimize annotation of code

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1408
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/370/



---


[GitHub] carbondata issue #1420: [CARBONDATA-1596] Fixed IntermediateFileMerger for d...

2017-10-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1420
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/1119/



---


[GitHub] carbondata issue #1420: [CARBONDATA-1596] Fixed IntermediateFileMerger for d...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1420
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/492/



---


[GitHub] carbondata issue #1422: [CARBONDATA-1599] Optimize pull request template

2017-10-19 Thread lionelcao
Github user lionelcao commented on the issue:

https://github.com/apache/carbondata/pull/1422
  
LGTM


---


[GitHub] carbondata issue #1362: [CARBONDATA-1444] Support Boolean data type

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1362
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/368/



---


[GitHub] carbondata issue #1420: [CARBONDATA-1596] Fixed IntermediateFileMerger for d...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1420
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/367/



---


[GitHub] carbondata issue #1422: [CARBONDATA-1599] Optimize pull request template

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1422
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/491/



---


[GitHub] carbondata issue #1422: [CARBONDATA-1599] Optimize pull request template

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1422
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/366/



---


[GitHub] carbondata issue #1420: [CARBONDATA-1596] Fixed IntermediateFileMerger for d...

2017-10-19 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/carbondata/pull/1420
  
@jackylk added integration test instead of unit test.


---


[GitHub] carbondata pull request #1422: [CARBONDATA-1599] Optimize pull request templ...

2017-10-19 Thread chenliang613
GitHub user chenliang613 opened a pull request:

https://github.com/apache/carbondata/pull/1422

[CARBONDATA-1599] Optimize pull request template

Optimize pull request template for reminding contributors to provide full 
information.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenliang613/carbondata pr_template

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1422






---


[GitHub] carbondata issue #1417: [CARBONDATA-1594] Add precision and scale to Decimal...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1417
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/490/



---


[jira] [Created] (CARBONDATA-1599) Optimize pull request template for reminding contributors to provide full info.

2017-10-19 Thread Liang Chen (JIRA)
Liang Chen created CARBONDATA-1599:
--

 Summary: Optimize pull request template for reminding contributors 
to provide full info.
 Key: CARBONDATA-1599
 URL: https://issues.apache.org/jira/browse/CARBONDATA-1599
 Project: CarbonData
  Issue Type: Improvement
  Components: other
Reporter: Liang Chen
Assignee: Liang Chen
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] carbondata issue #1417: [CARBONDATA-1594] Add precision and scale to Decimal...

2017-10-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1417
  
Build Failed with Spark 1.6, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/365/



---


  1   2   >