[GitHub] carbondata issue #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2043
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3790/



---


[GitHub] carbondata issue #2044: [Documentation] Updated Readme for Datamap Feature

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2044
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3789/



---


[GitHub] carbondata pull request #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread ravipesala
Github user ravipesala closed the pull request at:

https://github.com/apache/carbondata/pull/2043


---


[GitHub] carbondata issue #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2043
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4130/



---


[GitHub] carbondata issue #2044: [Documentation] Updated Readme for Datamap Feature

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2044
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4129/



---


[GitHub] carbondata issue #2044: [Documentation] Updated Readme for Datamap Feature

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2044
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2884/



---


[GitHub] carbondata issue #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2043
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3788/



---


[GitHub] carbondata issue #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2043
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2885/



---


[GitHub] carbondata issue #2041: [CARBONDATA-2235]Update configuration-parameters.md

2018-03-07 Thread sgururajshetty
Github user sgururajshetty commented on the issue:

https://github.com/apache/carbondata/pull/2041
  
LGTM


---


[GitHub] carbondata pull request #2044: [Documentation] Updated Readme for Datamap Fe...

2018-03-07 Thread sgururajshetty
GitHub user sgururajshetty opened a pull request:

https://github.com/apache/carbondata/pull/2044

[Documentation] Updated Readme for Datamap Feature

Readme is updated with the links to the following new topics on Datamap
> CarbonData Pre-aggregate DataMap
> CarbonData Timeseries DataMap



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sgururajshetty/carbondata Datamap

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2044


commit 574c69f93bb78cf09daf492634791a3ef30f27fd
Author: sgururajshetty 
Date:   2018-03-08T06:02:17Z

Updated Readme for Datamap
> CarbonData Pre-aggregate DataMap
> CarbonData Timeseries DataMap




---


[GitHub] carbondata pull request #1990: [CARBONDATA-2195] Add new test case for parti...

2018-03-07 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1990#discussion_r173067874
  
--- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableQueryTestCase.scala
 ---
@@ -189,16 +189,15 @@ class StandardPartitionTableQueryTestCase extends 
QueryTest with BeforeAndAfterA
   test("badrecords on partition column") {
 sql("create table badrecordsPartition(intField1 int, stringField1 
string) partitioned by (intField2 int) stored by 'carbondata'")
 sql(s"load data local inpath 
'$resourcesPath/data_partition_badrecords.csv' into table badrecordsPartition 
options('bad_records_action'='force')")
-sql("select count(*) from badrecordsPartition").show()
 checkAnswer(sql("select count(*) cnt from badrecordsPartition where 
intfield2 is null"), Seq(Row(9)))
 checkAnswer(sql("select count(*) cnt from badrecordsPartition where 
intfield2 is not null"), Seq(Row(2)))
   }
 
   test("badrecords fail on partition column") {
 sql("create table badrecordsPartitionfail(intField1 int, stringField1 
string) partitioned by (intField2 int) stored by 'carbondata'")
+//TODO: check message
--- End diff --

you can remove todo and check for the standard bad record message from 
exception


---


[GitHub] carbondata issue #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2043
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4127/



---


[GitHub] carbondata issue #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2043
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3787/



---


[GitHub] carbondata issue #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2043
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2882/



---


[jira] [Resolved] (CARBONDATA-2237) Scala Parser failures are accumulated into memory form thread local

2018-03-07 Thread Venkata Ramana G (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Venkata Ramana G resolved CARBONDATA-2237.
--
   Resolution: Fixed
 Assignee: Ravindra Pesala
Fix Version/s: 1.3.2
   1.4.0

> Scala Parser failures are accumulated into memory form thread local
> ---
>
> Key: CARBONDATA-2237
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2237
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Ravindra Pesala
>Assignee: Ravindra Pesala
>Priority: Major
> Fix For: 1.4.0, 1.3.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2040: [CARBONDATA-2237] Removing parsers thread loc...

2018-03-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2040


---


[GitHub] carbondata issue #2040: [CARBONDATA-2237] Removing parsers thread local obje...

2018-03-07 Thread gvramana
Github user gvramana commented on the issue:

https://github.com/apache/carbondata/pull/2040
  
LGTM


---


[jira] [Created] (CARBONDATA-2237) Scala Parser failures are accumulated into memory form thread local

2018-03-07 Thread Ravindra Pesala (JIRA)
Ravindra Pesala created CARBONDATA-2237:
---

 Summary: Scala Parser failures are accumulated into memory form 
thread local
 Key: CARBONDATA-2237
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2237
 Project: CarbonData
  Issue Type: Bug
Reporter: Ravindra Pesala






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CARBONDATA-2226) Refactor UT's to remove duplicate test scenarios to improve CI time for PreAggregate create and drop feature

2018-03-07 Thread anubhav tarar (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

anubhav tarar updated CARBONDATA-2226:
--
Summary: Refactor UT's to remove duplicate test scenarios to improve CI 
time for PreAggregate create and drop feature  (was: Refactor FT's to remove 
duplicate test scenarios to improve CI time for PreAggregate create and drop 
feature)

> Refactor UT's to remove duplicate test scenarios to improve CI time for 
> PreAggregate create and drop feature
> 
>
> Key: CARBONDATA-2226
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2226
> Project: CarbonData
>  Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Sangeeta Gulia
>Assignee: anubhav tarar
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CARBONDATA-2226) Refactor UT's to remove duplicate test scenarios to improve CI time for PreAggregate create and drop feature

2018-03-07 Thread anubhav tarar (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

anubhav tarar reassigned CARBONDATA-2226:
-

Assignee: anubhav tarar

> Refactor UT's to remove duplicate test scenarios to improve CI time for 
> PreAggregate create and drop feature
> 
>
> Key: CARBONDATA-2226
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2226
> Project: CarbonData
>  Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Sangeeta Gulia
>Assignee: anubhav tarar
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CARBONDATA-2226) Refactor FT's to remove duplicate test scenarios to improve CI time for PreAggregate create and drop feature

2018-03-07 Thread anubhav tarar (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

anubhav tarar updated CARBONDATA-2226:
--
Summary: Refactor FT's to remove duplicate test scenarios to improve CI 
time for PreAggregate create and drop feature  (was: Refactor UT's to remove 
duplicate test scenarios to improve CI time for PreAggregate create and drop 
feature)

> Refactor FT's to remove duplicate test scenarios to improve CI time for 
> PreAggregate create and drop feature
> 
>
> Key: CARBONDATA-2226
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2226
> Project: CarbonData
>  Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Sangeeta Gulia
>Assignee: anubhav tarar
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CARBONDATA-2231) Refactor FT's to remove duplicate test scenarios to improve CI time for Streaming feature

2018-03-07 Thread anubhav tarar (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

anubhav tarar reassigned CARBONDATA-2231:
-

Assignee: anubhav tarar

> Refactor FT's to remove duplicate test scenarios to improve CI time for 
> Streaming feature
> -
>
> Key: CARBONDATA-2231
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2231
> Project: CarbonData
>  Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Geetika Gupta
>Assignee: anubhav tarar
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #1990: [CARBONDATA-2195] Add new test case for parti...

2018-03-07 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1990#discussion_r173064349
  
--- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionBadRecordLoggerTest.scala
 ---
@@ -53,8 +47,7 @@ class StandardPartitionBadRecordLoggerTest extends 
QueryTest with BeforeAndAfter
 " ',', 'QUOTECHAR'= '\"')")
 checkAnswer(
   sql("select count(*) from sales"),
-  Seq(Row(2)
--- End diff --

can move checkAnswer to single line in all places


---


[jira] [Updated] (CARBONDATA-2231) Refactor FT's to remove duplicate test scenarios to improve CI time for Streaming feature

2018-03-07 Thread anubhav tarar (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

anubhav tarar updated CARBONDATA-2231:
--
Summary: Refactor FT's to remove duplicate test scenarios to improve CI 
time for Streaming feature  (was: Refactor UT's to remove duplicate test 
scenarios to improve CI time for Streaming feature)

> Refactor FT's to remove duplicate test scenarios to improve CI time for 
> Streaming feature
> -
>
> Key: CARBONDATA-2231
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2231
> Project: CarbonData
>  Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Geetika Gupta
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2043: [WIP] PR-2030 sdv fix

2018-03-07 Thread ravipesala
GitHub user ravipesala opened a pull request:

https://github.com/apache/carbondata/pull/2043

[WIP] PR-2030 sdv fix

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ravipesala/incubator-carbondata pr-2030-new

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2043.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2043


commit 9086a1b9f2cd6cf1d4d42290a4e3678b01472714
Author: SangeetaGulia 
Date:   2017-09-21T09:26:26Z

[CARBONDATA-1827] S3 Carbon Implementation

1.Provide support for s3 in carbondata.
2.Added S3Example to create carbon table on s3.
3.Added S3CSVExample to load carbon table using csv from s3.

This closes #1805

commit 0c75ab7359ad89a16f749e84bd42416523d5255a
Author: Jacky Li 
Date:   2018-01-02T15:46:14Z

[CARBONDATA-1968] Add external table support

This PR adds support for creating external table with existing carbondata 
files, using Hive syntax.
CREATE EXTERNAL TABLE tableName STORED BY 'carbondata' LOCATION 'path'

This closes #1749

commit 5663e916fe906675ce8efa320de1ed550315dc00
Author: Jacky Li 
Date:   2018-01-06T12:28:44Z

[CARBONDATA-1992] Remove partitionId in CarbonTablePath

In CarbonTablePath, there is a deprecated partition id which is always 0, 
it should be removed to avoid confusion.

This closes #1765

commit bd40a0d73d2a7086caaa6773a2c6a1a45e24334c
Author: Jacky Li 
Date:   2018-01-31T16:25:31Z

[REBASE] Solve conflict after rebasing master

commit 92c9f224094581378a681fd1f7b0cb02b923687c
Author: Jacky Li 
Date:   2018-01-30T13:24:04Z

[CARBONDATA-2099] Refactor query scan process to improve readability

Unified concepts in scan process flow:

1.QueryModel contains all parameter for scan, it is created by API in 
CarbonTable. (In future, CarbonTable will be the entry point for various table 
operations)
2.Use term ColumnChunk to represent one column in one blocklet, and use 
ChunkIndex in reader to read specified column chunk
3.Use term ColumnPage to represent one page in one ColumnChunk
4.QueryColumn => ProjectionColumn, indicating it is for projection

This closes #1874

commit f06824e9744a831776b1203c94d4001eef870b14
Author: Jacky Li 
Date:   2018-01-31T08:14:27Z

[CARBONDATA-2025] Unify all path construction through CarbonTablePath 
static method

Refactory CarbonTablePath:

1.Remove CarbonStorePath and use CarbonTablePath only.
2.Make CarbonTablePath an utility without object creation, it can avoid 
creating object before using it, thus code is cleaner and GC is less.

This closes #1768

commit f9d15a215adc91077f1a6ca6a456e5fce4bc05eb
Author: sounakr 
Date:   2017-09-28T10:51:05Z

[CARBONDATA-1480]Min Max Index Example for DataMap

Datamap Example. Implementation of Min Max Index through Datamap. And Using 
the Index while prunning.

This closes #1359

commit bb5bb00af982831ea83c73a2c437aa4aea8a5422
Author: ravipesala 
Date:   2017-11-15T14:18:40Z

[CARBONDATA-1544][Datamap] Datamap FineGrain implementation

Implemented interfaces for FG datamap and integrated to filterscanner to 
use the pruned bitset from FG datamap.
FG Query flow as follows.
1.The user can add FG datamap to any table and implement there interfaces.
2. Any filter query which hits the table with datamap will call prune 
method of FGdatamap.
3. The prune method of FGDatamap return list FineGrainBlocklet , these 
blocklets contain the information of block, blocklet, page and rowids 
information as well.
4. The pruned blocklets are internally wriitten to file and returns only 
the block , blocklet and filepath information as part of Splits.
5. Based on the splits scanrdd schedule the tasks.
6. In filterscanner we check the datamapwriterpath from split and reNoteads 
the bitset 

[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3786/



---


[GitHub] carbondata issue #2042: [CARBONDATA-2236]added sdv test cases for standard p...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2042
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4126/



---


[GitHub] carbondata issue #2042: [CARBONDATA-2236]added sdv test cases for standard p...

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2042
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3785/



---


[GitHub] carbondata issue #2042: [CARBONDATA-2236]added sdv test cases for standard p...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2042
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2881/



---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
retest sdv please


---


[GitHub] carbondata issue #2042: [CARBONDATA-2236]added sdv test cases for standard p...

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2042
  
add to whitelist


---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3784/



---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
retest sdv please


---


[jira] [Resolved] (CARBONDATA-2234) Support UTF-8 with BOM encoding in CSVInputFormat

2018-03-07 Thread Venkata Ramana G (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Venkata Ramana G resolved CARBONDATA-2234.
--
   Resolution: Fixed
Fix Version/s: 1.3.2
   1.4.0

> Support UTF-8 with BOM encoding in CSVInputFormat
> -
>
> Key: CARBONDATA-2234
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2234
> Project: CarbonData
>  Issue Type: Improvement
>  Components: data-load
>Reporter: Kanaka Kumar Avvaru
>Assignee: Kanaka Kumar Avvaru
>Priority: Minor
> Fix For: 1.4.0, 1.3.2
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> If CSV file is encoded on UTF-8 with BOM , first row first column data is not 
> read correctly during data load.
> If First column is integer & header is false, first row of CSV will be 
> considered as bad record.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2038: [CARBONDATA-2234] Support UTF-8 with BOM in C...

2018-03-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2038


---


[GitHub] carbondata issue #2038: [CARBONDATA-2234] Support UTF-8 with BOM in CSVInput...

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2038
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3783/



---


[GitHub] carbondata issue #2038: [CARBONDATA-2234] Support UTF-8 with BOM in CSVInput...

2018-03-07 Thread gvramana
Github user gvramana commented on the issue:

https://github.com/apache/carbondata/pull/2038
  
LGTM


---


[GitHub] carbondata issue #2042: [CARBONDATA-2236]added sdv test cases for standard p...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2042
  
Can one of the admins verify this patch?


---


[GitHub] carbondata issue #2042: [CARBONDATA-2236]added sdv test cases for standard p...

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2042
  
Can one of the admins verify this patch?


---


[GitHub] carbondata issue #2042: [CARBONDATA-2236]added sdv test cases for standard p...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2042
  
Can one of the admins verify this patch?


---


[GitHub] carbondata pull request #2042: [CARBONDATA-2236]added sdv test cases for sta...

2018-03-07 Thread praveenmeenakshi56
GitHub user praveenmeenakshi56 opened a pull request:

https://github.com/apache/carbondata/pull/2042

[CARBONDATA-2236]added sdv test cases for standard partition

added sdv test cases for standard partition
Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/praveenmeenakshi56/carbondata partition_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2042


commit 718af59351368db4577be1cad4808b9d789abf72
Author: praveenmeenakshi56 
Date:   2018-03-07T15:02:39Z

added sdv test cases for standard partition




---


[jira] [Created] (CARBONDATA-2236) Add SDV Test Cases for Standard Partition

2018-03-07 Thread Praveen M P (JIRA)
Praveen M P created CARBONDATA-2236:
---

 Summary: Add SDV Test Cases for Standard Partition
 Key: CARBONDATA-2236
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2236
 Project: CarbonData
  Issue Type: Bug
Reporter: Praveen M P
Assignee: Praveen M P


Add SDV Test Cases for Standard Partition



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3782/



---


[GitHub] carbondata issue #2038: [CARBONDATA-2234] Support UTF-8 with BOM in CSVInput...

2018-03-07 Thread KanakaKumar
Github user KanakaKumar commented on the issue:

https://github.com/apache/carbondata/pull/2038
  
retest SDV please


---


[GitHub] carbondata issue #2032: [CARBONDATA-2224][File Level Reader Support] Externa...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2032
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4125/



---


[GitHub] carbondata issue #2032: [CARBONDATA-2224][File Level Reader Support] Externa...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2032
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2880/



---


[GitHub] carbondata issue #2034: [CARBONDATA-2288] [Test] Exception is Masked Inside ...

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2034
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3781/



---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
retest sdv please


---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
retest sdv please


---


[GitHub] carbondata issue #2041: [CARBONDATA-2235]Update configuration-parameters.md

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2041
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4124/



---


[GitHub] carbondata issue #2041: [CARBONDATA-2235]Update configuration-parameters.md

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2041
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2879/



---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4123/



---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2878/



---


[GitHub] carbondata issue #2040: [WIP] Removing parsers thread local objects after pa...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2040
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2877/



---


[GitHub] carbondata pull request #2041: [CARBONDATA-2235]Update configuration-paramet...

2018-03-07 Thread akashrn5
GitHub user akashrn5 opened a pull request:

https://github.com/apache/carbondata/pull/2041

[CARBONDATA-2235]Update configuration-parameters.md

**carbon.query.show.datamaps**

This property is a system configuration, if it is set to true, show tables 
will list all the tables including datamaps(ex: Preaggregate) and if it is 
false, show tables will filter the datamaps and only will show the main tables.

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [x] Any interfaces changed?
 NA
 - [x] Any backward compatibility impacted?
 NA
 - [x] Document update required?
YES
 - [x] Testing done
document updation, test is not required
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
NA


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akashrn5/incubator-carbondata patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2041


commit 0175ffd1cbe1d0891f417a869dddc95692e3a768
Author: akashrn5 
Date:   2018-03-07T12:03:10Z

Update configuration-parameters.md




---


[GitHub] carbondata issue #2040: [WIP] Removing parsers thread local objects after pa...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2040
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4121/



---


[GitHub] carbondata issue #2038: [CARBONDATA-2234] Support UTF-8 with BOM in CSVInput...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2038
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4122/



---


[jira] [Created] (CARBONDATA-2235) add system configuration to filter datamaps from show tables command

2018-03-07 Thread Akash R Nilugal (JIRA)
Akash R Nilugal created CARBONDATA-2235:
---

 Summary: add system configuration to filter datamaps from show 
tables command
 Key: CARBONDATA-2235
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2235
 Project: CarbonData
  Issue Type: Bug
  Components: docs
Reporter: Akash R Nilugal
Assignee: Akash R Nilugal


carbon.query.show.datamaps

this property is a system configuration, if it is set to true, show tables will 
list all the tables including datamaps(ex: Preaggregate) and if it is false, 
show tables will filter the datamaps and only will show the main tables



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2038: [CARBONDATA-2234] Support UTF-8 with BOM in CSVInput...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2038
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2876/



---


[jira] [Created] (CARBONDATA-2234) Support UTF-8 with BOM encoding in CSVInputFormat

2018-03-07 Thread Kanaka Kumar Avvaru (JIRA)
Kanaka Kumar Avvaru created CARBONDATA-2234:
---

 Summary: Support UTF-8 with BOM encoding in CSVInputFormat
 Key: CARBONDATA-2234
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2234
 Project: CarbonData
  Issue Type: Improvement
  Components: data-load
Reporter: Kanaka Kumar Avvaru
Assignee: Kanaka Kumar Avvaru


If CSV file is encoded on UTF-8 with BOM , first row first column data is not 
read correctly during data load.

If First column is integer & header is false, first row of CSV will be 
considered as bad record.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2040: [WIP] Removing parsers thread local objects a...

2018-03-07 Thread ravipesala
GitHub user ravipesala opened a pull request:

https://github.com/apache/carbondata/pull/2040

[WIP] Removing parsers thread local objects after parsing of carbon query

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ravipesala/incubator-carbondata 
clear-threadlocal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2040


commit be5b6681e501165e091cd5ebaad7b4e46ef47d45
Author: ravipesala 
Date:   2018-03-07T11:28:30Z

Removing parsers thread local objects after parsing of carbon query




---


[GitHub] carbondata pull request #1990: [CARBONDATA-2195] Add new test case for parti...

2018-03-07 Thread anubhav100
Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1990#discussion_r172795113
  
--- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableQueryTestCase.scala
 ---
@@ -243,11 +242,12 @@ class StandardPartitionTableQueryTestCase extends 
QueryTest with BeforeAndAfterA
 
   }
 
-test("Creation of partition table should fail if the colname in table 
schema and partition column is same even if both are case sensitive"){
-  intercept[Exception]{
-sql("CREATE TABLE uniqdata_char2(name char,id int) partitioned by 
(NAME char)stored by 'carbondata' ")
+  test("Creation of partition table should fail if the colname in table 
schema and partition column is same even if both are case sensitive") {
+//TODO: error message is improper, it is different between spark2.1 
and spark2.2
+intercept[AnalysisException] {
+  sql("CREATE TABLE uniqdata_char2(name char,id int) partitioned by 
(NAME char)stored by 'carbondata' ")
--- End diff --

i fixed this test case with proper exception checking logic for both spark 
version and comments in pr #2034


---


[jira] [Updated] (CARBONDATA-2169) Conflicting classes cause NoSuchMethodError, when our project using org.apache.carbondata:carbondata-hive:1.3.0

2018-03-07 Thread PandaMonkey (JIRA)

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PandaMonkey updated CARBONDATA-2169:

Priority: Minor  (was: Major)

> Conflicting classes cause NoSuchMethodError, when our project using 
> org.apache.carbondata:carbondata-hive:1.3.0
> ---
>
> Key: CARBONDATA-2169
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2169
> Project: CarbonData
>  Issue Type: Bug
>  Components: hive-integration
>Affects Versions: 1.3.0
>Reporter: PandaMonkey
>Priority: Minor
> Fix For: 1.4.0
>
> Attachments: carbondata conflicts.txt
>
>
> Hi, when we using org.apache.carbondata:carbondata-hive:1.3.0, we got 
> *NoSuchMethodError*. And by analyzing the source code, we found the root 
> cause is conflicting classes in different JARs. It means that duplicate 
> classes exist in different JARs, but they have different features, which 
> leads to the really loaded classes are not the actually required ones of our 
> project. (As JVM only load the classes present first on the classpath and 
> shadow the other duplicate ones with the same name.) And such conflictiing 
> problems exist in several JAR pairs dependent by carbondata-hive:1.3.0. The 
> detailed conflicting info is listed in the attachment.
> Conflicting Jar-pairs:
> jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  
> jar-pair:
>  jar-pair:
>  jar-pair:



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2039: [CARBONDATA-2233] [Test] Improve test cases of DBLoc...

2018-03-07 Thread anubhav100
Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2039
  
@mohammadshahidkhan please have a look


---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2875/



---


[GitHub] carbondata issue #2030: Merging datamap branch into master

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2030
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4120/



---


[GitHub] carbondata issue #2039: [CARBONDATA-2233] [Test] Improve test cases of DBLoc...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2039
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2874/



---


[GitHub] carbondata issue #2039: [CARBONDATA-2233] [Test] Improve test cases of DBLoc...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2039
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4119/



---


[GitHub] carbondata issue #2038: [WIP]Support UTF-8 with BOM in CSVInputFormat

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2038
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4118/



---


[GitHub] carbondata issue #2038: [WIP]Support UTF-8 with BOM in CSVInputFormat

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2038
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2873/



---


[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2037
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2872/



---


[GitHub] carbondata issue #2037: [CARBONDATA-2232][DataLoad] Fix incorrect logic in s...

2018-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2037
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4117/



---