[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6035/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7580/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2565 i tested at my machine , the PR is working fine for query data with bloomfilter. ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2565 retest this please ---
[GitHub] carbondata issue #2563: WIP test
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2563 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6034/ ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2570 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6033/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7579/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2565 retest this please ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2560 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6032/ ---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2572 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6031/ ---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2572 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6030/ ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2573 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6333/ ---
[GitHub] carbondata issue #2571: [CARBONDATA-2792][schema restructure] Create externa...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2571 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6029/ ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2573 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7578/ ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2441 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6331/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6332/ ---
[GitHub] carbondata issue #2563: WIP test
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2563 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6028/ ---
[GitHub] carbondata pull request #2573: [CARBONDATA-2794]Distinct count fails on Arra...
GitHub user Indhumathi27 opened a pull request: https://github.com/apache/carbondata/pull/2573 [CARBONDATA-2794]Distinct count fails on ArrayOfStruct This PR fixes Code Generator Error thrown when Select filter contains more than one count of distinct of ArrayofStruct with group by Clause - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [x] Testing done Testcase added - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Indhumathi27/carbondata codegeb Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2573.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2573 commit e9e1cd6e7fcd9603bc35a74ad7981853502fef51 Author: Indhumathi27 Date: 2018-07-27T18:09:50Z [CARBONDATA-2794]Distinct count fails on ArrayOfStruct ---
[jira] [Created] (CARBONDATA-2794) Code Generator Error is thrown when Select filter contains more than one count of distinct of ArrayOfStruct with group by Clause
Indhumathi Muthumurugesh created CARBONDATA-2794: Summary: Code Generator Error is thrown when Select filter contains more than one count of distinct of ArrayOfStruct with group by Clause Key: CARBONDATA-2794 URL: https://issues.apache.org/jira/browse/CARBONDATA-2794 Project: CarbonData Issue Type: Sub-task Reporter: Indhumathi Muthumurugesh Assignee: Indhumathi Muthumurugesh -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2560 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6328/ ---
[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2517 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6330/ ---
[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2553 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6329/ ---
[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2569 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6027/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6327/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7577/ ---
[GitHub] carbondata issue #2571: [CARBONDATA-2792][schema restructure] Create externa...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2571 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6326/ ---
[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2553 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6325/ ---
[GitHub] carbondata issue #2563: WIP test
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2563 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6026/ ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2560 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6324/ ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2441 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7574/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2565 Till now, there is still a problem: for the test case added in Bloom*FunctionSuite, the explain query output will give negative pruned result like: ``` |== CarbonData Profiler == Table Scan on test_rcd - total blocklets: 1 - filter: (city <> null and city = city40) - pruned by Main DataMap - skipped blocklets: 0 - pruned by CG DataMap - name: dm_rcd - provider: bloomfilter - skipped blocklets: -1 | |== Physical Plan == *FileScan carbondata default.test_rcd[id#172,country#173,city#174,population#175,random1#176,random2#177,random3#178,random4#179,random5#180,random6#181,random7#182,random8#183,random9#184,random10#185,random11#186,random12#187] PushedFilters: [IsNotNull(city), EqualTo(city,city40)]| ``` ---
[GitHub] carbondata issue #2562: [HOTFIX] CreateDataMapPost Event was skipped in case...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2562 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6323/ ---
[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2517 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7572/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7575/ ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2560 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7571/ ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2570 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6321/ ---
[GitHub] carbondata issue #2563: WIP test
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2563 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6319/ ---
[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2517 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6025/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7573/ ---
[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2553 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7570/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6322/ ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2560 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6320/ ---
[GitHub] carbondata issue #2563: WIP test
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2563 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7565/ ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user rahulforallp commented on the issue: https://github.com/apache/carbondata/pull/2441 retest this please ---
[GitHub] carbondata issue #2571: [CARBONDATA-2792][schema restructure] Create externa...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2571 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7569/ ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2570 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7568/ ---
[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2569 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6318/ ---
[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2555 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6024/ ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2570 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6317/ ---
[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2517#discussion_r205752516
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
@@ -724,6 +724,7 @@ public void
writeLoadDetailsIntoFile(List listOfSegmentUpd
brWriter.write(metadataInstance);
} catch (IOException ioe) {
LOG.error("Error message: " + ioe.getLocalizedMessage());
+ fileWrite.setFailed();
--- End diff --
@manishgupta88 Thanks for the review.
Agreed with your point eating exception is not a good idea, handled
throwing back at all the places.
---
[GitHub] carbondata issue #2562: [HOTFIX] CreateDataMapPost Event was skipped in case...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2562 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7566/ ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2560 retest this please ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2560 LGTM ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7567/ ---
[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2517#discussion_r205748318
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java
---
@@ -724,6 +724,7 @@ public void
writeLoadDetailsIntoFile(List listOfSegmentUpd
brWriter.write(metadataInstance);
} catch (IOException ioe) {
LOG.error("Error message: " + ioe.getLocalizedMessage());
+ fileWrite.setFailed();
--- End diff --
At some places IO exception is thrown back after setting the flag and some
places exception is not thrown..any specific reason for this?...can we keep the
behavior same..better to throw back the exception at all places
---
[GitHub] carbondata issue #2567: [CARBONDATA-2790][BloomDataMap]Optimize default para...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2567 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6023/ ---
[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2553 retest this please ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2561 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6316/ ---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2572 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6314/ ---
[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure
Github user KanakaKumar commented on the issue: https://github.com/apache/carbondata/pull/2553 LGTM ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2570 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7564/ ---
[GitHub] carbondata issue #2562: [HOTFIX] CreateDataMapPost Event was skipped in case...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2562 retest this please ---
[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2569 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7563/ ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2560 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7562/ ---
[GitHub] carbondata issue #2563: WIP test
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2563 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6313/ ---
[GitHub] carbondata issue #2566: [CARBONDATA-2789] Support Hadoop 2.8.3 eco-system in...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2566 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6022/ ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2561 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7561/ ---
[GitHub] carbondata issue #2568: [Presto-integration-Technical-note] created document...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2568 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6312/ ---
[GitHub] carbondata issue #2572: [CARBONDATA-2793][32k][Doc] Add 32k support in docum...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2572 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7560/ ---
[GitHub] carbondata issue #2571: [CARBONDATA-2792][schema restructure] Create externa...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2571 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6311/ ---
[GitHub] carbondata issue #2571: [CARBONDATA-2792][schema restructure] Create externa...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2571 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7559/ ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2570 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6309/ ---
[GitHub] carbondata issue #2563: WIP test
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2563 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7558/ ---
[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...
Github user Indhumathi27 commented on the issue: https://github.com/apache/carbondata/pull/2569 Retest this please ---
[GitHub] carbondata issue #2560: [HOTFIX] Removed file existence check to improve dat...
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2560 @ravipesala ...handled review comments...kindly review and merge ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2570 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7555/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6021/ ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2561 retest this please. ---
[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2569 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6306/ ---
[GitHub] carbondata issue #2568: [Presto-integration-Technical-note] created document...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2568 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7557/ ---
[GitHub] carbondata issue #2568: [Presto-integration-Technical-note] created document...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2568 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6304/ ---
[GitHub] carbondata pull request #2572: [CARBONDATA-2793][32k][Doc] Add 32k support i...
GitHub user xuchuanyin opened a pull request: https://github.com/apache/carbondata/pull/2572 [CARBONDATA-2793][32k][Doc] Add 32k support in document Update document and add description for long string columns Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuchuanyin/carbondata 0727_32k_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2572.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2572 commit 57d90c05b95bbd970ed911a3f2f0f6a1e7c82edf Author: xuchuanyin Date: 2018-07-27T08:10:44Z Add 32k support in document Update document and add description for long string columns ---
[jira] [Created] (CARBONDATA-2793) Add document for 32k feature
xuchuanyin created CARBONDATA-2793: -- Summary: Add document for 32k feature Key: CARBONDATA-2793 URL: https://issues.apache.org/jira/browse/CARBONDATA-2793 Project: CarbonData Issue Type: Sub-task Reporter: xuchuanyin Assignee: xuchuanyin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2568: [Presto-integration-Technical-note] created document...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2568 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6308/ ---
[GitHub] carbondata issue #2569: [CARBONDATA-2791]Fix Encoding for Double if exceeds ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2569 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7553/ ---
[GitHub] carbondata pull request #2571: [CARBONDATA-2792][schema restructure] Create ...
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2571 [CARBONDATA-2792][schema restructure] Create external table fails post schema restructure. ⦠Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [X] Any interfaces changed? NA - [X] Any backward compatibility impacted? NA - [X] Document update required? NA - [X] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. added test case to validate the create external table post restructure scenario. - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA You can merge this pull request into a Git repository by running: $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata schema_restructure_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2571.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2571 commit eb538ff122a40cd29eea326a525fe801a247aab0 Author: mohammadshahidkhan Date: 2018-07-27T07:21:49Z [CARBONDATA-2792][schema restructure] Create external table fails post schema restructure. ---
[jira] [Created] (CARBONDATA-2792) Create external table fails post schema restructure
Mohammad Shahid Khan created CARBONDATA-2792:
Summary: Create external table fails post schema restructure
Key: CARBONDATA-2792
URL: https://issues.apache.org/jira/browse/CARBONDATA-2792
Project: CarbonData
Issue Type: Bug
Affects Versions: 1.4.0, 1.5.0, 1.4.2
Reporter: Mohammad Shahid Khan
Assignee: Mohammad Shahid Khan
Steps to reproduce.
sql("create table rstest1 (c1 string,c2 int) STORED BY
'org.apache.carbondata.format'")
sql("Alter table rstest1 drop columns(c2)")
sql(
"Alter table rstest1 add columns(c4 string)
TBLPROPERTIES('DICTIONARY_EXCLUDE'='c4', " +
"'DEFAULT.VALUE.c4'='def')")
sql(s"""CREATE EXTERNAL TABLE rsext STORED BY 'carbondata' LOCATION
'$storeLocation/rstest1'""")
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] carbondata pull request #2570: [wip]disable local dictionary by default
Github user praveenmeenakshi56 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2570#discussion_r205687209
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/localdictionary/LocalDictionarySupportCreateTableTest.scala
---
@@ -1575,7 +1571,7 @@ class LocalDictionarySupportCreateTableTest extends
QueryTest with BeforeAndAfte
val descLoc = sql("describe formatted local1").collect
descLoc.find(_.get(0).toString.contains("Local Dictionary Enabled"))
match {
- case Some(row) => assert(row.get(1).toString.contains("true"))
+ case Some(row) => assert(row.get(1).toString.contains("false"))
--- End diff --
If local dictionary is disabled here, it will be the same as previous test
case. Can you make it true and add other properties like
local_dictionary_threshold or local_dictionary_include, etc.
---
[GitHub] carbondata issue #2568: [Presto-integration-Technical-note] created document...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2568 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7550/ ---
[GitHub] carbondata pull request #2570: [wip]disable local dictionary by default
Github user praveenmeenakshi56 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2570#discussion_r205686883
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/localdictionary/LocalDictionarySupportCreateTableTest.scala
---
@@ -1554,7 +1550,7 @@ class LocalDictionarySupportCreateTableTest extends
QueryTest with BeforeAndAfte
val descLoc = sql("describe formatted local1").collect
descLoc.find(_.get(0).toString.contains("Local Dictionary Enabled"))
match {
- case Some(row) => assert(row.get(1).toString.contains("true"))
+ case Some(row) => assert(row.get(1).toString.contains("false"))
--- End diff --
If local dictionary is disabled here, it will be the same as previous test
case. Can you make it true and add other properties like
local_dictionary_threshold or local_dictionary_include, etc.
---
[GitHub] carbondata pull request #2570: [wip]disable local dictionary by default
Github user praveenmeenakshi56 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2570#discussion_r205684804
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/CreateTableWithLocalDictionaryTestCase.scala
---
@@ -28,7 +28,7 @@ class CreateTableWithLocalDictionaryTestCase extends
QueryTest with BeforeAndAft
sql("DROP TABLE IF EXISTS LOCAL1")
}
- test("test local dictionary default configuration") {
+ test("test local dictionary default configuration") {
--- End diff --
remove the extra space.
---
[GitHub] carbondata pull request #2570: [wip]disable local dictionary by default
GitHub user akashrn5 opened a pull request: https://github.com/apache/carbondata/pull/2570 [wip]disable local dictionary by default Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/akashrn5/incubator-carbondata local_default_false Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2570 commit e0c10c5d3bf837278518a259618fe7dee8817564 Author: akashrn5 Date: 2018-07-27T07:01:48Z disable local dictionary by default ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6020/ ---
[GitHub] carbondata pull request #2569: [CARBONDATA-2791]Fix Adaptive Encoding for Do...
GitHub user Indhumathi27 opened a pull request: https://github.com/apache/carbondata/pull/2569 [CARBONDATA-2791]Fix Adaptive Encoding for Double if exceeds LONG.Max_value **What this PR for?** If Factor(decimalcount) * absMaxValue exceeds LONG.MAX_VALUE, then go for direct compression. - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [x] Testing done Testcases added - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Indhumathi27/carbondata adapfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2569.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2569 commit c26897b2d8d37ba4e5361da7585dfe6942c42f5a Author: Indhumathi27 Date: 2018-07-27T06:52:25Z [CARBONDATA-2791]Fix Adaptive Encoding for Double if exceeds LONG.Max_value ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2441 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6302/ ---
[GitHub] carbondata issue #2563: WIP test
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2563 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6305/ ---
[jira] [Created] (CARBONDATA-2791) Fix Adaptive Encoding for Double if exceeds LONG.Max_value
Indhumathi Muthumurugesh created CARBONDATA-2791: Summary: Fix Adaptive Encoding for Double if exceeds LONG.Max_value Key: CARBONDATA-2791 URL: https://issues.apache.org/jira/browse/CARBONDATA-2791 Project: CarbonData Issue Type: Improvement Reporter: Indhumathi Muthumurugesh Assignee: Indhumathi Muthumurugesh -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2552: [CARBONDATA-2781] Added fix for Null Pointer Excpeti...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2552 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6301/ ---
[GitHub] carbondata issue #2563: WIP test
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2563 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7552/ ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2441 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7549/ ---
