Github user tisonkong commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3034#discussion_r244465150
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -84,7 +84,7 @@
private static final CarbonProperties
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3036
Build Failed with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10330/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3034
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2282/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3034
Build Failed with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10331/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3036
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2281/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3036
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2076/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3034
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2077/
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3036
@runzhliu please correct the PR title.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3036
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2280/
---
Github user tisonkong commented on the issue:
https://github.com/apache/carbondata/pull/3034
> LGTM.
> One small issue, for pr title, please add one "blank" after
[CARBONDATA-3126]
No problem. I see some has blank and some not, i will add blank after
brackets next time .
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3034
LGTM.
One small issue, for pr title, please add one "blank" after
[CARBONDATA-3126]
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3034
add to whitelist
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3030
LGTM
---
Github user runzhliu commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3036#discussion_r244462598
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala
---
@@ -483,12 +483,12 @@ class
Github user runzhliu commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3036#discussion_r244462534
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/PartitionFactory.scala
---
@@ -32,7 +32,7 @@ object PartitionFactory {
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3034
add to whitelist
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3036
Build Failed with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10329/
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3036#discussion_r244461434
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -387,7 +382,7 @@ object
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3036#discussion_r244461274
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala
---
@@ -483,12 +483,12 @@ class
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3036
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2075/
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3036#discussion_r244461155
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/PartitionFactory.scala
---
@@ -32,7 +32,7 @@ object PartitionFactory {
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3036
@xubo245 OK, i'll try
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3036
add to whitelist
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3036
@qiuchenjian I tried it before, but there are some limit, not easy to
support it. If you have better way to support it, you can raise a PR to
implement it.
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3036
@xuchuanyin @xubo245 @QiangCai @jackylk Can we enable checkstyle rule
of avoiding unused importsï¼i think it's necessary to keep good code style and
reduce the dependency of a class on
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3035
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10328/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3035
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2279/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3036
Can one of the admins verify this patch?
---
Github user runzhliu commented on the issue:
https://github.com/apache/carbondata/pull/3036
Hi @xubo245 , can you please take a look?
---
GitHub user runzhliu opened a pull request:
https://github.com/apache/carbondata/pull/3036
[CARBONDATA-3208]Remove unused parameters and imports from code
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x]
Github user lamber-ken commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3030#discussion_r29499
--- Diff: docs/csdk-guide.md ---
@@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by
using withBatch(int batch)
## API
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3035
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2074/
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-3194.
--
Resolution: Fixed
Fix Version/s: 1.5.2
> Support Hive Metastore in Presto
[
https://issues.apache.org/jira/browse/CARBONDATA-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3216:
Description:
There are some bugs in CSDK：
1.enableLocalDictionary can' t set false
code：
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/3035
[CARBONDATA-3216] Fix some bugs in CSDK
1.enableLocalDictionary can' t set false
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3019
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3030
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10327/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3030
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2278/
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
beyond resolved CARBONDATA-3173.
Resolution: Fixed
It has merge the documents to the master
> Add hive-guide and other guides
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3034
Can one of the admins verify this patch?
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3034#discussion_r22392
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -84,7 +84,7 @@
private static final CarbonProperties
GitHub user tisonkong opened a pull request:
https://github.com/apache/carbondata/pull/3034
[CARBONDATA-3126]Correct some spell error in CarbonData
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3033#discussion_r21456
--- Diff: docs/datamap-developer-guide.md ---
@@ -3,15 +3,15 @@
### Introduction
DataMap is a data structure that can be used to
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/3019
LGTM
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 resolved CARBONDATA-2999.
-
Resolution: Resolved
> support read schema from S3
> ---
>
>
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3030
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2073/
---
xubo245 created CARBONDATA-3216:
---
Summary: There are some bugs in CSDK
Key: CARBONDATA-3216
URL: https://issues.apache.org/jira/browse/CARBONDATA-3216
Project: CarbonData
Issue Type: Bug
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3030
add to whitelist
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3030#discussion_r244439663
--- Diff: docs/csdk-guide.md ---
@@ -43,114 +43,116 @@ C++ SDK support read batch row. User can set batch by
using withBatch(int batch)
## API
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3030#discussion_r244438958
--- Diff: docs/csdk-guide.md ---
@@ -172,361 +174,360 @@ release the memory and destroy JVM.
## API List
### CarbonWriter
```
-
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
Thanks @chandrasaripaka
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10326/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2277/
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
@NamanRastogi You can merge HybridSorter into
CompactionResultSortProcessor. For unsorted file it will be same flow, for
sorted file you add one adapter(InMemorySortTempFileChunkHolder)
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/3029
@NamanRastogi Lots of code is duplicated here, Please try to unify with
other compactor processor to avoid the duplication.
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2963#discussion_r244344781
--- Diff:
datamap/example/src/main/java/org/apache/carbondata/datamap/minmax/MinMaxDataMapFactory.java
---
@@ -0,0 +1,353 @@
+/*
+ *
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2072/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2274/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3029
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2276/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3019
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10324/
---
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/3027
retest this please
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244332001
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -166,8 +164,9 @@ class
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
@NamanRastogi Please add detail comment for all the changed code
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244331702
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -207,18 +212,34 @@ class
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/3027
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3029
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2071/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3029
Build Failed with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10325/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3019
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2070/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3019
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2275/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10323/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10322/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2273/
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3029#discussion_r244319031
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionExecutor.java
---
@@ -126,17 +128,24 @@ public
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2069/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3033
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2068/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2272/
---
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/3033
[CARBONDATA-3215] Optimize the documentation
When user use the Global dictionary, local dictionaryï¼non-dictionary in
the code, users maybe have some confusion. The same for mvdataMap and
[
https://issues.apache.org/jira/browse/CARBONDATA-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manish Gupta resolved CARBONDATA-3203.
--
Resolution: Fixed
Fix Version/s: 1.5.2
> Compaction failing for table
[
https://issues.apache.org/jira/browse/CARBONDATA-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manish Gupta resolved CARBONDATA-3196.
--
Resolution: Fixed
Fix Version/s: 1.5.2
> Compaction Failing for Complex
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3022
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Failed with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10319/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10321/
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3027#discussion_r244306298
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2996
@NamanRastogi Please fixed the build failure
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3019#discussion_r244104691
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
---
@@ -43,63 +43,78 @@
[
https://issues.apache.org/jira/browse/CARBONDATA-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kumar vishal resolved CARBONDATA-3195.
--
Resolution: Fixed
Assignee: Shardul Singh
> Added validation for inverted
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/3022
LGTM
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3020
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3020
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2067/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2269/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3019
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2268/
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244295612
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -117,4 +116,18 @@ object CarbonSparkUtil
Github user BeyondYourself commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244293682
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -117,4 +116,18 @@ object
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3027
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2066/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3019
Build Failed with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10316/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2065/
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r244291200
--- Diff: README.md ---
@@ -84,3 +85,6 @@ To get involved in CarbonData:
## About
Apache CarbonData is an open source project of The
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3022
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10315/
---
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3032
Please describe the change of this PR
---
1 - 100 of 116 matches
Mail list logo
