[GitHub] carbondata issue #3043: Carbondata 3213

2018-12-31 Thread iture123
Github user iture123 commented on the issue: https://github.com/apache/carbondata/pull/3043 find /data/carbondata -name "*.java" | xargs grep -Lr "Licensed to the Apache Software Foundation" | xargs sed -e '1 r license.java' -e '1N' -i By this command,I add the license. ---

[GitHub] carbondata issue #3043: Carbondata 3213

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3043 Can one of the admins verify this patch? ---

[GitHub] carbondata pull request #3043: Carbondata 3213

2018-12-31 Thread iture123
GitHub user iture123 opened a pull request: https://github.com/apache/carbondata/pull/3043 Carbondata 3213 Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [N] Any interfaces changed? - [N] Any

[jira] [Resolved] (CARBONDATA-3209) Remove unused import

2018-12-31 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3209. - Resolution: Resolved > Remove unused import > > > Key:

[GitHub] carbondata pull request #3038: [CARBONDATA-3209] Remove unused import

2018-12-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3038 ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 @WangGuangxin Thank you for working on it. ---

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3042 @WangQingNa 1. Please optimize this title, for example: [CARBONDATA-3206] Fix some spell errors in CarbonData. 2. Please finish the checklist 3.Please fix the CI errors. ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import

2018-12-31 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/3038 LGTM ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 LGTM ---

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3042 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10354/ ---

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3042 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2100/ ---

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3042 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2305/ ---

[GitHub] carbondata pull request #3042: There are some spell error in CarbonData

2018-12-31 Thread WangQingNa
GitHub user WangQingNa opened a pull request: https://github.com/apache/carbondata/pull/3042 There are some spell error in CarbonData numberofColumnPerIO => numberOfColumnPerIO iexpectedMinSizePerNode => expectedMinSizePerNodeInt parentname => parentName nullformat =>

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread WangQingNa
Github user WangQingNa closed the pull request at: https://github.com/apache/carbondata/pull/3040 ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import

2018-12-31 Thread WangGuangxin
Github user WangGuangxin commented on the issue: https://github.com/apache/carbondata/pull/3038 > @WangGuangxin Please optimize the title: [CARBONDATA-3209] Remove unused import Done ---

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2304/ ---

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10353/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10352/ ---

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2099/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2303/ ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2302/ ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10351/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2098/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread xiaohui0318
Github user xiaohui0318 commented on the issue: https://github.com/apache/carbondata/pull/3032 fix already.tks ---

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10350/ ---

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2301/ ---

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-31 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596104 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -59,13 +64,13 @@ object CarbonSparkUtil {

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2018-12-31 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/3032 please remove blank before '(' ---

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-31 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596094 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -28,11 +29,15 @@ import

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-31 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596067 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -28,11 +29,15 @@ import

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2018-12-31 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r244596100 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -50,7 +55,7 @@ object CarbonSparkUtil {

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2097/ ---

[GitHub] carbondata pull request #3037: [CARBONDATA-3190] Open example module code st...

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3037#discussion_r244593712 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/CarbonReaderExample.java --- @@ -33,127 +29,129 @@ import

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 add to whitelist ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 @WangGuangxin Please optimize the title: [CARBONDATA-3209] Remove unused import ---

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2096/ ---

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592133 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/NonDictionaryFieldConverterImpl.java --- @@ -34,21 +34,21

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592098 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java --- @@ -43,7 +43,7 @@ /** * @return

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592034 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -55,7 +55,7 @@ /** * parent

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3040 @WangQingNa Please optimize the title and finish the checklist in the content of this PR. ---

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3040 add to whitelist ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2018-12-31 Thread zzcclp
Github user zzcclp commented on the issue: https://github.com/apache/carbondata/pull/3037 just one comment, others LGTM. ---

[GitHub] carbondata pull request #3037: [CARBONDATA-3190] Open example module code st...

2018-12-31 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3037#discussion_r244585940 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/CarbonReaderExample.java --- @@ -33,127 +29,129 @@ import

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2300/ ---

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10349/ ---

[GitHub] carbondata issue #3041: [CARBONDATA-3218] Fix schema refresh and wrong query...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3041 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2095/ ---

[jira] [Created] (CARBONDATA-3218) Schema is not refreshing in presto which is changed in spark carbon.

2018-12-31 Thread Ravindra Pesala (JIRA)
Ravindra Pesala created CARBONDATA-3218: --- Summary: Schema is not refreshing in presto which is changed in spark carbon. Key: CARBONDATA-3218 URL: https://issues.apache.org/jira/browse/CARBONDATA-3218

[GitHub] carbondata pull request #3041: [WIP] Fix schema refresh and wrong query resu...

2018-12-31 Thread ravipesala
GitHub user ravipesala opened a pull request: https://github.com/apache/carbondata/pull/3041 [WIP] Fix schema refresh and wrong query result issues in presto. Problem: Schema which is updated in spark is not reflecting in presto. which results in wrong query result in presto.

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread WangQingNa
GitHub user WangQingNa opened a pull request: https://github.com/apache/carbondata/pull/3040 There are some spell error in CarbonData: parentname => parentName nullformat => nullFormat Be sure to do all of the following checklist to help us incorporate your

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3040 Can one of the admins verify this patch? ---

[GitHub] carbondata issue #3039: [CARBONDATA-3217] Optimize implicit filter expressio...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3039 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2299/ ---

[GitHub] carbondata issue #3039: [CARBONDATA-3217] Optimize implicit filter expressio...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3039 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10348/ ---

[GitHub] carbondata issue #3039: [CARBONDATA-3217] Optimize implicit filter expressio...

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3039 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2094/ ---

[jira] [Created] (CARBONDATA-3217) Optimize implicit filter expression performance by removing extra serialization

2018-12-31 Thread Manish Gupta (JIRA)
Manish Gupta created CARBONDATA-3217: Summary: Optimize implicit filter expression performance by removing extra serialization Key: CARBONDATA-3217 URL: https://issues.apache.org/jira/browse/CARBONDATA-3217

[GitHub] carbondata pull request #3039: [WIP] Optimize implicit filter expression per...

2018-12-31 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/3039 [WIP] Optimize implicit filter expression performance by removing extra serialization Fixed performance issue for Implicit filter column 1. Removed serialization all the implicit

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3038 Can one of the admins verify this patch? ---

[GitHub] carbondata pull request #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread WangGuangxin
GitHub user WangGuangxin opened a pull request: https://github.com/apache/carbondata/pull/3038 [CARBONDATA-3209]remove unused import Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed?