[GitHub] [carbondata] CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table] URL: https://github.com/apache/carbondata/pull/3179#issuecomment-485646611 Build Success with Spark 2.1.0, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table] URL: https://github.com/apache/carbondata/pull/3179#issuecomment-485643994 Build Success with Spark 2.1.0, Please check CI

[GitHub] [carbondata] xuchuanyin commented on issue #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on issue #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#issuecomment-485614288 too much code, didn't go through it... I cannot verify the correctness of this PR, only review small part of the code style.

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277489179 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277489371 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277488429 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java ## @@

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277288298 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ##

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277487400 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java ## @@

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277288005 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ##

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277489973 ## File path: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277489260 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277291187 ## File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ## @@

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277287840 ## File path: core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java ## @@ -54,7

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server

2019-04-22 Thread GitBox
xuchuanyin commented on a change in pull request #3177: [CARBONDATA-3306] Distributed index server URL: https://github.com/apache/carbondata/pull/3177#discussion_r277487010 ## File path: core/src/main/java/org/apache/carbondata/core/indexstore/Blocklet.java ## @@ -21,7

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485450292 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3166/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485449533 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11196/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485449379 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2934/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485425063 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11195/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485424959 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2933/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485424527 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3165/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485420985 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3164/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485420386 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11194/

[GitHub] [carbondata] CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182#issuecomment-485420266 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2932/

[GitHub] [carbondata] manishnalla1994 opened a new pull request #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort

2019-04-22 Thread GitBox
manishnalla1994 opened a new pull request #3182: [WIP] [CARBONDATA-3343] Compaction for Range Sort URL: https://github.com/apache/carbondata/pull/3182 Problem: To support Compaction for Range Sort in correct way as earlier it was grouping the ranges/partitions based on taskId which was

[GitHub] [carbondata] xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277284722 ## File path:

[GitHub] [carbondata] CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#issuecomment-485410212 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3163/

[GitHub] [carbondata] CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#issuecomment-485405743 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11193/

[GitHub] [carbondata] CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#issuecomment-485395175 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2931/

[GitHub] [carbondata] CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485393640 Build Success with Spark 2.3.2, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table] URL: https://github.com/apache/carbondata/pull/3179#issuecomment-485393541 Build Failed with Spark 2.2.1, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485392494 Build Success with Spark 2.2.1, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table] URL: https://github.com/apache/carbondata/pull/3179#issuecomment-485390231 Build Success with Spark 2.3.2, Please check CI

[jira] [Updated] (CARBONDATA-3336) Support Binary Data Type

2019-04-22 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3336: Description: CarbonData supports binary data type Version Changes Owner Date 0.1

[GitHub] [carbondata] CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485380445 Build Success with Spark 2.1.0, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table]

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3179: [CARBONDATA-3338] Support Incremental DataLoad for MV Datamap[with single parent table] URL: https://github.com/apache/carbondata/pull/3179#issuecomment-485378486 Build Success with Spark 2.1.0, Please check CI

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277248317 ## File path:

[GitHub] [carbondata] qiuchenjian commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap

2019-04-22 Thread GitBox
qiuchenjian commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap URL: https://github.com/apache/carbondata/pull/3072#issuecomment-485366263 @akashrn5 done This is an automated

[GitHub] [carbondata] qiuchenjian commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias

2019-04-22 Thread GitBox
qiuchenjian commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias URL: https://github.com/apache/carbondata/pull/3122#issuecomment-485365819 @akashrn5 done This is an

[GitHub] [carbondata] xubo245 commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
xubo245 commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485364507 @ajantha-bhat @ravipesala It will throw exception if user doesn't use long string column,

[GitHub] [carbondata] CarbonDataQA commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap URL: https://github.com/apache/carbondata/pull/3072#issuecomment-485363336 Build Success with Spark 2.3.2, Please check CI

[GitHub] [carbondata] qiuchenjian commented on issue #3135: [CARBONDATA-3303] Fix that MV datamap return wrong results when using coalesce and less groupby columns

2019-04-22 Thread GitBox
qiuchenjian commented on issue #3135: [CARBONDATA-3303] Fix that MV datamap return wrong results when using coalesce and less groupby columns URL: https://github.com/apache/carbondata/pull/3135#issuecomment-485362595 @akashrn5 My aim is that query doesn't hit MV table when using

[GitHub] [carbondata] xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277236736 ## File path:

[GitHub] [carbondata] CarbonDataQA commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap URL: https://github.com/apache/carbondata/pull/3072#issuecomment-485361486 Build Success with Spark 2.2.1, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias URL: https://github.com/apache/carbondata/pull/3122#issuecomment-485360585 Build Success with Spark 2.2.1, Please check CI

[GitHub] [carbondata] CarbonDataQA commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias URL: https://github.com/apache/carbondata/pull/3122#issuecomment-485356639 Build Success with Spark 2.3.2, Please check CI

[GitHub] [carbondata] ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property

2019-04-22 Thread GitBox
ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property URL: https://github.com/apache/carbondata/pull/3178#discussion_r277226373 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java

[GitHub] [carbondata] CarbonDataQA commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3072: [CARBONDATA-3247] Support to select all columns when creating MV datamap URL: https://github.com/apache/carbondata/pull/3072#issuecomment-48534 Build Success with Spark 2.1.0, Please check CI

[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection

2019-04-22 Thread GitBox
qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection URL: https://github.com/apache/carbondata/pull/3101#discussion_r277224498 ## File path:

[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection

2019-04-22 Thread GitBox
qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection URL: https://github.com/apache/carbondata/pull/3101#discussion_r277213856 ## File path:

[GitHub] [carbondata] ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property

2019-04-22 Thread GitBox
ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property URL: https://github.com/apache/carbondata/pull/3178#discussion_r277223302 ## File path:

[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery

2019-04-22 Thread GitBox
qiuchenjian commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery URL: https://github.com/apache/carbondata/pull/3129#discussion_r277223011 ## File path:

[GitHub] [carbondata] ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property

2019-04-22 Thread GitBox
ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property URL: https://github.com/apache/carbondata/pull/3178#discussion_r277222966 ## File path:

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection

2019-04-22 Thread GitBox
akashrn5 commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection URL: https://github.com/apache/carbondata/pull/3101#discussion_r277221244 ## File path:

[GitHub] [carbondata] ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property

2019-04-22 Thread GitBox
ravipesala commented on a change in pull request #3178: [CARBONDATA-3348] Support alter SORT_COLUMNS property URL: https://github.com/apache/carbondata/pull/3178#discussion_r277220849 ## File path:

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277220940 ## File path:

[GitHub] [carbondata] CarbonDataQA commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3122: [CARBONDATA-3289] MV datamap doesn't take effect when having clause use alias URL: https://github.com/apache/carbondata/pull/3122#issuecomment-485343938 Build Success with Spark 2.1.0, Please check CI

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277219988 ## File path:

[GitHub] [carbondata] qiuchenjian commented on issue #3128: [CARBONDATA-3294] Fix that MV datamap throw error when using count(1) and case when expression

2019-04-22 Thread GitBox
qiuchenjian commented on issue #3128: [CARBONDATA-3294] Fix that MV datamap throw error when using count(1) and case when expression URL: https://github.com/apache/carbondata/pull/3128#issuecomment-485341823 @akashrn5 this pr didn't add any Rule

[GitHub] [carbondata] qiuchenjian commented on issue #3150: [CARBONDATA-3309] MV datamap supports Spark 2.1

2019-04-22 Thread GitBox
qiuchenjian commented on issue #3150: [CARBONDATA-3309] MV datamap supports Spark 2.1 URL: https://github.com/apache/carbondata/pull/3150#issuecomment-485337719 @akashrn5 we shouldn't change MV code, if we remove 2.1, but some code didn't need to use reflection

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
ajantha-bhat commented on a change in pull request #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#discussion_r277214958 ## File path:

[GitHub] [carbondata] ajantha-bhat commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar

2019-04-22 Thread GitBox
ajantha-bhat commented on issue #3181: [CARBONDATA-3356] Fix the issue when carbonData DataSource read SDK files with varchar URL: https://github.com/apache/carbondata/pull/3181#issuecomment-485337194 @xubo245 : we have a test case for Datsource,

[GitHub] [carbondata] akashrn5 commented on issue #3135: [CARBONDATA-3303] Fix that MV datamap return wrong results when using coalesce and less groupby columns

2019-04-22 Thread GitBox
akashrn5 commented on issue #3135: [CARBONDATA-3303] Fix that MV datamap return wrong results when using coalesce and less groupby columns URL: https://github.com/apache/carbondata/pull/3135#issuecomment-485336926 @qiuchenjian basically here you are making changes so that it will not hit

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery

2019-04-22 Thread GitBox
akashrn5 commented on a change in pull request #3129: [CARBONDATA-3295] Fix that MV datamap throw exception because its rewrite algorithm when query SQL has multiply subquery URL: https://github.com/apache/carbondata/pull/3129#discussion_r277214131 ## File path:

[GitHub] [carbondata] qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection

2019-04-22 Thread GitBox
qiuchenjian commented on a change in pull request #3101: [CARBONDATA-3270] MV support groupby columns don't need be existed in the projection URL: https://github.com/apache/carbondata/pull/3101#discussion_r277213856 ## File path:

[GitHub] [carbondata] CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type

2019-04-22 Thread GitBox
CarbonDataQA commented on issue #3173: [CARBONDATA-3351] Support Binary Data Type URL: https://github.com/apache/carbondata/pull/3173#issuecomment-485334298 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3157/