[GitHub] [carbondata] CarbonDataQA1 commented on issue #3489: [checkstyle] optimize java code checkstyle for SimplifyBooleanExpression
CarbonDataQA1 commented on issue #3489: [checkstyle] optimize java code checkstyle for SimplifyBooleanExpression URL: https://github.com/apache/carbondata/pull/3489#issuecomment-559921252 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1050/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] lamber-ken opened a new pull request #3489: [checkstyle] optimize java code checkstyle for SimplifyBooleanExpression
lamber-ken opened a new pull request #3489: [checkstyle] optimize java code checkstyle for SimplifyBooleanExpression URL: https://github.com/apache/carbondata/pull/3489 Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [x] Any interfaces changed? NO - [x] Any backward compatibility impacted? NO - [x] Document update required? NO - [x] Testing done YES Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NO Optimize java code checkstyle for SimplifyBooleanExpression rule This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list
CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list URL: https://github.com/apache/carbondata/pull/3481#issuecomment-559866259 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1062/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-559848295 Build Failed with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1061/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list
CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list URL: https://github.com/apache/carbondata/pull/3481#issuecomment-559848294 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1057/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule
asfgit closed pull request #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule URL: https://github.com/apache/carbondata/pull/3484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] zzcclp commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule
zzcclp commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule URL: https://github.com/apache/carbondata/pull/3484#issuecomment-559821276 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3476: [CARBONDATA-3593] Fix TOTAL_BLOCKLET_NUM not right when blocklet filt…
jackylk commented on a change in pull request #3476: [CARBONDATA-3593] Fix
TOTAL_BLOCKLET_NUM not right when blocklet filt…
URL: https://github.com/apache/carbondata/pull/3476#discussion_r352116523
##
File path:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
##
@@ -113,6 +113,10 @@ public boolean isScanRequired(DataRefNode dataBlock) {
.get(QueryStatisticsConstants.TOTAL_PAGE_SCANNED);
totalPagesScanned.addCountStatistic(QueryStatisticsConstants.TOTAL_PAGE_SCANNED,
totalPagesScanned.getCount() + dataBlock.numberOfPages());
+QueryStatistic totalBlockletStatistic =
queryStatisticsModel.getStatisticsTypeAndObjMap()
Review comment:
ok, then could you change the output header: "valid_blocklets" change to
"read_blocklets"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3476: [CARBONDATA-3593] Fix TOTAL_BLOCKLET_NUM not right when blocklet filt…
jackylk commented on a change in pull request #3476: [CARBONDATA-3593] Fix
TOTAL_BLOCKLET_NUM not right when blocklet filt…
URL: https://github.com/apache/carbondata/pull/3476#discussion_r352116523
##
File path:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
##
@@ -113,6 +113,10 @@ public boolean isScanRequired(DataRefNode dataBlock) {
.get(QueryStatisticsConstants.TOTAL_PAGE_SCANNED);
totalPagesScanned.addCountStatistic(QueryStatisticsConstants.TOTAL_PAGE_SCANNED,
totalPagesScanned.getCount() + dataBlock.numberOfPages());
+QueryStatistic totalBlockletStatistic =
queryStatisticsModel.getStatisticsTypeAndObjMap()
Review comment:
ok, then could you change the output header: "valid_blocklets" change to
"filtered_bloclklets"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (CARBONDATA-3255) CarbonData provides python interface to support to write and read structured and unstructured data in CarbonData
[ https://issues.apache.org/jira/browse/CARBONDATA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-3255. -- Fix Version/s: 2.0.0 Resolution: Fixed > CarbonData provides python interface to support to write and read structured > and unstructured data in CarbonData > > > Key: CARBONDATA-3255 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3255 > Project: CarbonData > Issue Type: Sub-task >Reporter: Bo Xu >Assignee: Bo Xu >Priority: Major > Fix For: 2.0.0 > > Time Spent: 11h 10m > Remaining Estimate: 0h > > Apache CarbonData already provide Java/ Scala/C++ interface for users, and > more and more people use python to manage and analysis big data, so it's > better to provide python interface to support to write and read structured > and unstructured data in CarbonData, like String, int and binary data: > image/voice/video. It should not dependency Apache Spark. We called it is > PYSDK. > PYSDK based on CarbonData Java SDK, use pyjnius to call java code in python > code. Even though Apache Spark use py4j in PySpark to call java code in > python, but it's low performance when use py4j to read bigdata with > CarbonData format in python code, py4j also show low performance when read > big data in their report: > https://www.py4j.org/advanced_topics.html#performance. JPype is also a > popular tool to call java code in python, but it already stoped update > several years ago, so we can not use it. In our test, pyjnius has high > performance to read big data by call java code in python, so it's good choice > for us. > We already work for these feature several months in > https://github.com/xubo245/pycarbon > Goals: > 1. PYSDK should provide interface to support read data > 2. PYSDK should provide interface to support write data > 3. PYSDK should support basic data types > 4. PYSDK should support projection > 5. PYSDK should support filter -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] asfgit closed pull request #3478: [CARBONDATA-3255] Support python writer and reader SDK
asfgit closed pull request #3478: [CARBONDATA-3255] Support python writer and reader SDK URL: https://github.com/apache/carbondata/pull/3478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3478: [CARBONDATA-3255] Support python writer and reader SDK
jackylk commented on issue #3478: [CARBONDATA-3255] Support python writer and reader SDK URL: https://github.com/apache/carbondata/pull/3478#issuecomment-559774698 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule
CarbonDataQA1 commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule URL: https://github.com/apache/carbondata/pull/3484#issuecomment-559773824 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1058/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule
CarbonDataQA1 commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule URL: https://github.com/apache/carbondata/pull/3484#issuecomment-559765633 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1063/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-559756718 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1056/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (CARBONDATA-3548) Support for Geospatial indexing
[ https://issues.apache.org/jira/browse/CARBONDATA-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venugopal Reddy K updated CARBONDATA-3548: -- Attachment: Geospatial Index Design Doc-OpenSource-Version 2.0.pdf > Support for Geospatial indexing > --- > > Key: CARBONDATA-3548 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3548 > Project: CarbonData > Issue Type: New Feature >Reporter: Venugopal Reddy K >Priority: Major > Attachments: Geospatial Index Design Doc-OpenSource-Version 2.0.pdf, > Geospatial Index Design Doc-OpenSource.pdf > > Time Spent: 27h > Remaining Estimate: 0h > > In general, database may contain geographical location data. For instance, > Telecom operators require to perform analytics based on a particular region, > cell tower IDs(within a region) and/or may include geographical locations for > a particular period of time. At present, Carbon do not have native support to > store geographical locations/coordinates and to do filter queries based on > them. Yet, longitude and latitude of coordinates can be treated as > independent columns, sort hierarchically and store them. > But, when longitude and latitude are treated independently, 2D space > is linearized i.e., points in the two dimensional domain are ordered by > sorting first on longitide and then on latitude. Thus, data is not ordered by > geospatial proximity. Hence range queries require lot of IO operations and > query performance is degraded. > To alleviate it, we can use z-order curve to store geospatial data > points. This ensures that geographically nearer points are present at same > block/blocklet. This reduces the IO operations for range queries and improves > query performance. Also can support polygon queries of geodata. Attached > design document describes in detailed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CARBONDATA-3548) Support for Geospatial indexing
[ https://issues.apache.org/jira/browse/CARBONDATA-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venugopal Reddy K updated CARBONDATA-3548: -- Attachment: (was: Geospatial Index Design Doc-OpenSource-Version 2.0.pdf) > Support for Geospatial indexing > --- > > Key: CARBONDATA-3548 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3548 > Project: CarbonData > Issue Type: New Feature >Reporter: Venugopal Reddy K >Priority: Major > Attachments: Geospatial Index Design Doc-OpenSource-Version 2.0.pdf, > Geospatial Index Design Doc-OpenSource.pdf > > Time Spent: 27h > Remaining Estimate: 0h > > In general, database may contain geographical location data. For instance, > Telecom operators require to perform analytics based on a particular region, > cell tower IDs(within a region) and/or may include geographical locations for > a particular period of time. At present, Carbon do not have native support to > store geographical locations/coordinates and to do filter queries based on > them. Yet, longitude and latitude of coordinates can be treated as > independent columns, sort hierarchically and store them. > But, when longitude and latitude are treated independently, 2D space > is linearized i.e., points in the two dimensional domain are ordered by > sorting first on longitide and then on latitude. Thus, data is not ordered by > geospatial proximity. Hence range queries require lot of IO operations and > query performance is degraded. > To alleviate it, we can use z-order curve to store geospatial data > points. This ensures that geographically nearer points are present at same > block/blocklet. This reduces the IO operations for range queries and improves > query performance. Also can support polygon queries of geodata. Attached > design document describes in detailed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule
CarbonDataQA1 commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule URL: https://github.com/apache/carbondata/pull/3484#issuecomment-559743770 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1049/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (CARBONDATA-3548) Support for Geospatial indexing
[ https://issues.apache.org/jira/browse/CARBONDATA-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venugopal Reddy K updated CARBONDATA-3548: -- Attachment: Geospatial Index Design Doc-OpenSource-Version 2.0.pdf > Support for Geospatial indexing > --- > > Key: CARBONDATA-3548 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3548 > Project: CarbonData > Issue Type: New Feature >Reporter: Venugopal Reddy K >Priority: Major > Attachments: Geospatial Index Design Doc-OpenSource-Version 2.0.pdf, > Geospatial Index Design Doc-OpenSource.pdf > > Time Spent: 27h > Remaining Estimate: 0h > > In general, database may contain geographical location data. For instance, > Telecom operators require to perform analytics based on a particular region, > cell tower IDs(within a region) and/or may include geographical locations for > a particular period of time. At present, Carbon do not have native support to > store geographical locations/coordinates and to do filter queries based on > them. Yet, longitude and latitude of coordinates can be treated as > independent columns, sort hierarchically and store them. > But, when longitude and latitude are treated independently, 2D space > is linearized i.e., points in the two dimensional domain are ordered by > sorting first on longitide and then on latitude. Thus, data is not ordered by > geospatial proximity. Hence range queries require lot of IO operations and > query performance is degraded. > To alleviate it, we can use z-order curve to store geospatial data > points. This ensures that geographically nearer points are present at same > block/blocklet. This reduces the IO operations for range queries and improves > query performance. Also can support polygon queries of geodata. Attached > design document describes in detailed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CARBONDATA-3548) Support for Geospatial indexing
[ https://issues.apache.org/jira/browse/CARBONDATA-3548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venugopal Reddy K updated CARBONDATA-3548: -- Attachment: (was: Geospatial Index Design Doc-OpenSource-Version 2.0.pdf) > Support for Geospatial indexing > --- > > Key: CARBONDATA-3548 > URL: https://issues.apache.org/jira/browse/CARBONDATA-3548 > Project: CarbonData > Issue Type: New Feature >Reporter: Venugopal Reddy K >Priority: Major > Attachments: Geospatial Index Design Doc-OpenSource.pdf > > Time Spent: 27h > Remaining Estimate: 0h > > In general, database may contain geographical location data. For instance, > Telecom operators require to perform analytics based on a particular region, > cell tower IDs(within a region) and/or may include geographical locations for > a particular period of time. At present, Carbon do not have native support to > store geographical locations/coordinates and to do filter queries based on > them. Yet, longitude and latitude of coordinates can be treated as > independent columns, sort hierarchically and store them. > But, when longitude and latitude are treated independently, 2D space > is linearized i.e., points in the two dimensional domain are ordered by > sorting first on longitide and then on latitude. Thus, data is not ordered by > geospatial proximity. Hence range queries require lot of IO operations and > query performance is degraded. > To alleviate it, we can use z-order curve to store geospatial data > points. This ensures that geographically nearer points are present at same > block/blocklet. This reduces the IO operations for range queries and improves > query performance. Also can support polygon queries of geodata. Attached > design document describes in detailed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] zzcclp commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule
zzcclp commented on issue #3484: [checkstyle] optimize java code checkstyle for WhitespaceAfter rule URL: https://github.com/apache/carbondata/pull/3484#issuecomment-559731681 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list
CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list URL: https://github.com/apache/carbondata/pull/3481#issuecomment-559729141 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1048/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-559725892 Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1047/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (CARBONDATA-2863) Refactor CarbonFile Interface to always get updated file status
[ https://issues.apache.org/jira/browse/CARBONDATA-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2863. -- Fix Version/s: 2.0.0 Resolution: Fixed > Refactor CarbonFile Interface to always get updated file status > --- > > Key: CARBONDATA-2863 > URL: https://issues.apache.org/jira/browse/CARBONDATA-2863 > Project: CarbonData > Issue Type: Improvement >Reporter: Kunal Kapoor >Assignee: Kunal Kapoor >Priority: Major > Fix For: 2.0.0 > > Time Spent: 10h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] asfgit closed pull request #2465: [CARBONDATA-2863] Refactored CarbonFile interface
asfgit closed pull request #2465: [CARBONDATA-2863] Refactored CarbonFile interface URL: https://github.com/apache/carbondata/pull/2465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list
CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list URL: https://github.com/apache/carbondata/pull/3481#issuecomment-559717788 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1059/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #2465: [CARBONDATA-2863] Refactored CarbonFile interface
jackylk commented on issue #2465: [CARBONDATA-2863] Refactored CarbonFile interface URL: https://github.com/apache/carbondata/pull/2465#issuecomment-559717048 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios
jackylk commented on issue #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios URL: https://github.com/apache/carbondata/pull/3483#issuecomment-559716902 Good, still have following doubts: 1. If the target table has 100 columns, is there a simpler way to specify what to insert? instead of giving a map by user? 2. I see the benchmark example, it has only 2 million rows but 600 columns, so it is a very wide table. What will the performance look like for a thin and tall table? 3. For the parquet and carbon comparison, what is the performance gain come from. Is the performance gain only because 1 join is avoided? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-559711230 Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1060/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF URL: https://github.com/apache/carbondata/pull/3436#issuecomment-559710338 Build Failed with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1055/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list
CarbonDataQA1 commented on issue #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list URL: https://github.com/apache/carbondata/pull/3481#issuecomment-559710297 Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1054/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
