[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: 
Modified to create and load the table with a nonschema dimension sort column. 
And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#issuecomment-570136966
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1401/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3554: [CARBONDATA-3548]GeoHash column should not be allowed to be configured in column meta cache property

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3554: [CARBONDATA-3548]GeoHash column should 
not be allowed to be configured in column meta cache property
URL: https://github.com/apache/carbondata/pull/3554#issuecomment-570136491
 
 
   Build Success with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1392/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] VenuReddy2103 opened a new pull request #3554: [CARBONDATA-3548]GeoHash column should not be allowed to be configured in column meta cache property

2020-01-01 Thread GitBox
VenuReddy2103 opened a new pull request #3554: [CARBONDATA-3548]GeoHash column 
should not be allowed to be configured in column meta cache property
URL: https://github.com/apache/carbondata/pull/3554
 
 
### Why is this PR needed?
GeoHash column should not be allowed to be configured in column meta cache 
property.
   This PR depends on #3436 
   
### What changes were proposed in this PR?
   During create table and alter table, validate column meta cache property for 
only schema columns instead of all the columns.
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: 
Modified to create and load the table with a nonschema dimension sort column. 
And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#issuecomment-570130480
 
 
   Build Success with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1391/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-570129383
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1411/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] marchpure commented on a change in pull request #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
marchpure commented on a change in pull request #3553: [CARBONDATA-3648] 
Support Alter Table Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#discussion_r362379914
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java
 ##
 @@ -81,7 +81,7 @@ public static String getFolderContainingFile(String 
carbonFilePath) {
 int lastIndex = carbonFilePath.lastIndexOf('/');
 // below code for handling windows environment
 if (-1 == lastIndex) {
-  lastIndex = 
carbonFilePath.lastIndexOf(CarbonCommonConstants.FILE_SEPARATOR);
+  lastIndex = 
carbonFilePath.lastIndexOf(CarbonCommonConstants.WINDOWS_FILE_SEPARATOR);
 
 Review comment:
   Yes, java.io.File.separator is more elegant. I have modified code to use 
java.io.File.separator as you suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: 
Modified to create and load the table with a nonschema dimension sort column. 
And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#issuecomment-570127908
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1400/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-570127988
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1399/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: 
Modified to create and load the table with a nonschema dimension sort column. 
And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#issuecomment-570127771
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1412/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: 
Modified to create and load the table with a nonschema dimension sort column. 
And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#issuecomment-570127598
 
 
   Build Failed  with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1390/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index ser

2020-01-01 Thread GitBox
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] 
[CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter 
query failure with Index server when loaded with global_sort_partition = 
10, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376348
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/cache/CarbonDropCacheCommand.scala
 ##
 @@ -49,18 +49,19 @@ case class CarbonDropCacheCommand(tableIdentifier: 
TableIdentifier, internalCall
 OperationListenerBus.getInstance.fireEvent(dropCacheEvent, 
operationContext)
 
 val cache = CacheProvider.getInstance().getCarbonCache
+// Clearing cache from IndexServer
+if 
(CarbonProperties.getInstance().isDistributedPruningEnabled(carbonTable.getDatabaseName,
+  carbonTable.getTableName)) {
+  LOGGER.info("Clearing cache from IndexServer")
+  DataMapUtil.executeClearDataMapJob(carbonTable, 
DataMapUtil.DISTRIBUTED_JOB_NAME)
+}
 if (cache != null) {
-  // Get all Index files for the specified table.
-  if 
(CarbonProperties.getInstance().isDistributedPruningEnabled(carbonTable.getDatabaseName,
-carbonTable.getTableName)) {
-DataMapUtil.executeClearDataMapJob(carbonTable, 
DataMapUtil.DISTRIBUTED_JOB_NAME)
-  } else {
-// Extract dictionary keys for the table and create cache keys from 
those
-val dictKeys: List[String] = CacheUtil.getAllDictCacheKeys(carbonTable)
-// Remove elements from cache
-cache.removeAll(dictKeys.asJava)
-
DataMapStoreManager.getInstance().clearDataMaps(carbonTable.getAbsoluteTableIdentifier)
-  }
+  LOGGER.info("Clearing cache from driver side")
+  // Extract dictionary keys for the table and create cache keys from those
 
 Review comment:
   please corect the comment, its not clear


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index ser

2020-01-01 Thread GitBox
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] 
[CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter 
query failure with Index server when loaded with global_sort_partition = 
10, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376259
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
 ##
 @@ -125,6 +127,19 @@ class CarbonEnv {
 LOGGER.info("Initialize CarbonEnv completed...")
   }
 
+
+  def createIndexServerTmp(sparkSession: SparkSession): Unit = {
+val path = CarbonUtil.checkAndAppendFileSystemURIScheme(
+  "/tmp/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME)
+if (!FileFactory.isFileExist(path)) {
+// Create the new directory
+LOGGER.info(s"Creating Index Server Tmp folder: ${path} ")
 
 Review comment:
   either give `tmp` or `temp` in log, remove Tmp


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index ser

2020-01-01 Thread GitBox
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] 
[CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter 
query failure with Index server when loaded with global_sort_partition = 
10, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376318
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/cache/CarbonDropCacheCommand.scala
 ##
 @@ -49,18 +49,19 @@ case class CarbonDropCacheCommand(tableIdentifier: 
TableIdentifier, internalCall
 OperationListenerBus.getInstance.fireEvent(dropCacheEvent, 
operationContext)
 
 val cache = CacheProvider.getInstance().getCarbonCache
+// Clearing cache from IndexServer
 
 Review comment:
   change commnet from `clearing` to `clear`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index ser

2020-01-01 Thread GitBox
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] 
[CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter 
query failure with Index server when loaded with global_sort_partition = 
10, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376184
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
 ##
 @@ -125,6 +127,19 @@ class CarbonEnv {
 LOGGER.info("Initialize CarbonEnv completed...")
   }
 
+
 
 Review comment:
   please add method level comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index ser

2020-01-01 Thread GitBox
akashrn5 commented on a change in pull request #3537: [CARBONDATA-3646] 
[CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter 
query failure with Index server when loaded with global_sort_partition = 
10, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362376155
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
 ##
 @@ -71,6 +72,7 @@ class CarbonEnv {
   properties.addProperty(CarbonCommonConstants.STORE_LOCATION, storePath)
 }
 LOGGER.info(s"Initializing CarbonEnv, store location: $storePath")
+createIndexServerTmp(sparkSession);
 
 Review comment:
   please add a comment, why is this required and what is this used for?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index ser

2020-01-01 Thread GitBox
kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] 
[CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter 
query failure with Index server when loaded with global_sort_partition = 
10, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362374604
 
 

 ##
 File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java
 ##
 @@ -3321,7 +3321,7 @@ public static String getIndexServerTempPath(String 
tablePath, String queryId) {
 .getProperty(CarbonCommonConstants.CARBON_INDEX_SERVER_TEMP_PATH);
 if (null == tempFolderPath) {
   tempFolderPath =
-  tablePath + "/" + 
CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME + "/" + queryId;
+  "/tmp/" + CarbonCommonConstants.INDEX_SERVER_TEMP_FOLDER_NAME + "/" 
+ queryId;
 
 Review comment:
   use CarbonCommonConstants.FILE_SEPARATOR instead on "/" in the method


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: Modified to create and load the table with a nonschema dimension sort column. And added InPolygon UDF

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3436: [CARBONDATA-3548]Geospatial Support: 
Modified to create and load the table with a nonschema dimension sort column. 
And added InPolygon UDF
URL: https://github.com/apache/carbondata/pull/3436#issuecomment-570122213
 
 
   Build Success with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1388/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] [CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter query failure with Index ser

2020-01-01 Thread GitBox
kunal642 commented on a change in pull request #3537: [CARBONDATA-3646] 
[CARBONDATA-3647]: 1. Select query * fails when using index server. 2. Filter 
query failure with Index server when loaded with global_sort_partition = 
10, giving Null pointer exception
URL: https://github.com/apache/carbondata/pull/3537#discussion_r362374380
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala
 ##
 @@ -125,6 +127,19 @@ class CarbonEnv {
 LOGGER.info("Initialize CarbonEnv completed...")
   }
 
+
+  def createIndexServerTmp(sparkSession: SparkSession): Unit = {
 
 Review comment:
   We already have a method to create temp folder in CarbonUtil. Please use the 
same method and add the code to change the permission to 777


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-570121841
 
 
   Build Failed  with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1389/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] kunal642 commented on issue #3548: [CARBONDATA-3600]Fix the cleanup failure issue if user fails to access table

2020-01-01 Thread GitBox
kunal642 commented on issue #3548: [CARBONDATA-3600]Fix the cleanup failure 
issue if user fails to access table
URL: https://github.com/apache/carbondata/pull/3548#issuecomment-570121640
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3546: [CARBONDATA-3642] Add column idx in error msg when string length exceed 32000

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3546: [CARBONDATA-3642] Add column idx in 
error msg when string length exceed 32000
URL: https://github.com/apache/carbondata/pull/3546#issuecomment-570118242
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1409/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table 
Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#issuecomment-570116842
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1408/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3546: [CARBONDATA-3642] Add column idx in error msg when string length exceed 32000

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3546: [CARBONDATA-3642] Add column idx in 
error msg when string length exceed 32000
URL: https://github.com/apache/carbondata/pull/3546#issuecomment-570115862
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1397/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table 
Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#issuecomment-570115879
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1396/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table 
Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#issuecomment-570111636
 
 
   Build Success with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1386/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3546: [CARBONDATA-3642] Add column idx in error msg when string length exceed 32000

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3546: [CARBONDATA-3642] Add column idx in 
error msg when string length exceed 32000
URL: https://github.com/apache/carbondata/pull/3546#issuecomment-570111631
 
 
   Build Success with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1387/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (CARBONDATA-3649) hive expression is pushed down to carbon

2020-01-01 Thread xiaohui (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiaohui updated CARBONDATA-3649:

Attachment: 1.png
2.jpeg

> hive expression is pushed down to carbon
> 
>
> Key: CARBONDATA-3649
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3649
> Project: CarbonData
>  Issue Type: Improvement
>  Components: hive-integration
>Reporter: xiaohui
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: 1.png, 2.jpeg
>
>
> When set hive.optimize.index.filter = true, hive expression can be pushed 
> down to carbon to filter the data



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CARBONDATA-3649) hive expression is pushed down to carbon

2020-01-01 Thread xiaohui (Jira)
xiaohui created CARBONDATA-3649:
---

 Summary: hive expression is pushed down to carbon
 Key: CARBONDATA-3649
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3649
 Project: CarbonData
  Issue Type: Improvement
  Components: hive-integration
Reporter: xiaohui
 Fix For: 2.0.0


When set hive.optimize.index.filter = true, hive expression can be pushed down 
to carbon to filter the data



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] marchpure commented on issue #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
marchpure commented on issue #3553: [CARBONDATA-3648] Support Alter Table 
Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#issuecomment-570103346
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] gvramana commented on issue #3483: [CARBONDATA-3597] Support Merge for SCD and CCD scenarios

2020-01-01 Thread GitBox
gvramana commented on issue #3483: [CARBONDATA-3597] Support Merge for SCD and 
CCD scenarios
URL: https://github.com/apache/carbondata/pull/3483#issuecomment-570071304
 
 
   @ravipesala In the PR, inserting new records is done using direct call to 
writer, instead of calling current insert/load flow. This makes many of the 
current features like partitioning, sorting flows will not be compatible with 
merge table. So it is better to write using insert/load flow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-570060954
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1406/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-570057656
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1394/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table 
Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#issuecomment-570054753
 
 
   Build Failed with Spark 2.2.1, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1395/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table 
Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#issuecomment-570054689
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1407/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table Compaction Level Threshold

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3553: [CARBONDATA-3648] Support Alter Table 
Compaction Level Threshold
URL: https://github.com/apache/carbondata/pull/3553#issuecomment-570054610
 
 
   Build Failed  with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1385/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query

2020-01-01 Thread GitBox
CarbonDataQA1 commented on issue #3550: [WIP] Remove global dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-570053332
 
 
   Build Failed  with Spark 2.1.0, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/1384/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services