[GitHub] [carbondata] CarbonDataQA1 commented on issue #3583: [WIP] Support CarbonOutputFormat in Hive

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3583: [WIP] Support CarbonOutputFormat in 
Hive 
URL: https://github.com/apache/carbondata/pull/3583#issuecomment-576542900
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1712/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3588: [CARBONDATA-3271] Update python commit info

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3588: [CARBONDATA-3271] Update python commit 
info
URL: https://github.com/apache/carbondata/pull/3588#issuecomment-576525400
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1711/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] xubo245 opened a new pull request #3588: [CARBONDATA-3271] Update python commit info

2020-01-20 Thread GitBox
xubo245 opened a new pull request #3588: [CARBONDATA-3271] Update python commit 
info
URL: https://github.com/apache/carbondata/pull/3588
 
 
### Why is this PR needed?
  update python commit info

### What changes were proposed in this PR?
 update
   
### Does this PR introduce any user interface change?
 No
   
### Is any new testcase added?
 No
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should 
use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-576504900
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1709/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later optimize insert.

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3538: [WIP] Separate Insert and load to later 
optimize insert.
URL: https://github.com/apache/carbondata/pull/3538#issuecomment-576496694
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1710/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] QiangCai commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)

2020-01-20 Thread GitBox
QiangCai commented on a change in pull request #3586: [CARBONDATA-3668] 
CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r368788562
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
 ##
 @@ -50,7 +48,7 @@ object CarbonThriftServer {
 val builder = SparkSession
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] xubo245 opened a new pull request #3587: [CARBONDATA-3271] Rename pycarbon to pycarbondata

2020-01-20 Thread GitBox
xubo245 opened a new pull request #3587: [CARBONDATA-3271] Rename pycarbon to 
pycarbondata
URL: https://github.com/apache/carbondata/pull/3587
 
 
### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] xubo245 closed pull request #3587: [CARBONDATA-3271] Rename pycarbon to pycarbondata

2020-01-20 Thread GitBox
xubo245 closed pull request #3587: [CARBONDATA-3271] Rename pycarbon to 
pycarbondata
URL: https://github.com/apache/carbondata/pull/3587
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] Support TimeBased Cache expiration using Guava Cache

2020-01-20 Thread GitBox
xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] 
Support TimeBased Cache expiration using Guava Cache
URL: https://github.com/apache/carbondata/pull/3580#discussion_r368769593
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
 ##
 @@ -95,9 +98,17 @@ public CarbonLRUCache(String propertyName, String 
defaultPropertyName) {
* initialize lru cache
*/
   private void initCache() {
+// get duration for cache expiration if configured
+long duration = 
CarbonCommonConstants.CARBON_LRU_CACHE_EXPIRATION_DURATION_IN_MINUTES_DEFAULT;
+String timeBasedExpiration = CarbonProperties.getInstance()
+
.getProperty(CarbonCommonConstants.CARBON_LRU_CACHE_EXPIRATION_DURATION_IN_MINUTES);
+if (null != timeBasedExpiration) {
+  duration = Long.parseLong(timeBasedExpiration);
+}
+// initialise guava cache with time based expiration
 lruCacheMap =
 
 Review comment:
   better to optimize this variable's name -- `lruCache` is enough


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] Support TimeBased Cache expiration using Guava Cache

2020-01-20 Thread GitBox
xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] 
Support TimeBased Cache expiration using Guava Cache
URL: https://github.com/apache/carbondata/pull/3580#discussion_r368768906
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
 ##
 @@ -95,9 +98,17 @@ public CarbonLRUCache(String propertyName, String 
defaultPropertyName) {
* initialize lru cache
*/
   private void initCache() {
+// get duration for cache expiration if configured
+long duration = 
CarbonCommonConstants.CARBON_LRU_CACHE_EXPIRATION_DURATION_IN_MINUTES_DEFAULT;
+String timeBasedExpiration = CarbonProperties.getInstance()
+
.getProperty(CarbonCommonConstants.CARBON_LRU_CACHE_EXPIRATION_DURATION_IN_MINUTES);
+if (null != timeBasedExpiration) {
+  duration = Long.parseLong(timeBasedExpiration);
 
 Review comment:
   forget to validate the content?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] Support TimeBased Cache expiration using Guava Cache

2020-01-20 Thread GitBox
xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] 
Support TimeBased Cache expiration using Guava Cache
URL: https://github.com/apache/carbondata/pull/3580#discussion_r368770941
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
 ##
 @@ -327,15 +309,15 @@ public Cacheable get(String key) {
*/
   public void clear() {
 synchronized (lruCacheMap) {
-  for (Cacheable cachebleObj : lruCacheMap.values()) {
+  for (Cacheable cachebleObj : lruCacheMap.asMap().values()) {
 
 Review comment:
   why not use method `invalidateAll()` ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] Support TimeBased Cache expiration using Guava Cache

2020-01-20 Thread GitBox
xuchuanyin commented on a change in pull request #3580: [CARBONDATA-3665] 
Support TimeBased Cache expiration using Guava Cache
URL: https://github.com/apache/carbondata/pull/3580#discussion_r368769292
 
 

 ##
 File path: 
core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java
 ##
 @@ -95,9 +98,17 @@ public CarbonLRUCache(String propertyName, String 
defaultPropertyName) {
* initialize lru cache
*/
   private void initCache() {
+// get duration for cache expiration if configured
+long duration = 
CarbonCommonConstants.CARBON_LRU_CACHE_EXPIRATION_DURATION_IN_MINUTES_DEFAULT;
+String timeBasedExpiration = CarbonProperties.getInstance()
+
.getProperty(CarbonCommonConstants.CARBON_LRU_CACHE_EXPIRATION_DURATION_IN_MINUTES);
+if (null != timeBasedExpiration) {
+  duration = Long.parseLong(timeBasedExpiration);
+}
+// initialise guava cache with time based expiration
 lruCacheMap =
-new LinkedHashMap(CarbonCommonConstants.DEFAULT_COLLECTION_SIZE, 1.0f,
-true);
+
CacheBuilder.newBuilder().initialCapacity(CarbonCommonConstants.DEFAULT_COLLECTION_SIZE)
+.expireAfterWrite(duration, TimeUnit.MINUTES).build();
 
 Review comment:
   expire after write or access?
   
   besides, guava also support size based cache, will it be supported later?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (CARBONDATA-3271) Apache CarbonData should provides python interface to support deep learning framework to ready and write data from/to CarbonData

2020-01-20 Thread Jacky Li (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Li resolved CARBONDATA-3271.
--
Fix Version/s: 2.0.0
   Resolution: Fixed

> Apache CarbonData should provides python interface to support deep learning 
> framework to ready and write data from/to CarbonData
> 
>
> Key: CARBONDATA-3271
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3271
> Project: CarbonData
>  Issue Type: Sub-task
>Reporter: Bo Xu
>Assignee: Bo Xu
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 13h 40m
>  Remaining Estimate: 0h
>
> Apache CarbonData should provides python interface to support deep learning 
> framework to ready and write data from/to CarbonData, like TensorFlow , 
> MXNet, PyTorch and so on. It should not dependency Apache Spark.
> Goals:
> 1. CarbonData provides python interface to support TensorFlow to ready data 
> from CarbonData for training model
> 2. CarbonData provides python interface to support MXNet to ready data from 
> CarbonData for training model
> 3. CarbonData provides python interface to support PyTorch to ready data from 
> CarbonData for training model
> 4. CarbonData should support epoch function
> 5. CarbonData should support cache for speed up performance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] asfgit closed pull request #3479: [CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-20 Thread GitBox
asfgit closed pull request #3479: [CARBONDATA-3271] Integrating deep learning 
framework TensorFlow
URL: https://github.com/apache/carbondata/pull/3479
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on issue #3479: [CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-20 Thread GitBox
jackylk commented on issue #3479: [CARBONDATA-3271] Integrating deep learning 
framework TensorFlow
URL: https://github.com/apache/carbondata/pull/3479#issuecomment-576319195
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on issue #3479: [CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-20 Thread GitBox
jackylk commented on issue #3479: [CARBONDATA-3271] Integrating deep learning 
framework TensorFlow
URL: https://github.com/apache/carbondata/pull/3479#issuecomment-576319191
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3479: [CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3479: [CARBONDATA-3271] Integrating deep 
learning framework TensorFlow
URL: https://github.com/apache/carbondata/pull/3479#issuecomment-576308823
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1708/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global dictionary in query

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3550: [CARBONDATA-3605] Remove global 
dictionary in query
URL: https://github.com/apache/carbondata/pull/3550#issuecomment-576299200
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1707/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3576: [CARBONDATA-3514] Support spark 2.4 
integration
URL: https://github.com/apache/carbondata/pull/3576#issuecomment-576257262
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1706/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-20 Thread GitBox
jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support 
spark 2.4 integration
URL: https://github.com/apache/carbondata/pull/3576#discussion_r368516506
 
 

 ##
 File path: pom.xml
 ##
 @@ -575,12 +530,14 @@
 
${basedir}/processing/src/main/java
 
${basedir}/hadoop/src/main/java
 
${basedir}/integration/spark2/src/main/scala
-
${basedir}/integration/spark2/src/main/spark2.2
-
${basedir}/integration/spark2/src/main/commonTo2.1And2.2
-
${basedir}/integration/spark2/src/main/commonTo2.2And2.3
+
${basedir}/integration/spark2/src/main/commonTo2.2AndAbove
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-20 Thread GitBox
jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support 
spark 2.4 integration
URL: https://github.com/apache/carbondata/pull/3576#discussion_r368515979
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
 ##
 @@ -134,6 +134,7 @@ case class CarbonDropTableCommand(
   }
   val indexDatamapSchemas =
 DataMapStoreManager.getInstance().getDataMapSchemasOfTable(carbonTable)
+  LOGGER.info(s"Dropping DataMaps in table $tableName, size: " + 
indexDatamapSchemas.size())
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-20 Thread GitBox
jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support 
spark 2.4 integration
URL: https://github.com/apache/carbondata/pull/3576#discussion_r368515360
 
 

 ##
 File path: README.md
 ##
 @@ -28,8 +28,8 @@ Visit count: 
[![HitCount](http://hits.dwyl.io/jackylk/apache/carbondata.svg)](ht
 
 
 ## Status
-Spark2.2:
-[![Build 
Status](https://builds.apache.org/buildStatus/icon?job=carbondata-master-spark-2.2)](https://builds.apache.org/view/A-D/view/CarbonData/job/carbondata-master-spark-2.2/lastBuild/testReport)
+Spark2.3:
+[![Build 
Status](https://builds.apache.org/buildStatus/icon?job=carbondata-master-spark-2.3)](https://builds.apache.org/view/A-D/view/CarbonData/job/carbondata-master-spark-2.2/lastBuild/testReport)
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support spark 2.4 integration

2020-01-20 Thread GitBox
jackylk commented on a change in pull request #3576: [CARBONDATA-3514] Support 
spark 2.4 integration
URL: https://github.com/apache/carbondata/pull/3576#discussion_r368515412
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateDataSourceTableCommand.scala
 ##
 @@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.table
+
+import org.apache.spark.sql.{CarbonEnv, CarbonSource, Row, SparkSession}
+import org.apache.spark.sql.catalyst.catalog.CatalogTable
+import org.apache.spark.sql.execution.command.{CreateDataSourceTableCommand, 
MetadataCommand}
+
+/**
+ * Command to create table in case of 'USING CARBONDATA' DDL
+ *
+ * @param catalogTable catalog table created by spark
+ * @param ignoreIfExists ignore if table exists
+ * @param sparkSession spark session
+ */
+case class CarbonCreateDataSourceTableCommand(
+catalogTable: CatalogTable,
+ignoreIfExists: Boolean,
+sparkSession: SparkSession)
+  extends MetadataCommand {
+
+  override def processMetadata(session: SparkSession): Seq[Row] = {
+// Run the spark command to create table in metastore before saving carbon 
schema
+// in table path.
+// This is required for spark 2.4, because spark 2.4 will fail to create 
table
+// if table path is created before hand
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3583: [WIP] Support CarbonOutputFormat in Hive

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3583: [WIP] Support CarbonOutputFormat in 
Hive 
URL: https://github.com/apache/carbondata/pull/3583#issuecomment-576235325
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1704/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3581: [CARBONDATA-3666] Avoided listing of table dir in refresh command

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3581: [CARBONDATA-3666] Avoided listing of 
table dir in refresh command
URL: https://github.com/apache/carbondata/pull/3581#issuecomment-576233640
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1703/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3586: [CARBONDATA-3668] CarbonSession should 
use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#issuecomment-576195173
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1702/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3585: [DOC] CarbonExtensions doc

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3585: [DOC] CarbonExtensions doc
URL: https://github.com/apache/carbondata/pull/3585#issuecomment-576193806
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1701/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] zzcclp commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)

2020-01-20 Thread GitBox
zzcclp commented on a change in pull request #3586: [CARBONDATA-3668] 
CarbonSession should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r368450926
 
 

 ##
 File path: 
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
 ##
 @@ -50,7 +48,7 @@ object CarbonThriftServer {
 val builder = SparkSession
 
 Review comment:
   the 'storePath' parameter is not required, can remove it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3479: [CARBONDATA-3271] Integrating deep learning framework TensorFlow

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3479: [CARBONDATA-3271] Integrating deep 
learning framework TensorFlow
URL: https://github.com/apache/carbondata/pull/3479#issuecomment-576176338
 
 
   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1700/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] QiangCai opened a new pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)

2020-01-20 Thread GitBox
QiangCai opened a new pull request #3586: [CARBONDATA-3668] CarbonSession 
should use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586
 
 
### Why is this PR needed?
Considering back-compatibility,  CarbonSession should use old flow (not 
CarbonExtensions flow)
   
### What changes were proposed in this PR?
   1. Remove CarbonExtension from CarbonSession
   2. Recover CarbonSessionCatalog
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (CARBONDATA-3668) CarbonSession should use old flow (not CarbonExtensions flow)

2020-01-20 Thread David Cai (Jira)
David Cai created CARBONDATA-3668:
-

 Summary: CarbonSession should use old flow (not CarbonExtensions 
flow)
 Key: CARBONDATA-3668
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3668
 Project: CarbonData
  Issue Type: Improvement
Reporter: David Cai


Considering back-compatibility,  CarbonSession should use old flow (not 
CarbonExtensions flow)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] QiangCai opened a new pull request #3585: [DOC] CarbonExtension doc

2020-01-20 Thread GitBox
QiangCai opened a new pull request #3585: [DOC] CarbonExtension doc
URL: https://github.com/apache/carbondata/pull/3585
 
 
### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [carbondata] CarbonDataQA1 commented on issue #3583: [WIP] Support CarbonOutputFormat in Hive

2020-01-20 Thread GitBox
CarbonDataQA1 commented on issue #3583: [WIP] Support CarbonOutputFormat in 
Hive 
URL: https://github.com/apache/carbondata/pull/3583#issuecomment-576152481
 
 
   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1699/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services