[GitHub] [carbondata] akashrn5 commented on a change in pull request #3725: [CARBONDATA-3783]Alter table drop column on main table is not dropping the eligible secondary index tables

2020-04-26 Thread GitBox
akashrn5 commented on a change in pull request #3725: URL: https://github.com/apache/carbondata/pull/3725#discussion_r415548360 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondryIndex.scala ## @@ -61,6 +62

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3725: [CARBONDATA-3783]Alter table drop column on main table is not dropping the eligible secondary index tables

2020-04-26 Thread GitBox
akashrn5 commented on a change in pull request #3725: URL: https://github.com/apache/carbondata/pull/3725#discussion_r415548051 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondryIndex.scala ## @@ -61,6 +62

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
akashrn5 commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415541668 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/DefaultFileTypeProvider.java ## @@ -110,6 +110,8 @@ public CarbonFile getC

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3727: [CARBONDATA-3778] Change conf.getProperty("carbon.storelocation") to CarbonEvn.getDatabaseLocation in mv module

2020-04-26 Thread GitBox
Indhumathi27 commented on a change in pull request #3727: URL: https://github.com/apache/carbondata/pull/3727#discussion_r415538262 ## File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java ## @@ -121,70 +109,69 @@ private SchemaProvider getSchemaProvider

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415536894 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/DefaultFileTypeProvider.java ## @@ -110,6 +110,8 @@ public CarbonFile

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3727: [CARBONDATA-3778] Change conf.getProperty("carbon.storelocation") to CarbonEvn.getDatabaseLocation in mv module

2020-04-26 Thread GitBox
Indhumathi27 commented on a change in pull request #3727: URL: https://github.com/apache/carbondata/pull/3727#discussion_r415536756 ## File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java ## @@ -105,10 +89,14 @@ private SchemaProvider getSchemaProvider(

[GitHub] [carbondata] kunal642 commented on a change in pull request #3707: [CARBONDATA-3781] Refactor code to optimize partition pruning

2020-04-26 Thread GitBox
kunal642 commented on a change in pull request #3707: URL: https://github.com/apache/carbondata/pull/3707#discussion_r415530526 ## File path: core/src/main/java/org/apache/carbondata/core/index/TableIndex.java ## @@ -177,18 +181,29 @@ public CarbonTable getTable() { } p

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
akashrn5 commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415534713 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/HDFSLocalCarbonFile.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415533124 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/HDFSLocalCarbonFile.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415532612 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1632,6 +1632,8 @@ private CarbonCommonCon

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
akashrn5 commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415531746 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1632,6 +1632,8 @@ private CarbonCommonConstan

[GitHub] [carbondata] ajantha-bhat commented on pull request #3706: [WIP]Fixed MemoryLeak in data load and compaction

2020-04-26 Thread GitBox
ajantha-bhat commented on pull request #3706: URL: https://github.com/apache/carbondata/pull/3706#issuecomment-619742733 @kumarvishal09 : Hi, Any update on this ? we are planning an RC2 release today. 1. Either we can revert the original PR that caused this issue and handle in next

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
akashrn5 commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415531243 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/HDFSLocalCarbonFile.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the

[GitHub] [carbondata] kunal642 commented on a change in pull request #3707: [CARBONDATA-3781] Refactor code to optimize partition pruning

2020-04-26 Thread GitBox
kunal642 commented on a change in pull request #3707: URL: https://github.com/apache/carbondata/pull/3707#discussion_r415530526 ## File path: core/src/main/java/org/apache/carbondata/core/index/TableIndex.java ## @@ -177,18 +181,29 @@ public CarbonTable getTable() { } p

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415529870 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1632,6 +1632,8 @@ private CarbonCommonCon

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415529185 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/HDFSLocalCarbonFile.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3721: [CARBONDATA-3777]Add HDFSLocalCarbonFile implementation to Use FileSystem's LocalFileSystem in cluster mode

2020-04-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3721: URL: https://github.com/apache/carbondata/pull/3721#discussion_r415529185 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/HDFSLocalCarbonFile.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3723: [CARBONDATA-3779]BlockletIndexInputFormat object instantiation failed due to mismatch in constructor params

2020-04-26 Thread GitBox
Indhumathi27 commented on a change in pull request #3723: URL: https://github.com/apache/carbondata/pull/3723#discussion_r415519312 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/TestQueryWithColumnMetCacheAndCacheLevelProperty.scala ##

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3723: [CARBONDATA-3779]BlockletIndexInputFormat object instantiation failed due to mismatch in constructor params

2020-04-26 Thread GitBox
Indhumathi27 commented on a change in pull request #3723: URL: https://github.com/apache/carbondata/pull/3723#discussion_r415518496 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/TestQueryWithColumnMetCacheAndCacheLevelProperty.scala ##

[GitHub] [carbondata] Indhumathi27 commented on pull request #3707: [CARBONDATA-3781] Refactor code to optimize partition pruning

2020-04-26 Thread GitBox
Indhumathi27 commented on pull request #3707: URL: https://github.com/apache/carbondata/pull/3707#issuecomment-619727091 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Indhumathi27 commented on pull request #3714: [CARBONDATA-3773] Skip Validate partition info in Indexserver count star flow

2020-04-26 Thread GitBox
Indhumathi27 commented on pull request #3714: URL: https://github.com/apache/carbondata/pull/3714#issuecomment-619727132 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3727: [CARBONDATA-3778] Change conf.getProperty("carbon.storelocation") to CarbonEvn.getDatabaseLocation in mv module

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3727: URL: https://github.com/apache/carbondata/pull/3727#issuecomment-619691357 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2840/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3727: [CARBONDATA-3778] Change conf.getProperty("carbon.storelocation") to CarbonEvn.getDatabaseLocation in mv module

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3727: URL: https://github.com/apache/carbondata/pull/3727#issuecomment-619685113 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1128/

[GitHub] [carbondata] niuge01 opened a new pull request #3727: [CARBONDATA-3778] Change conf.getProperty("carbon.storelocation") to CarbonEvn.getDatabaseLocation in mv module

2020-04-26 Thread GitBox
niuge01 opened a new pull request #3727: URL: https://github.com/apache/carbondata/pull/3727 ### Why is this PR needed? Change the way of mv module get database location to recommend way. Currently , the recommend way is using CarbonEvn.getDatabaseLocation,not using carbon.storel

[jira] [Resolved] (CARBONDATA-3776) Clean old materialized view implementation

2020-04-26 Thread Zhi Liu (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhi Liu resolved CARBONDATA-3776. - Resolution: Fixed > Clean old materialized view implementation > ---

[jira] [Resolved] (CARBONDATA-3775) Update materialized view document

2020-04-26 Thread Zhi Liu (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhi Liu resolved CARBONDATA-3775. - Resolution: Fixed > Update materialized view document > - >

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3726: [WIP]Presto complex Read Support

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3726: URL: https://github.com/apache/carbondata/pull/3726#issuecomment-619644103 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2839/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3726: [WIP]Presto complex Read Support

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3726: URL: https://github.com/apache/carbondata/pull/3726#issuecomment-619643642 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1127/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619637275 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1126/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619636870 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2838/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619600371 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2837/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619600135 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1125/

[GitHub] [carbondata] dependabot[bot] commented on pull request #3447: Bump dep.jackson.version from 2.6.5 to 2.10.1 in /store/sdk

2020-04-26 Thread GitBox
dependabot[bot] commented on pull request #3447: URL: https://github.com/apache/carbondata/pull/3447#issuecomment-619541119 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot

[GitHub] [carbondata] dependabot[bot] commented on pull request #3456: Bump solr.version from 6.3.0 to 8.3.0 in /datamap/lucene

2020-04-26 Thread GitBox
dependabot[bot] commented on pull request #3456: URL: https://github.com/apache/carbondata/pull/3456#issuecomment-619541094 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619524622 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2835/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619520056 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1123/

[GitHub] [carbondata] kunal642 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
kunal642 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619508328 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3700: [CARBONDATA-3784] Added spark binary version to related modules

2020-04-26 Thread GitBox
CarbonDataQA1 commented on pull request #3700: URL: https://github.com/apache/carbondata/pull/3700#issuecomment-619504515 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1122/