[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
CarbonDataQA1 commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-633064918 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3056/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
CarbonDataQA1 commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-633063889 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1336/

[GitHub] [carbondata] QiangCai commented on pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
QiangCai commented on pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#issuecomment-633044918 if the query has only one simple filter(without and/or), maybe we can try to push down "limit" to filter. So the filter will not require to read all values of all rows.

[GitHub] [carbondata] QiangCai commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
QiangCai commented on a change in pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#discussion_r429538025 ## File path: core/src/main/java/org/apache/carbondata/core/scan/complextypes/ComplexQueryType.java ## @@ -67,4 +67,18 @@ private

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
ajantha-bhat commented on a change in pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519687 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala ##

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
Indhumathi27 commented on a change in pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519286 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala ##

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
ajantha-bhat commented on a change in pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519687 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala ##

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3771: [WIP] pushdown array_contains filter to carbon

2020-05-23 Thread GitBox
Indhumathi27 commented on a change in pull request #3771: URL: https://github.com/apache/carbondata/pull/3771#discussion_r429519286 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala ##