[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3803: During Concurrent loads in main table with SI table with isSITableEnabled = false, one of the concurrent load fails

2020-06-23 Thread GitBox


vikramahuja1001 opened a new pull request #3803:
URL: https://github.com/apache/carbondata/pull/3803


### Why is this PR needed?
   Concurrent load failure in main table with SI table with isSITableEnabled  = 
false

### What changes were proposed in this PR?
   Check if the load name is present in the mainTableDetails array
   Adding compaction case in SILoadEventListenerForFailedSegments
   
### Does this PR introduce any user interface change?
- No
   
### Is any new testcase added?
- No
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3802: Delete Stale Segment files from Metadata folders when SI segments are deleted and added case for compaction in SILoadEventListene

2020-06-23 Thread GitBox


vikramahuja1001 opened a new pull request #3802:
URL: https://github.com/apache/carbondata/pull/3802


### Why is this PR needed?
   In the case when in the SI table a segment is deleted and it's entry is 
deleted from the tablestatus file, during next load command, load into SI 
fails. 

### What changes were proposed in this PR?
   Deleting the .segment file from the metadata folder as it contains the 
mergefilename which does not exist anymore cause the segments are deleted.
   Adding compaction case in SILoadEventListenerForFailedSegments
   
### Does this PR introduce any user interface change?
- No
   
### Is any new testcase added?
- No
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [WIP] [CARBONDATA-3864] Store Size Optimization

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-648623470


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3199/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [WIP] [CARBONDATA-3864] Store Size Optimization

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-648622890


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1473/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] niuge01 commented on pull request #3799: [CARBONDATA-3862] Insert stage performance optimazation

2020-06-23 Thread GitBox


niuge01 commented on pull request #3799:
URL: https://github.com/apache/carbondata/pull/3799#issuecomment-648622942


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-06-23 Thread GitBox


ShreelekhyaG commented on a change in pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#discussion_r444648223



##
File path: 
integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
##
@@ -653,6 +653,21 @@ object CommonUtil {
 storeLocation
   }
 
+  def validateForSpatialTypeColumn(properties: Map[String, String],

Review comment:
   removed `validateSpatialIndexColumn()` from AlterTableUtil as validation 
to add column is no longer required, as spatial column is now part of schema.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-06-23 Thread GitBox


ShreelekhyaG commented on a change in pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#discussion_r444645924



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala
##
@@ -122,7 +161,8 @@ class GeoTest extends QueryTest with BeforeAndAfterAll with 
BeforeAndAfterEach {
 createTable(sourceTable)
 loadData(sourceTable)
 createTable(targetTable, "'SORT_SCOPE'='GLOBAL_SORT',")
-sql(s"insert into  $targetTable select * from $sourceTable")
+sql(s"insert into  $targetTable select timevalue, longitude," +

Review comment:
   Done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (CARBONDATA-3866) Code comment with issue numbers

2020-06-23 Thread ackelcn (Jira)


[ 
https://issues.apache.org/jira/browse/CARBONDATA-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143517#comment-17143517
 ] 

ackelcn commented on CARBONDATA-3866:
-

[https://github.com/apache/carbondata/pull/3801]

 

This pull request highlights the new comments. 

> Code comment with issue numbers
> ---
>
> Key: CARBONDATA-3866
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3866
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: ackelcn
>Priority: Major
>
> When I read the code of carbondata, I find several comments with issue 
> numbers. One of them comes from CSVCarbonWriterTest.java:
> {code:java}
>  // [CARBONDATA-3688]: compressor name is added in data file name 
> @Test public void testFileName() throws IOException { 
>   String path = "./testWriteFiles"; 
>   FileUtils.deleteDirectory(new File(path)); 
>   Field[] fields = new Field[2]; 
>   fields[0] = new Field("name", DataTypes.STRING); 
>   fields[1] = new Field("age", DataTypes.INT); 
>   TestUtil.writeFilesAndVerify(new Schema(fields), path);
> ...
> }{code}
> These comments are quite useful for other programmers and me to understand 
> the code, but I notice that not all issue numbers are written in code 
> comments. It can be already quite tedious to write them into commit messages 
> :)
>  
> To handle the problem, I implemented a tool to automatically instrument issue 
> numbers into code comments. I tried my tool on activemq, and the instrumented 
> version is [https://github.com/ackelcn/carbondatawithissuecomment] 
>  
> To avoid confusion, if there is already an issue number in code comments, my 
> tool ignored the issue number. All my generated comments start from //IC, so 
> it is easy to find them.
>  
> Would you please some feedbacks to my tool? Please feel free to merge my 
> generated comments in your code, if you feel that some are useful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (CARBONDATA-3866) Code comment with issue numbers

2020-06-23 Thread ackelcn (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ackelcn updated CARBONDATA-3866:

Description: 
When I read the code of carbondata, I find several comments with issue numbers. 
One of them comes from CSVCarbonWriterTest.java:
{code:java}
 // [CARBONDATA-3688]: compressor name is added in data file name 
@Test public void testFileName() throws IOException { 
  String path = "./testWriteFiles"; 
  FileUtils.deleteDirectory(new File(path)); 
  Field[] fields = new Field[2]; 
  fields[0] = new Field("name", DataTypes.STRING); 
  fields[1] = new Field("age", DataTypes.INT); 
  TestUtil.writeFilesAndVerify(new Schema(fields), path);
...
}{code}
These comments are quite useful for other programmers and me to understand the 
code, but I notice that not all issue numbers are written in code comments. It 
can be already quite tedious to write them into commit messages :)

 

To handle the problem, I implemented a tool to automatically instrument issue 
numbers into code comments. I tried my tool on activemq, and the instrumented 
version is [https://github.com/ackelcn/carbondata] 

 

To avoid confusion, if there is already an issue number in code comments, my 
tool ignored the issue number. All my generated comments start from //IC, so it 
is easy to find them.

 

Would you please some feedbacks to my tool? Please feel free to merge my 
generated comments in your code, if you feel that some are useful.

  was:
When I read the code of carbondata, I find several comments with issue numbers. 
One of them comes from CSVCarbonWriterTest.java:
{code:java}
 // [CARBONDATA-3688]: compressor name is added in data file name 
@Test public void testFileName() throws IOException { 
  String path = "./testWriteFiles"; 
  FileUtils.deleteDirectory(new File(path)); 
  Field[] fields = new Field[2]; 
  fields[0] = new Field("name", DataTypes.STRING); 
  fields[1] = new Field("age", DataTypes.INT); 
  TestUtil.writeFilesAndVerify(new Schema(fields), path);
...
}{code}
These comments are quite useful for other programmers and me to understand the 
code, but I notice that not all issue numbers are written in code comments. It 
can be already quite tedious to write them into commit messages :)

 

To handle the problem, I implemented a tool to automatically instrument issue 
numbers into code comments. I tried my tool on activemq, and the instrumented 
version is [https://github.com/ackelcn/carbondatawithissuecomment] 

 

To avoid confusion, if there is already an issue number in code comments, my 
tool ignored the issue number. All my generated comments start from //IC, so it 
is easy to find them.

 

Would you please some feedbacks to my tool? Please feel free to merge my 
generated comments in your code, if you feel that some are useful.


> Code comment with issue numbers
> ---
>
> Key: CARBONDATA-3866
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3866
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: ackelcn
>Priority: Major
>
> When I read the code of carbondata, I find several comments with issue 
> numbers. One of them comes from CSVCarbonWriterTest.java:
> {code:java}
>  // [CARBONDATA-3688]: compressor name is added in data file name 
> @Test public void testFileName() throws IOException { 
>   String path = "./testWriteFiles"; 
>   FileUtils.deleteDirectory(new File(path)); 
>   Field[] fields = new Field[2]; 
>   fields[0] = new Field("name", DataTypes.STRING); 
>   fields[1] = new Field("age", DataTypes.INT); 
>   TestUtil.writeFilesAndVerify(new Schema(fields), path);
> ...
> }{code}
> These comments are quite useful for other programmers and me to understand 
> the code, but I notice that not all issue numbers are written in code 
> comments. It can be already quite tedious to write them into commit messages 
> :)
>  
> To handle the problem, I implemented a tool to automatically instrument issue 
> numbers into code comments. I tried my tool on activemq, and the instrumented 
> version is [https://github.com/ackelcn/carbondata] 
>  
> To avoid confusion, if there is already an issue number in code comments, my 
> tool ignored the issue number. All my generated comments start from //IC, so 
> it is easy to find them.
>  
> Would you please some feedbacks to my tool? Please feel free to merge my 
> generated comments in your code, if you feel that some are useful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3801: adding comments with issue numbers.

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801#issuecomment-648585372


   Can one of the admins verify this patch?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] ackelcn opened a new pull request #3801: adding comments with issue numbers.

2020-06-23 Thread GitBox


ackelcn opened a new pull request #3801:
URL: https://github.com/apache/carbondata/pull/3801


### Why is this PR needed?
https://issues.apache.org/jira/browse/CARBONDATA-3866
   This issue report explains the motivation. 

### What changes were proposed in this PR?
   New comments with issue numbers are added. 
   
### Does this PR introduce any user interface change?
- No
   NO
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
   NO
- Yes
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3799: [CARBONDATA-3862] Insert stage performance optimazation

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3799:
URL: https://github.com/apache/carbondata/pull/3799#issuecomment-648577186


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1472/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3799: [CARBONDATA-3862] Insert stage performance optimazation

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3799:
URL: https://github.com/apache/carbondata/pull/3799#issuecomment-648576741


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3198/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (CARBONDATA-3858) Check CDC deltafiles count in the testcase

2020-06-23 Thread Bo Xu (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Xu closed CARBONDATA-3858.
-
  Assignee: (was: Bo Xu)
Resolution: Fixed

> Check CDC deltafiles count in the testcase
> --
>
> Key: CARBONDATA-3858
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3858
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Xingjun Hao
>Priority: Minor
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Current there is no deltafiles count check in the testcase, which shall be 
> supplemented.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (CARBONDATA-3858) Check CDC deltafiles count in the testcase

2020-06-23 Thread Bo Xu (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Xu reopened CARBONDATA-3858:
---

> Check CDC deltafiles count in the testcase
> --
>
> Key: CARBONDATA-3858
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3858
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Xingjun Hao
>Priority: Minor
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Current there is no deltafiles count check in the testcase, which shall be 
> supplemented.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (CARBONDATA-3858) Check CDC deltafiles count in the testcase

2020-06-23 Thread Bo Xu (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Xu reassigned CARBONDATA-3858:
-

Assignee: Bo Xu

> Check CDC deltafiles count in the testcase
> --
>
> Key: CARBONDATA-3858
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3858
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Xingjun Hao
>Assignee: Bo Xu
>Priority: Minor
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Current there is no deltafiles count check in the testcase, which shall be 
> supplemented.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#issuecomment-648386101


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1471/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3774:
URL: https://github.com/apache/carbondata/pull/3774#issuecomment-648385173


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3197/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (CARBONDATA-3869) Consistency of segments check tool between maintable and SI table

2020-06-23 Thread Mahesh Raju Somalaraju (Jira)
Mahesh Raju Somalaraju created CARBONDATA-3869:
--

 Summary: Consistency of segments check tool between maintable and 
SI table
 Key: CARBONDATA-3869
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3869
 Project: CarbonData
  Issue Type: New Feature
Reporter: Mahesh Raju Somalaraju


Tool developed for showing the segment differences between maintable and SI 
table



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (CARBONDATA-3868) create stream command failed with NPE when source table has long_stream_columns with record_format=json

2020-06-23 Thread Mahesh Raju Somalaraju (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahesh Raju Somalaraju closed CARBONDATA-3868.
--
Resolution: Invalid

this is invalid ticket hence closing them

> create stream command failed with NPE when source table has 
> long_stream_columns with record_format=json
> ---
>
> Key: CARBONDATA-3868
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3868
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Mahesh Raju Somalaraju
>Priority: Major
>
> create stream command failed with NPE when source table has 
> long_stream_columns with record_format=json



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (CARBONDATA-3724) Secondary Index enable on partition Table

2020-06-23 Thread Mahesh Raju Somalaraju (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahesh Raju Somalaraju closed CARBONDATA-3724.
--

SI support on partition table is merged to master

> Secondary Index enable on partition Table
> -
>
> Key: CARBONDATA-3724
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3724
> Project: CarbonData
>  Issue Type: New Feature
>Reporter: Mahesh Raju Somalaraju
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 7h 50m
>  Remaining Estimate: 0h
>
> What is Secondary Index table ?
> Currently we have datamaps like, *default datamaps* which are block and 
> blocklet and *coarse grained datamaps* like bloom, and *fine grained 
> datamaps* like lucene
> which helps in better pruning during query. What if we introduce another kind 
> of datamap which can hold blockletId as index? Initial level, we call it as 
> index which
> will work as a child table to the main table like we have MV in our current 
> code.
> The secondary index to carbon table which will be the child table to main 
> table and it can be created on column like we create lucene datamap,
> where we give index columns to create index. In a similar way, we create 
> secondary index on column, so indexes on these column will be blocklet IDs 
> which will
> help in better pruning and faster query when we have a filter query on the 
> index column.
>  
> Existing behaviour:
> Secondary index is not supported for partition table.
> New behaviour:
> Secondary index supports on non partition columns instead of blocking full 
> partition table.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (CARBONDATA-3854) Quote char support to unprintable character like \u0009 \u0010

2020-06-23 Thread Mahesh Raju Somalaraju (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahesh Raju Somalaraju closed CARBONDATA-3854.
--

this issue is merged to master

> Quote char support to unprintable character like \u0009 \u0010
> --
>
> Key: CARBONDATA-3854
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3854
> Project: CarbonData
>  Issue Type: New Feature
>Reporter: Mahesh Raju Somalaraju
>Priority: Minor
> Fix For: 2.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Quote char support to unprintable character like \u0009 \u0010
> Currently carbondata will not support setting quotechar to printable char 
> like \u0009.
> current behaviour is quotechar will through exception if we give more than 
> one character.
>  
> Need to support more than one character same as like delimiter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (CARBONDATA-3868) create stream command failed with NPE when source table has long_stream_columns with record_format=json

2020-06-23 Thread Mahesh Raju Somalaraju (Jira)
Mahesh Raju Somalaraju created CARBONDATA-3868:
--

 Summary: create stream command failed with NPE when source table 
has long_stream_columns with record_format=json
 Key: CARBONDATA-3868
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3868
 Project: CarbonData
  Issue Type: Bug
Reporter: Mahesh Raju Somalaraju


create stream command failed with NPE when source table has long_stream_columns 
with record_format=json



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3799: [CARBONDATA-3862] Insert stage performance optimazation

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3799:
URL: https://github.com/apache/carbondata/pull/3799#issuecomment-648235972


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1470/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3799: [CARBONDATA-3862] Insert stage performance optimazation

2020-06-23 Thread GitBox


CarbonDataQA1 commented on pull request #3799:
URL: https://github.com/apache/carbondata/pull/3799#issuecomment-648234864


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3196/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] asfgit closed pull request #3796: [CARBONDATA-3859] Retry to read tablestatus before throwing EOFException or JsonSyntaxException

2020-06-23 Thread GitBox


asfgit closed pull request #3796:
URL: https://github.com/apache/carbondata/pull/3796


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] jackylk commented on pull request #3796: [CARBONDATA-3859] Retry to read tablestatus before throwing EOFException or JsonSyntaxException

2020-06-23 Thread GitBox


jackylk commented on pull request #3796:
URL: https://github.com/apache/carbondata/pull/3796#issuecomment-648199182


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (CARBONDATA-3867) Show materialized views command not documented in https://github.com/apache/carbondata/blob/master/docs/mv-guide.md

2020-06-23 Thread Chetan Bhat (Jira)
Chetan Bhat created CARBONDATA-3867:
---

 Summary: Show materialized views command not documented in 
https://github.com/apache/carbondata/blob/master/docs/mv-guide.md
 Key: CARBONDATA-3867
 URL: https://issues.apache.org/jira/browse/CARBONDATA-3867
 Project: CarbonData
  Issue Type: Bug
  Components: docs
Affects Versions: 2.0.0
 Environment: 
https://github.com/apache/carbondata/blob/master/docs/mv-guide.md
Reporter: Chetan Bhat


Show materialized views command not documented in 
https://github.com/apache/carbondata/blob/master/docs/mv-guide.md



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (CARBONDATA-3858) Check CDC deltafiles count in the testcase

2020-06-23 Thread Bo Xu (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Xu closed CARBONDATA-3858.
-
Resolution: Fixed

Xingjun Hao  fixed it

> Check CDC deltafiles count in the testcase
> --
>
> Key: CARBONDATA-3858
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3858
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Xingjun Hao
>Priority: Minor
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Current there is no deltafiles count check in the testcase, which shall be 
> supplemented.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] asfgit closed pull request #3793: [CARBONDATA-3858] Check CDC deltafiles count in the testcase

2020-06-23 Thread GitBox


asfgit closed pull request #3793:
URL: https://github.com/apache/carbondata/pull/3793


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] xubo245 commented on pull request #3793: [CARBONDATA-3858] Check CDC deltafiles count in the testcase

2020-06-23 Thread GitBox


xubo245 commented on pull request #3793:
URL: https://github.com/apache/carbondata/pull/3793#issuecomment-647960198


   LGTM, Thanks for your contribution!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (CARBONDATA-3860) Fix IndexServer keeps loading some segments index repeatly

2020-06-23 Thread Bo Xu (Jira)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Xu closed CARBONDATA-3860.
-
Resolution: Fixed

> Fix IndexServer keeps loading some segments index repeatly
> --
>
> Key: CARBONDATA-3860
> URL: https://issues.apache.org/jira/browse/CARBONDATA-3860
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Xingjun Hao
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> In current 
> getTableBlockIndexUniqueIdentifiers function. if the 
> segmentBlockIndexInfo.getSegmentMetaDataInfo() is null, the IndexServer will 
> keeps loading the index of this segment repeatly. We shall avoid to let it 
> affect query performance, considering MetaDataInfo doesn't matter with the 
> query processing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [carbondata] asfgit closed pull request #3795: [CARBONDATA-3860] Fix IndexServer keeps loading some segments index repeatly

2020-06-23 Thread GitBox


asfgit closed pull request #3795:
URL: https://github.com/apache/carbondata/pull/3795


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] xubo245 commented on pull request #3795: [CARBONDATA-3860] Fix IndexServer keeps loading some segments index repeatly

2020-06-23 Thread GitBox


xubo245 commented on pull request #3795:
URL: https://github.com/apache/carbondata/pull/3795#issuecomment-647954697


   LGTM,  Thanks for your contribution!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org