[GitHub] [carbondata] marchpure closed pull request #3622: [CARBONDATA-3702] Clean temp index files in parallel in merge index flow

2020-07-13 Thread GitBox
marchpure closed pull request #3622: URL: https://github.com/apache/carbondata/pull/3622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] marchpure opened a new pull request #3842: [CARBONDATA-3702] Clean temp index files in parallel in merge index flow

2020-07-13 Thread GitBox
marchpure opened a new pull request #3842: URL: https://github.com/apache/carbondata/pull/3842 ### Why is this PR needed? Currently, Cleaning temp index files in the mergeindex flow takes a lot of time, sometimes it will take 2~3 mins, which should be optimized ### What

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3839: [CARBONDATA-3898] Support Option 'carbon.enable.mv'

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3839: URL: https://github.com/apache/carbondata/pull/3839#issuecomment-657974400 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1642/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3839: [CARBONDATA-3898] Support Option 'carbon.enable.mv'

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3839: URL: https://github.com/apache/carbondata/pull/3839#issuecomment-657974163 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3383/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3841: [WIP] : drop materialized view when executed concurrently from 4 concurrent c…

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3841: URL: https://github.com/apache/carbondata/pull/3841#issuecomment-657739506 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3382/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3841: [WIP] : drop materialized view when executed concurrently from 4 concurrent c…

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3841: URL: https://github.com/apache/carbondata/pull/3841#issuecomment-657739220 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1641/

[jira] [Resolved] (CARBONDATA-3852) CCD Merge with Partition Table is giving different results in different spark deploy modes

2020-07-13 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3852. - Fix Version/s: 2.1.0 Resolution: Fixed > CCD Merge with Partition

[jira] [Resolved] (CARBONDATA-3851) Merge Update and Insert with Partition Table is giving different results in different spark deploy modes

2020-07-13 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3851. - Fix Version/s: 2.1.0 Resolution: Fixed > Merge Update and Insert

[GitHub] [carbondata] asfgit closed pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
asfgit closed pull request #3835: URL: https://github.com/apache/carbondata/pull/3835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] akashrn5 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
akashrn5 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657702700 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657684206 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1639/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657681240 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3380/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-657650999 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1638/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-657649018 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3379/

[GitHub] [carbondata] ShreelekhyaG opened a new pull request #3841: [WIP] : drop materialized view when executed concurrently from 4 concurrent c…

2020-07-13 Thread GitBox
ShreelekhyaG opened a new pull request #3841: URL: https://github.com/apache/carbondata/pull/3841 ### Why is this PR needed? drop materialized view when executed concurrently from 4 concurrent client fails in all 4 clients. ### What changes were proposed in this PR? made

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3837: [wip]remove compressor name from tupleID

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3837: URL: https://github.com/apache/carbondata/pull/3837#issuecomment-657630762 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1637/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3837: [wip]remove compressor name from tupleID

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3837: URL: https://github.com/apache/carbondata/pull/3837#issuecomment-657624857 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3378/

[GitHub] [carbondata] Indhumathi27 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
Indhumathi27 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657607506 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657606800 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1636/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657605258 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3377/

[jira] [Resolved] (CARBONDATA-3897) desc formatted on an external table throws StackOverFlow Exception

2020-07-13 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3897. -- Resolution: Fixed > desc formatted on an external table throws StackOverFlow

[GitHub] [carbondata] asfgit closed pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
asfgit closed pull request #3836: URL: https://github.com/apache/carbondata/pull/3836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#issuecomment-657590223 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3376/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#issuecomment-657589847 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1635/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3840: [WIP]test

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3840: URL: https://github.com/apache/carbondata/pull/3840#issuecomment-657574109 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3374/

[GitHub] [carbondata] Indhumathi27 closed pull request #3840: [WIP]test

2020-07-13 Thread GitBox
Indhumathi27 closed pull request #3840: URL: https://github.com/apache/carbondata/pull/3840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3840: [WIP]test

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3840: URL: https://github.com/apache/carbondata/pull/3840#issuecomment-657563386 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1633/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3837: [wip]remove compressor name from tupleID

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3837: URL: https://github.com/apache/carbondata/pull/3837#issuecomment-657559220 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3373/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3837: [wip]remove compressor name from tupleID

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3837: URL: https://github.com/apache/carbondata/pull/3837#issuecomment-657552266 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1632/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657549525 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3372/

[GitHub] [carbondata] akashrn5 commented on pull request #3837: [wip]remove compressor name from tupleID

2020-07-13 Thread GitBox
akashrn5 commented on pull request #3837: URL: https://github.com/apache/carbondata/pull/3837#issuecomment-657544654 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (CARBONDATA-3832) Block Pruning for geospatial polygon expression

2020-07-13 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3832. -- Fix Version/s: 2.1.0 Resolution: Fixed > Block Pruning for geospatial

[GitHub] [carbondata] asfgit closed pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
asfgit closed pull request #3772: URL: https://github.com/apache/carbondata/pull/3772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] kunal642 commented on pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
kunal642 commented on pull request #3772: URL: https://github.com/apache/carbondata/pull/3772#issuecomment-657533884 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
Indhumathi27 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657531694 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
ajantha-bhat commented on a change in pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#discussion_r453612663 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java ## @@ -620,8 +620,9 @@ public static boolean

[jira] [Resolved] (CARBONDATA-3845) Bucket table creation fails with exception for empty BUCKET_NUMBER and BUCKET_COLUMNS

2020-07-13 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3845. -- Fix Version/s: 2.1.0 Resolution: Fixed > Bucket table creation fails with

[GitHub] [carbondata] asfgit closed pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-07-13 Thread GitBox
asfgit closed pull request #3817: URL: https://github.com/apache/carbondata/pull/3817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#issuecomment-657518964 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3375/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#issuecomment-657518486 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1634/

[GitHub] [carbondata] kunal642 commented on a change in pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
kunal642 commented on a change in pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#discussion_r453596871 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java ## @@ -620,8 +620,9 @@ public static boolean

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3772: URL: https://github.com/apache/carbondata/pull/3772#issuecomment-657514136 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1631/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657512354 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1630/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3772: URL: https://github.com/apache/carbondata/pull/3772#issuecomment-657510101 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3371/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#issuecomment-657507315 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3369/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#issuecomment-657506771 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1628/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#issuecomment-657497769 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1629/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#issuecomment-657496412 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3370/

[GitHub] [carbondata] Indhumathi27 opened a new pull request #3840: [WIP]test

2020-07-13 Thread GitBox
Indhumathi27 opened a new pull request #3840: URL: https://github.com/apache/carbondata/pull/3840 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3839: [CARBONDATA-3898] Support Option 'carbon.enable.querywithmv'

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3839: URL: https://github.com/apache/carbondata/pull/3839#issuecomment-657487436 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1627/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3839: [CARBONDATA-3898] Support Option 'carbon.enable.querywithmv'

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3839: URL: https://github.com/apache/carbondata/pull/3839#issuecomment-657487681 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3368/

[jira] [Resolved] (CARBONDATA-3887) Load for global sort table is failing for null values in a string column

2020-07-13 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-3887. -- Resolution: Fixed > Load for global sort table is failing for null values in a

[GitHub] [carbondata] asfgit closed pull request #3822: [CARBONDATA-3887] Fixed insert failure for global sort null data

2020-07-13 Thread GitBox
asfgit closed pull request #3822: URL: https://github.com/apache/carbondata/pull/3822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] akashrn5 commented on pull request #3822: [CARBONDATA-3887] Fixed insert failure for global sort null data

2020-07-13 Thread GitBox
akashrn5 commented on pull request #3822: URL: https://github.com/apache/carbondata/pull/3822#issuecomment-657475860 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] ajantha-bhat commented on pull request #3822: [CARBONDATA-3887] Fixed insert failure for global sort null data

2020-07-13 Thread GitBox
ajantha-bhat commented on pull request #3822: URL: https://github.com/apache/carbondata/pull/3822#issuecomment-657475454 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
Indhumathi27 commented on a change in pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#discussion_r453544523 ## File path: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ## @@ -318,6 +335,13 @@ public

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
Indhumathi27 commented on a change in pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#discussion_r453544294 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala ## @@

[GitHub] [carbondata] ajantha-bhat commented on pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-07-13 Thread GitBox
ajantha-bhat commented on pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#issuecomment-657457014 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] akashrn5 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
akashrn5 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657441200 @Indhumathi27 please update the PR description, no need to cdc, can say partition issue when direct write to hdfs enabled, and in detailed description part can list

[GitHub] [carbondata] VenuReddy2103 commented on pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
VenuReddy2103 commented on pull request #3772: URL: https://github.com/apache/carbondata/pull/3772#issuecomment-657437317 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
akashrn5 commented on a change in pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#discussion_r453499751 ## File path: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ## @@ -318,6 +335,13 @@ public void

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-07-13 Thread GitBox
ShreelekhyaG commented on a change in pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#discussion_r453495963 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala ## @@ -766,13 +766,13 @@ class

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3822: [CARBONDATA-3887] Fixed insert failure for global sort null data

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3822: URL: https://github.com/apache/carbondata/pull/3822#issuecomment-657415115 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1625/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3822: [CARBONDATA-3887] Fixed insert failure for global sort null data

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3822: URL: https://github.com/apache/carbondata/pull/3822#issuecomment-657413267 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3366/

[GitHub] [carbondata] ajantha-bhat commented on pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
ajantha-bhat commented on pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#issuecomment-657410720 LGTM. Will merge once build is passed. This is an automated message from the Apache Git

[GitHub] [carbondata] Indhumathi27 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table On spark cluster deploy mode

2020-07-13 Thread GitBox
Indhumathi27 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657410697 @akashrn5 Fixed and updated the PR. PLease review and merge This is an automated message from the

[GitHub] [carbondata] kunal642 commented on pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
kunal642 commented on pull request #3772: URL: https://github.com/apache/carbondata/pull/3772#issuecomment-657408569 @VenuReddy2103 Please check the failure This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] kunal642 commented on a change in pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
kunal642 commented on a change in pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#discussion_r453481361 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java ## @@ -620,8 +620,9 @@ public static boolean

[GitHub] [carbondata] marchpure commented on pull request #3839: [CARBONDATA-3898] Support Option 'carbon.enable.querywithmv'

2020-07-13 Thread GitBox
marchpure commented on pull request #3839: URL: https://github.com/apache/carbondata/pull/3839#issuecomment-657405972 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] akashrn5 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-07-13 Thread GitBox
akashrn5 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-657403314 @Indhumathi27 the PR contains lot of changes, can you either divide the changes as different commits, each commit for a single improvement point or optimization point, or

[GitHub] [carbondata] akashrn5 commented on pull request #3835: [CARBONDATA-3852] [CARBONDATA-3851] Fix Data update issue with SCD/CDC for partition table when directlyWriteData2Hdfs is enabled

2020-07-13 Thread GitBox
akashrn5 commented on pull request #3835: URL: https://github.com/apache/carbondata/pull/3835#issuecomment-657399639 @Indhumathi27 1. I think, this is not specific to cdc, i think problem can come in case of normal partition table insert into flow also when

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3839: [CARBONDATA-3898] Support Option 'carbon.enable.querywithmv'

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3839: URL: https://github.com/apache/carbondata/pull/3839#issuecomment-657394159 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1624/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3839: [CARBONDATA-3898] Support Option 'carbon.enable.querywithmv'

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3839: URL: https://github.com/apache/carbondata/pull/3839#issuecomment-657393900 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3365/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-07-13 Thread GitBox
ajantha-bhat commented on a change in pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#discussion_r453465582 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala ## @@ -766,13 +766,13 @@ class

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3772: URL: https://github.com/apache/carbondata/pull/3772#issuecomment-657388621 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1623/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3772: [CARBONDATA-3832]Added block and blocket pruning for the polygon expression processing

2020-07-13 Thread GitBox
CarbonDataQA1 commented on pull request #3772: URL: https://github.com/apache/carbondata/pull/3772#issuecomment-657388354 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3364/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3836: [CARBONDATA-3897] Fixed external table with location creation and deleting issues

2020-07-13 Thread GitBox
ajantha-bhat commented on a change in pull request #3836: URL: https://github.com/apache/carbondata/pull/3836#discussion_r453458380 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java ## @@ -620,8 +620,9 @@ public static boolean

[GitHub] [carbondata] akashrn5 commented on pull request #3822: [CARBONDATA-3887] Fixed insert failure for global sort null data

2020-07-13 Thread GitBox
akashrn5 commented on pull request #3822: URL: https://github.com/apache/carbondata/pull/3822#issuecomment-657383823 retest this please This is an automated message from the Apache Git Service. To respond to the message,