[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3850: [CARBONDATA-3907]Reuse firePreLoadEvents and firePostLoadEvents methods from CommonLoadUtils to trigger LoadTablePreExe

VenuReddy2103 commented on a change in pull request #3850: URL: https://github.com/apache/carbondata/pull/3850#discussion_r456466122 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala ## @@ -228,24 +228,1

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3850: [CARBONDATA-3907]Reuse firePreLoadEvents and firePostLoadEvents methods from CommonLoadUtils to trigger LoadTablePreExecutionEvent

CarbonDataQA1 commented on pull request #3850: URL: https://github.com/apache/carbondata/pull/3850#issuecomment-660120301 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1682/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3850: [CARBONDATA-3907]Reuse firePreLoadEvents and firePostLoadEvents methods from CommonLoadUtils to trigger LoadTablePreExecutionEvent

CarbonDataQA1 commented on pull request #3850: URL: https://github.com/apache/carbondata/pull/3850#issuecomment-660119819 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3424/ -

[jira] [Resolved] (CARBONDATA-3909) Insert into select fails after insert decimal value as null and set sort scope to global sort

[ https://issues.apache.org/jira/browse/CARBONDATA-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3909. - Fix Version/s: 2.1.0 Resolution: Fixed > Insert into select fails aft

[GitHub] [carbondata] asfgit closed pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

asfgit closed pull request #3851: URL: https://github.com/apache/carbondata/pull/3851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Created] (CARBONDATA-3913) Table level timestamp support

SHREELEKHYA GAMPA created CARBONDATA-3913: - Summary: Table level timestamp support Key: CARBONDATA-3913 URL: https://issues.apache.org/jira/browse/CARBONDATA-3913 Project: CarbonData

[GitHub] [carbondata] akashrn5 commented on pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

akashrn5 commented on pull request #3851: URL: https://github.com/apache/carbondata/pull/3851#issuecomment-660078011 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3841: [CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent c…

CarbonDataQA1 commented on pull request #3841: URL: https://github.com/apache/carbondata/pull/3841#issuecomment-660061656 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3423/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3841: [CARBONDATA-3899] Drop materialized view when executed concurrently from 4 concurrent c…

CarbonDataQA1 commented on pull request #3841: URL: https://github.com/apache/carbondata/pull/3841#issuecomment-660054214 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1680/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-660051811 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1681/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

CarbonDataQA1 commented on pull request #3851: URL: https://github.com/apache/carbondata/pull/3851#issuecomment-660050232 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3421/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-660048799 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3422/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

CarbonDataQA1 commented on pull request #3851: URL: https://github.com/apache/carbondata/pull/3851#issuecomment-660029721 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1678/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3852: [CARBONDATA-3912] Fixed concurrent locking issue for clean files after load

CarbonDataQA1 commented on pull request #3852: URL: https://github.com/apache/carbondata/pull/3852#issuecomment-660012722 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3416/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3852: [CARBONDATA-3912] Fixed concurrent locking issue for clean files after load

CarbonDataQA1 commented on pull request #3852: URL: https://github.com/apache/carbondata/pull/3852#issuecomment-660010477 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1674/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3826: [CARBONDATA-3889] Cleanup code for carbondata-streaming module

CarbonDataQA1 commented on pull request #3826: URL: https://github.com/apache/carbondata/pull/3826#issuecomment-660008418 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3414/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3826: [CARBONDATA-3889] Cleanup code for carbondata-streaming module

CarbonDataQA1 commented on pull request #3826: URL: https://github.com/apache/carbondata/pull/3826#issuecomment-659992230 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1672/

[GitHub] [carbondata] kevinjmh commented on pull request #3825: [CARBONDATA-3889] Cleanup code for carbondata-common module

kevinjmh commented on pull request #3825: URL: https://github.com/apache/carbondata/pull/3825#issuecomment-659983455 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3825: [CARBONDATA-3889] Cleanup code for carbondata-common module

CarbonDataQA1 commented on pull request #3825: URL: https://github.com/apache/carbondata/pull/3825#issuecomment-659978662 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3413/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3825: [CARBONDATA-3889] Cleanup code for carbondata-common module

CarbonDataQA1 commented on pull request #3825: URL: https://github.com/apache/carbondata/pull/3825#issuecomment-659977333 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1671/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

CarbonDataQA1 commented on pull request #3828: URL: https://github.com/apache/carbondata/pull/3828#issuecomment-659953877 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1677/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

CarbonDataQA1 commented on pull request #3828: URL: https://github.com/apache/carbondata/pull/3828#issuecomment-659951341 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3419/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3843: [CARBONDATA-3911]Fix NullPointerException in case of multiple updates and clean files

CarbonDataQA1 commented on pull request #3843: URL: https://github.com/apache/carbondata/pull/3843#issuecomment-659950913 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1670/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3843: [CARBONDATA-3911]Fix NullPointerException in case of multiple updates and clean files

CarbonDataQA1 commented on pull request #3843: URL: https://github.com/apache/carbondata/pull/3843#issuecomment-659948806 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3412/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-659945334 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3418/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP] Support array with SI

CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-659944291 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1676/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

Indhumathi27 commented on a change in pull request #3851: URL: https://github.com/apache/carbondata/pull/3851#discussion_r456284123 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestGlobalSortDataLoad.scala ## @@ -480,6 +482,19 @

[GitHub] [carbondata] QiangCai commented on pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

QiangCai commented on pull request #3828: URL: https://github.com/apache/carbondata/pull/3828#issuecomment-659942047 @Indhumathi27 I will do it in new PR. This PR focus on the typo. This is an automated message from the A

[GitHub] [carbondata] QiangCai commented on a change in pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

QiangCai commented on a change in pull request #3828: URL: https://github.com/apache/carbondata/pull/3828#discussion_r456282655 ## File path: core/src/main/java/org/apache/carbondata/core/cache/Cacheable.java ## @@ -40,7 +40,7 @@ /** * Method to be used for invalidatin

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

CarbonDataQA1 commented on pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#issuecomment-659940523 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1675/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

CarbonDataQA1 commented on pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#issuecomment-659938594 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3417/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

akashrn5 commented on a change in pull request #3851: URL: https://github.com/apache/carbondata/pull/3851#discussion_r456279789 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestGlobalSortDataLoad.scala ## @@ -480,6 +482,19 @@ cl

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3838: [CARBONDATA-3910]Fix load failure in cluster when csv present in local file system in case of global sort

CarbonDataQA1 commented on pull request #3838: URL: https://github.com/apache/carbondata/pull/3838#issuecomment-659936687 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3411/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3838: [CARBONDATA-3910]Fix load failure in cluster when csv present in local file system in case of global sort

CarbonDataQA1 commented on pull request #3838: URL: https://github.com/apache/carbondata/pull/3838#issuecomment-659936200 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1669/

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r456275841 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala ## @@ -170,11 +171

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456275230 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/stream/StreamBlockletReader.java ## @@ -175,7 +175,7 @@ public int readIntFromStream(

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456274947 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -67,7 +65,7 @@ public CarbonTable getOrCreate

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

CarbonDataQA1 commented on pull request #3851: URL: https://github.com/apache/carbondata/pull/3851#issuecomment-659930643 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1668/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3851: [CARBONDATA-3909] Fix Global sort data load failure issue with Decimal value as NULL

CarbonDataQA1 commented on pull request #3851: URL: https://github.com/apache/carbondata/pull/3851#issuecomment-659929561 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3410/ -

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456272851 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputFormatUtil.java ## @@ -48,7 +48,7 @@ public static CarbonFileIn

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r456272331 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala ## @@ -337,7 +331,7 @@ object CarbonParserUti

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456272176 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/stream/StreamBlockletReader.java ## @@ -175,7 +175,7 @@ public int readIntFromStream(

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

ShreelekhyaG commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r456271810 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSource.scala ## @@ -379,6 +380,17 @@ object CarbonSource { if (isC

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456271731 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java ## @@ -65,7 +65,7 @@ * creates new segment folder

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456271059 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ## @@ -217,16 +217,6 @@ return splits; } -

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456269091 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java ## @@ -259,14 +259,7 @@ public static void setColumnProjec

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3826: [CARBONDATA-3889] Cleanup code for carbondata-streaming module

kevinjmh commented on a change in pull request #3826: URL: https://github.com/apache/carbondata/pull/3826#discussion_r456266671 ## File path: streaming/src/main/java/org/apache/carbondata/streaming/segment/StreamSegment.java ## @@ -400,12 +386,7 @@ public static void recoverFi

[GitHub] [carbondata] nihal0107 opened a new pull request #3852: [CARBONDATA-3912] Fixed concurrent locking issue for clean files after load

nihal0107 opened a new pull request #3852: URL: https://github.com/apache/carbondata/pull/3852 ### Why is this PR needed? If multiple loads are fired at the same time then clean file requests are failing due to failing in lock acquiring. ### What changes were proposed in this

[GitHub] [carbondata] QiangCai commented on a change in pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

QiangCai commented on a change in pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#discussion_r456260367 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java ## @@ -67,7 +65,7 @@ public CarbonTable getOrCreate

[jira] [Created] (CARBONDATA-3912) Clean file requests are failing in case of multiple load due to concurrent locking.

Nihal kumar ojha created CARBONDATA-3912: Summary: Clean file requests are failing in case of multiple load due to concurrent locking. Key: CARBONDATA-3912 URL: https://issues.apache.org/jira/browse/CARBON

[GitHub] [carbondata] QiangCai commented on a change in pull request #3826: [CARBONDATA-3889] Cleanup code for carbondata-streaming module

QiangCai commented on a change in pull request #3826: URL: https://github.com/apache/carbondata/pull/3826#discussion_r456257399 ## File path: streaming/pom.xml ## @@ -95,7 +95,7 @@ org.apache.maven.plugins maven-surefire-plugin 2.18 - +

[GitHub] [carbondata] QiangCai commented on a change in pull request #3826: [CARBONDATA-3889] Cleanup code for carbondata-streaming module

QiangCai commented on a change in pull request #3826: URL: https://github.com/apache/carbondata/pull/3826#discussion_r456257306 ## File path: streaming/src/main/java/org/apache/carbondata/streaming/segment/StreamSegment.java ## @@ -155,38 +160,21 @@ public static String close(