[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666938663 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1837/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666936506 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3576/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666933999 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3575/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666933679 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1836/

[GitHub] [carbondata] xubo245 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-30 Thread GitBox
xubo245 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r463387428 ## File path: sdk/sdk/pom.xml ## @@ -48,6 +48,28 @@ httpclient ${httpclient.version} + + org.apache.parquet +

[GitHub] [carbondata] xubo245 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-30 Thread GitBox
xubo245 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r463387428 ## File path: sdk/sdk/pom.xml ## @@ -48,6 +48,28 @@ httpclient ${httpclient.version} + + org.apache.parquet +

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-666770125 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1834/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-666769815 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3573/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-666586295 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1831/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-666583588 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3570/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666561878 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3572/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666561195 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1833/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666558698 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3571/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3834: URL: https://github.com/apache/carbondata/pull/3834#issuecomment-666558118 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1832/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666540291 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1830/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666539591 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3569/

[jira] [Created] (CARBONDATA-3932) need to change discovery.uri=:8086 to discovery.uri=http://:8086 in https://github.com/apache/carbondata/blob/master/docs/prestos

2020-07-30 Thread Chetan Bhat (Jira)
Chetan Bhat created CARBONDATA-3932: --- Summary: need to change discovery.uri=:8086 to discovery.uri=http://:8086 in https://github.com/apache/carbondata/blob/master/docs/prestosql-guide.md#presto-multinode-cluster-setup-for-carbondata

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-666455308 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3566/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-666448308 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1827/

[GitHub] [carbondata] vikramahuja1001 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
vikramahuja1001 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666418037 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666408126 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3567/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666406352 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1828/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-666397696 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3564/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-666397217 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1825/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-666376506 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1823/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-666375381 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3562/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666372818 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3565/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666368097 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1826/

[GitHub] [carbondata] ShreelekhyaG commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
ShreelekhyaG commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-666343280 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] asfgit closed pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-30 Thread GitBox
asfgit closed pull request #3868: URL: https://github.com/apache/carbondata/pull/3868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-666333047 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1822/

[GitHub] [carbondata] kevinjmh commented on pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-30 Thread GitBox
kevinjmh commented on pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#issuecomment-666331953 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] asfgit closed pull request #3867: [CARBONDATA-3889] Cleanup code typo in carbondata-spark module

2020-07-30 Thread GitBox
asfgit closed pull request #3867: URL: https://github.com/apache/carbondata/pull/3867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-666327149 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3561/

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
akkio-97 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r462856821 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java ## @@ -246,7 +241,28 @@ public

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-666303826 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1818/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-666301519 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3558/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-666285691 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1817/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-666285415 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3557/

[GitHub] [carbondata] MarvinLitt commented on pull request #3855: [CARBONDATA-3863], after using index service clean the temp data

2020-07-30 Thread GitBox
MarvinLitt commented on pull request #3855: URL: https://github.com/apache/carbondata/pull/3855#issuecomment-666257057 @kunal642 @vikramahuja1001 please check this pr This is an automated message from the Apache Git

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-666256774 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1821/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3862: [wip]test issue

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3862: URL: https://github.com/apache/carbondata/pull/3862#issuecomment-666251877 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3560/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-666247824 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1820/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-666245882 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3559/

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
akkio-97 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r462856914 ## File path: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoCarbonVectorizedRecordReader.java ## @@ -176,8 +191,16 @@ private

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-666245267 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1819/

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
akkio-97 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r462856584 ## File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/readers/ArrayStreamReader.java ## @@ -0,0 +1,145 @@ +/* + *

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
akkio-97 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r462856821 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java ## @@ -246,7 +241,28 @@ public

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
akkio-97 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r462856119 ## File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/readers/ArrayStreamReader.java ## @@ -0,0 +1,145 @@ +/* + *

[GitHub] [carbondata] akashrn5 opened a new pull request #3875: [WIP]Presto write transactional

2020-07-30 Thread GitBox
akashrn5 opened a new pull request #3875: URL: https://github.com/apache/carbondata/pull/3875 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3874: [CARBONDATA-3931]Fix Secondary index with index column as DateType giving wrong results

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3874: URL: https://github.com/apache/carbondata/pull/3874#issuecomment-666227657 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3556/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3874: [CARBONDATA-3931]Fix Secondary index with index column as DateType giving wrong results

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3874: URL: https://github.com/apache/carbondata/pull/3874#issuecomment-666227308 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1816/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3874: [CARBONDATA-3931]Fix Secondary index with index column as DateType giving wrong results

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3874: URL: https://github.com/apache/carbondata/pull/3874#issuecomment-666227657 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3556/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3874: [CARBONDATA-3931]Fix Secondary index with index column as DateType giving wrong results

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3874: URL: https://github.com/apache/carbondata/pull/3874#issuecomment-666227308 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1816/

[GitHub] [carbondata] vikramahuja1001 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
vikramahuja1001 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-666119354 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#issuecomment-666183239 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3872: [CARBONDATA-3889] Move java files into the java source directory

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3872: URL: https://github.com/apache/carbondata/pull/3872#issuecomment-666095677 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on a change in pull request #3867: [CARBONDATA-3889] Cleanup code typo in carbondata-spark module

2020-07-30 Thread GitBox
QiangCai commented on a change in pull request #3867: URL: https://github.com/apache/carbondata/pull/3867#discussion_r462713015 ## File path: integration/spark/src/main/scala/org/apache/carbondata/view/MVRefresher.scala ## @@ -68,19 +68,19 @@ object MVRefresher { //

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-30 Thread GitBox
kevinjmh commented on a change in pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#discussion_r462763715 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ## @@ -722,15 +719,11 @@ public int

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
ajantha-bhat commented on a change in pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#discussion_r462751220 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala ## @@ -228,8 +230,15 @@ class

[GitHub] [carbondata] akkio-97 commented on a change in pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
akkio-97 commented on a change in pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#discussion_r462599726 ## File path: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java ## @@ -508,7 +508,8 @@ private

[GitHub] [carbondata] ShreelekhyaG commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
ShreelekhyaG commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-666112316 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] kevinjmh commented on pull request #3867: [CARBONDATA-3889] Cleanup code typo in carbondata-spark module

2020-07-30 Thread GitBox
kevinjmh commented on pull request #3867: URL: https://github.com/apache/carbondata/pull/3867#issuecomment-666153130 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3774: [CARBONDATA-3833] Make geoID visible

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3774: URL: https://github.com/apache/carbondata/pull/3774#issuecomment-665813658 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3867: [CARBONDATA-3889] Cleanup code typo in carbondata-spark module

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3867: URL: https://github.com/apache/carbondata/pull/3867#issuecomment-666136864 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [WIP][CARBONDATA-3916] Support array complex type with SI

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-665812800 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3773: [CARBONDATA-3830]Presto complex columns read support

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-665938820 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3873: [WIP] Repair SI Command

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-665834093 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on a change in pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-30 Thread GitBox
QiangCai commented on a change in pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#discussion_r462714824 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java ## @@ -283,8 +283,8 @@ public BigDecimal

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3874: [CARBONDATA-3931]Fix Secondary index with index column as DateType giving wrong results

2020-07-30 Thread GitBox
CarbonDataQA1 commented on pull request #3874: URL: https://github.com/apache/carbondata/pull/3874#issuecomment-665829286 This is an automated message from the Apache Git Service. To respond to the message, please log on to