[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
VenuReddy2103 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r478153107 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithDiffTimestampFormat.scala ## @@

[GitHub] [carbondata] kunal642 commented on a change in pull request #3893: [CARBONDATA-3959] Added new property to set the value of executor LRU cache size to 70% of the total executor memory in Inde

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#discussion_r477384526 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1280,6 +1280,11 @@ private

[GitHub] [carbondata] kunal642 commented on a change in pull request #3893: [CARBONDATA-3959] Added new property to set the value of executor LRU cache size to 70% of the total executor memory in Inde

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#discussion_r477382736 ## File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala ## @@ -243,11 +243,26 @@ object IndexServer

[GitHub] [carbondata] kunal642 commented on a change in pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEvent

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#discussion_r477356848 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/SILoadEventListenerForFailedSegments.scala ## @@ -57,189

[GitHub] [carbondata] kunal642 commented on a change in pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEvent

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#discussion_r475533562 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -2262,6 +2262,32 @@ private

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477352862 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/index/CarbonIndexUtil.scala ## @@ -377,4 +381,212 @@ object CarbonIndexUtil {

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477351673 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/index/CarbonIndexUtil.scala ## @@ -377,4 +381,212 @@ object CarbonIndexUtil {

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477351380 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/index/CarbonIndexUtil.scala ## @@ -377,4 +381,212 @@ object CarbonIndexUtil {

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477350602 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/index/CarbonIndexUtil.scala ## @@ -377,4 +381,212 @@ object CarbonIndexUtil {

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477348891 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/index/CarbonIndexUtil.scala ## @@ -377,4 +381,212 @@ object CarbonIndexUtil {

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477348313 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477347873 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477343487 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477343137 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [carbondata] kunal642 commented on a change in pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#discussion_r477342379 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/IndexRepairCommand.scala ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680907790 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3882/

[GitHub] [carbondata] kumarvishal09 commented on pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#issuecomment-680904506 @ajantha-bhat By default Row filter push down is false, In case of complex type for eg: array of string number of records can be much more than 32k, so filling in one

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680902015 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2141/

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477313518 ## File path: core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java ## @@ -153,6 +154,9 @@ private

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477313518 ## File path: core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java ## @@ -153,6 +154,9 @@ private

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477313220 ## File path: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java ## @@ -98,6 +98,9 @@ */

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3904: [CARBONDATA-3962]Remove unwanted empty fact directory in case of flat_folder table

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3904: URL: https://github.com/apache/carbondata/pull/3904#issuecomment-680889796 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2140/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3904: [CARBONDATA-3962]Remove unwanted empty fact directory in case of flat_folder table

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3904: URL: https://github.com/apache/carbondata/pull/3904#issuecomment-680889554 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3881/

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477308991 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java ## @@ -376,6 +456,56 @@

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477308991 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java ## @@ -376,6 +456,56 @@

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477308991 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java ## @@ -376,6 +456,56 @@

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477292131 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveCodec.java ## @@ -260,4 +265,65 @@

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477289221 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveCodec.java ## @@ -260,4 +265,65 @@

[GitHub] [carbondata] kumarvishal09 commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
kumarvishal09 commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477289221 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveCodec.java ## @@ -260,4 +265,65 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-680843631 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3880/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3875: [WIP]Presto write transactional

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3875: URL: https://github.com/apache/carbondata/pull/3875#issuecomment-680843243 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2139/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3903: [CARBONDATA-3963]Fix hive timestamp data mismatch issue and empty data during query issue

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3903: URL: https://github.com/apache/carbondata/pull/3903#issuecomment-680840597 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2138/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3903: [CARBONDATA-3963]Fix hive timestamp data mismatch issue and empty data during query issue

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3903: URL: https://github.com/apache/carbondata/pull/3903#issuecomment-680833851 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3879/

[jira] [Created] (CARBONDATA-3963) timestamp data is wrong in case of reading carbon via hive and other issue

2020-08-26 Thread Akash R Nilugal (Jira)
Akash R Nilugal created CARBONDATA-3963: --- Summary: timestamp data is wrong in case of reading carbon via hive and other issue Key: CARBONDATA-3963 URL: https://issues.apache.org/jira/browse/CARBONDATA-3963

[jira] [Created] (CARBONDATA-3962) Empty fact dirs are present in case of flat folder, which are unnecessary

2020-08-26 Thread Akash R Nilugal (Jira)
Akash R Nilugal created CARBONDATA-3962: --- Summary: Empty fact dirs are present in case of flat folder, which are unnecessary Key: CARBONDATA-3962 URL: https://issues.apache.org/jira/browse/CARBONDATA-3962

[GitHub] [carbondata] akashrn5 opened a new pull request #3904: []Remove unwanted empty fact directory in case of flat_folder table

2020-08-26 Thread GitBox
akashrn5 opened a new pull request #3904: URL: https://github.com/apache/carbondata/pull/3904 ### Why is this PR needed? In case of flat folder, we write the data files directly at table path, so fact dir is not required. Fact dir is unwanted and present as empty dir. ###

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680828750 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2137/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680827562 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3878/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3902: [WIP][CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-680807986 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3876/

[GitHub] [carbondata] asfgit closed pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
asfgit closed pull request #3899: URL: https://github.com/apache/carbondata/pull/3899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] kunal642 commented on a change in pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#discussion_r477201000 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala ## @@ -310,7

[GitHub] [carbondata] kunal642 commented on pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
kunal642 commented on pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#issuecomment-680798546 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3902: [WIP][CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-680791844 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2135/

[GitHub] [carbondata] QiangCai commented on a change in pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
QiangCai commented on a change in pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#discussion_r477191769 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala ## @@ -310,7

[GitHub] [carbondata] Indhumathi27 commented on pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
Indhumathi27 commented on pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#issuecomment-680785361 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] QiangCai commented on a change in pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
QiangCai commented on a change in pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#discussion_r477183265 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala ## @@ -310,7

[GitHub] [carbondata] akashrn5 commented on pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
akashrn5 commented on pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#issuecomment-680780532 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] kunal642 commented on a change in pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
kunal642 commented on a change in pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#discussion_r477173788 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala ## @@ -310,7

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-680773026 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2134/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-680771095 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3875/

[GitHub] [carbondata] Zhangshunyu commented on pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
Zhangshunyu commented on pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#issuecomment-680768668 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] akashrn5 opened a new pull request #3903: [wip]Fix hive timestamp data mismatch issue and empty data during query issue

2020-08-26 Thread GitBox
akashrn5 opened a new pull request #3903: URL: https://github.com/apache/carbondata/pull/3903 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680760581 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2133/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680758465 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3874/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#issuecomment-680755507 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3873/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#issuecomment-680755157 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2132/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#issuecomment-680755166 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2131/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3899: [HOTFIX] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#issuecomment-680754700 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3872/

[GitHub] [carbondata] kunal642 opened a new pull request #3902: [WIP][CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-08-26 Thread GitBox
kunal642 opened a new pull request #3902: URL: https://github.com/apache/carbondata/pull/3902 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[jira] [Created] (CARBONDATA-3961) Reorder filter according to the column storage ordinal to improve reading

2020-08-26 Thread Kunal Kapoor (Jira)
Kunal Kapoor created CARBONDATA-3961: Summary: Reorder filter according to the column storage ordinal to improve reading Key: CARBONDATA-3961 URL: https://issues.apache.org/jira/browse/CARBONDATA-3961

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3856: [CARBONDATA-3929]Improve CDC performance

2020-08-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3856: URL: https://github.com/apache/carbondata/pull/3856#discussion_r477095488 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala ## @@

[GitHub] [carbondata] ajantha-bhat commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

2020-08-26 Thread GitBox
ajantha-bhat commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-680714175 @QiangCai , @ravipesala @marchpure @akashrn5 : please check this This is an automated message from the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3856: [CARBONDATA-3929]Improve CDC performance

2020-08-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3856: URL: https://github.com/apache/carbondata/pull/3856#discussion_r477095415 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala ## @@

[GitHub] [carbondata] ajantha-bhat opened a new pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

2020-08-26 Thread GitBox
ajantha-bhat opened a new pull request #3901: URL: https://github.com/apache/carbondata/pull/3901 ### Why is this PR needed? #3764 has added nosort (this is wrong code, but no functional impact as it was not changing new segment load to no_sort) #3856 has changed it to no_sort

[GitHub] [carbondata] dependabot[bot] commented on pull request #3456: Bump solr.version from 6.3.0 to 8.3.0 in /datamap/lucene

2020-08-26 Thread GitBox
dependabot[bot] commented on pull request #3456: URL: https://github.com/apache/carbondata/pull/3456#issuecomment-680710764 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting

[GitHub] [carbondata] dependabot[bot] commented on pull request #3447: Bump dep.jackson.version from 2.6.5 to 2.10.1 in /store/sdk

2020-08-26 Thread GitBox
dependabot[bot] commented on pull request #3447: URL: https://github.com/apache/carbondata/pull/3447#issuecomment-680710899 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting

[GitHub] [carbondata] asfgit closed pull request #3856: [CARBONDATA-3929]Improve CDC performance

2020-08-26 Thread GitBox
asfgit closed pull request #3856: URL: https://github.com/apache/carbondata/pull/3856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-680702383 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2130/

[GitHub] [carbondata] QiangCai commented on pull request #3899: [WIP] Aviod cleaning segments after reading tablestatus failed

2020-08-26 Thread GitBox
QiangCai commented on pull request #3899: URL: https://github.com/apache/carbondata/pull/3899#issuecomment-680701522 @kunal642 please check this modification. This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r477080590 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -444,9 +446,38 @@ private static Object

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r477080281 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -444,9 +446,38 @@ private static Object

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-680696625 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3871/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680694024 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3870/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3900: [WIP] Test

2020-08-26 Thread GitBox
CarbonDataQA1 commented on pull request #3900: URL: https://github.com/apache/carbondata/pull/3900#issuecomment-680691609 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2129/

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
Indhumathi27 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r477061165 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -444,9 +446,38 @@ private static Object

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r477059876 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/util/BadRecordUtil.scala ## @@ -68,4 +71,32 @@ object BadRecordUtil {

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r477059942 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -444,9 +446,38 @@ private static Object

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
Indhumathi27 commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r477059846 ## File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ## @@ -444,9 +446,38 @@ private static Object

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3896: [CARBONDATA-3955] Fix load failures due to daylight saving time changes

2020-08-26 Thread GitBox
ShreelekhyaG commented on a change in pull request #3896: URL: https://github.com/apache/carbondata/pull/3896#discussion_r477059456 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/util/BadRecordUtil.scala ## @@ -68,4 +71,32 @@ object BadRecordUtil {

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3887: [CARBONDATA-3830] Support Array and Struct of all primitive type reading from presto

2020-08-26 Thread GitBox
ajantha-bhat commented on a change in pull request #3887: URL: https://github.com/apache/carbondata/pull/3887#discussion_r477058306 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java ## @@ -282,6

[GitHub] [carbondata] Indhumathi27 commented on pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-08-26 Thread GitBox
Indhumathi27 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-680679287 @QiangCai @ajantha-bhat Reverted row level position reference code changes. Please review This is an