akashrn5 commented on a change in pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#discussion_r481787443
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
##
@@ -373,6 +375,164 @@ object CarbonFilters {
akashrn5 commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481784694
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
getTa
kunal642 commented on a change in pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#discussion_r481778448
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
##
@@ -373,6 +375,146 @@ object CarbonFilters {
kunal642 commented on a change in pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#discussion_r481777679
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
##
@@ -373,6 +375,146 @@ object CarbonFilters {
[
https://issues.apache.org/jira/browse/CARBONDATA-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash R Nilugal resolved CARBONDATA-3960.
-
Fix Version/s: 2.1.0
Resolution: Fixed
> Column comment should be nul
asfgit closed pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/CARBONDATA-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash R Nilugal closed CARBONDATA-3966.
---
Resolution: Not A Problem
> NullPointerException is thrown in case of reliabilit
[
https://issues.apache.org/jira/browse/CARBONDATA-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189011#comment-17189011
]
Akash R Nilugal commented on CARBONDATA-3966:
-
this issue might not happ
akashrn5 commented on pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#issuecomment-685326743
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
QiangCai commented on a change in pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#discussion_r481766413
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##
@@ -624,9 +625,7 @@ class Tabl
akashrn5 commented on pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#issuecomment-685325305
@ajantha-bhat with recent changes, we are taking modified time from metadata
details, so for metadata details already null check is present in
getValidSegments API, so may b
akashrn5 closed pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ajantha-bhat commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481755396
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
g
kunal642 commented on a change in pull request #3893:
URL: https://github.com/apache/carbondata/pull/3893#discussion_r481745121
##
File path:
core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java
##
@@ -148,19 +148,39 @@ private void createLRULevelCacheInstanc
kunal642 commented on a change in pull request #3893:
URL: https://github.com/apache/carbondata/pull/3893#discussion_r481745121
##
File path:
core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java
##
@@ -148,19 +148,39 @@ private void createLRULevelCacheInstanc
ajantha-bhat commented on a change in pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#discussion_r481737995
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
##
@@ -373,6 +375,146 @@ object CarbonFilters {
kunal642 commented on pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685313907
@vikramahuja1001 please fix the build
This is an automated message from the Apache Git Service.
To respond t
CarbonDataQA1 commented on pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685312703
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3958/
-
CarbonDataQA1 commented on pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685312203
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2218/
Indhumathi Muthumurugesh created CARBONDATA-3969:
Summary: Fix Deserialization issue with DataType class
Key: CARBONDATA-3969
URL: https://issues.apache.org/jira/browse/CARBONDATA-3969
ajantha-bhat edited a comment on pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#issuecomment-685310097
@kunal642 : Also please add some report in the description on how much was
the performance with and without this change.
---
ajantha-bhat commented on pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#issuecomment-685310097
@kunal : Also please add some report in the description on how much was the
performance with and without this change.
--
vikramahuja1001 commented on pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685308575
Added new properties in docs as well
This is an automated message from the Apache Git Service.
To res
ajantha-bhat commented on a change in pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#discussion_r481694795
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
##
@@ -373,6 +375,146 @@ object CarbonFilters {
ajantha-bhat commented on pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#issuecomment-685305774
@kunal642 : PR is ready. please check and merge
This is an automated message from the Apache Git Service
CarbonDataQA1 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-685115973
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3957/
-
CarbonDataQA1 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-685113587
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2217/
Karan980 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-685054651
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
kunal642 commented on pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685023276
please add the new properties in docs
This is an automated message from the Apache Git Service.
To respond t
CarbonDataQA1 commented on pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#issuecomment-685022558
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2216/
CarbonDataQA1 commented on pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#issuecomment-685020692
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3956/
-
CarbonDataQA1 commented on pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#issuecomment-685018314
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2215/
CarbonDataQA1 commented on pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#issuecomment-685014264
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3955/
-
CarbonDataQA1 commented on pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#issuecomment-684994151
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3953/
-
CarbonDataQA1 commented on pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#issuecomment-684993460
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2213/
CarbonDataQA1 commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684965465
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2212/
CarbonDataQA1 commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684963426
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3952/
-
akashrn5 commented on pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#issuecomment-684943246
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
CarbonDataQA1 commented on pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#issuecomment-684938297
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3954/
-
akashrn5 commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481226211
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
getTa
akashrn5 commented on pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684935390
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
akashrn5 commented on pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#issuecomment-684934937
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
akashrn5 commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481226211
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
getTa
akashrn5 commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481226211
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
getTa
ajantha-bhat commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481221931
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
g
ajantha-bhat commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481221931
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
g
akashrn5 commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481198186
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
getTa
ajantha-bhat commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r481197993
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##
@@ -684,21 +7
ajantha-bhat commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r481146873
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##
@@ -824,6 +90
CarbonDataQA1 commented on pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#issuecomment-684902776
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2210/
CarbonDataQA1 commented on pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#issuecomment-684900945
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3950/
-
CarbonDataQA1 commented on pull request #3910:
URL: https://github.com/apache/carbondata/pull/3910#issuecomment-684896877
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3949/
-
CarbonDataQA1 commented on pull request #3910:
URL: https://github.com/apache/carbondata/pull/3910#issuecomment-684895757
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2209/
ajantha-bhat commented on a change in pull request #3907:
URL: https://github.com/apache/carbondata/pull/3907#discussion_r481175661
##
File path:
core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java
##
@@ -515,15 +516,16 @@ public TableSegmentRefresher
g
kunal642 commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r481170533
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##
@@ -684,21 +730,7
kunal642 commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r481168720
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##
@@ -824,6 +926,42
CarbonDataQA1 commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684847720
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3948/
-
CarbonDataQA1 commented on pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684845760
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3947/
-
CarbonDataQA1 commented on pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684838466
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2207/
vikramahuja1001 commented on a change in pull request #3894:
URL: https://github.com/apache/carbondata/pull/3894#discussion_r481107503
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/SILoadEventListenerForFailedSegments.scala
##
@@ -57
Indhumathi27 opened a new pull request #3910:
URL: https://github.com/apache/carbondata/pull/3910
### Why is this PR needed?
When DataType(For eg, StringType) object is serialized and deserialized
using Gson, DataType object after deserialization, gets changed to Main class
(DataType)
CarbonDataQA1 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-684811094
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3945/
-
CarbonDataQA1 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-684810505
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2205/
[
https://issues.apache.org/jira/browse/CARBONDATA-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kunal Kapoor resolved CARBONDATA-3956.
--
Fix Version/s: 2.1.0
Resolution: Fixed
> Implementing a new Reindex command
asfgit closed pull request #3873:
URL: https://github.com/apache/carbondata/pull/3873
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
akashrn5 commented on pull request #3873:
URL: https://github.com/apache/carbondata/pull/3873#issuecomment-684785341
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
kunal642 commented on pull request #3873:
URL: https://github.com/apache/carbondata/pull/3873#issuecomment-684781373
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
CarbonDataQA1 commented on pull request #3893:
URL: https://github.com/apache/carbondata/pull/3893#issuecomment-684774434
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2204/
akashrn5 commented on pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684773205
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
CarbonDataQA1 commented on pull request #3893:
URL: https://github.com/apache/carbondata/pull/3893#issuecomment-684773131
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3944/
-
Indhumathi27 commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684738151
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
CarbonDataQA1 commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684734917
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2202/
Karan980 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-684736007
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
CarbonDataQA1 commented on pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684727237
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3942/
-
ajantha-bhat commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r481024238
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##
@@ -824,6 +90
ajantha-bhat commented on a change in pull request #3861:
URL: https://github.com/apache/carbondata/pull/3861#discussion_r481013721
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala
##
@@ -824,6 +90
asfgit closed pull request #3901:
URL: https://github.com/apache/carbondata/pull/3901
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
QiangCai commented on pull request #3901:
URL: https://github.com/apache/carbondata/pull/3901#issuecomment-684628244
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
VenuReddy2103 commented on pull request #3819:
URL: https://github.com/apache/carbondata/pull/3819#issuecomment-684567252
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Indhumathi27 commented on a change in pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#discussion_r480961113
##
File path:
integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java
##
@@ -243,46 +25
QiangCai commented on a change in pull request #3902:
URL: https://github.com/apache/carbondata/pull/3902#discussion_r480958551
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
##
@@ -373,6 +375,146 @@ object CarbonFilters {
Indhumathi27 commented on a change in pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#discussion_r480960162
##
File path:
integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java
##
@@ -243,46 +25
CarbonDataQA1 commented on pull request #3819:
URL: https://github.com/apache/carbondata/pull/3819#issuecomment-684545809
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3941/
-
CarbonDataQA1 commented on pull request #3819:
URL: https://github.com/apache/carbondata/pull/3819#issuecomment-684545249
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2201/
kunal642 commented on a change in pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#discussion_r480922354
##
File path:
integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java
##
@@ -243,46 +258,11
kunal642 commented on a change in pull request #3778:
URL: https://github.com/apache/carbondata/pull/3778#discussion_r480920128
##
File path:
integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java
##
@@ -243,46 +258,11
CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-684508598
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3940/
-
CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-684508344
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2200/
akashrn5 commented on a change in pull request #3898:
URL: https://github.com/apache/carbondata/pull/3898#discussion_r480909454
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##
@@ -624,9 +625,7 @@ class Tabl
89 matches
Mail list logo