[GitHub] [carbondata] akashrn5 commented on a change in pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
akashrn5 commented on a change in pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#discussion_r481787443 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala ## @@ -373,6 +375,164 @@ object CarbonFilters {

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481784694 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher getTa

[GitHub] [carbondata] kunal642 commented on a change in pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#discussion_r481778448 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala ## @@ -373,6 +375,146 @@ object CarbonFilters {

[GitHub] [carbondata] kunal642 commented on a change in pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#discussion_r481777679 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala ## @@ -373,6 +375,146 @@ object CarbonFilters {

[jira] [Resolved] (CARBONDATA-3960) Column comment should be null by default when adding column

2020-09-01 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-3960. - Fix Version/s: 2.1.0 Resolution: Fixed > Column comment should be nul

[GitHub] [carbondata] asfgit closed pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
asfgit closed pull request #3898: URL: https://github.com/apache/carbondata/pull/3898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Closed] (CARBONDATA-3966) NullPointerException is thrown in case of reliability testing of load, compaction and query

2020-09-01 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal closed CARBONDATA-3966. --- Resolution: Not A Problem > NullPointerException is thrown in case of reliabilit

[jira] [Commented] (CARBONDATA-3966) NullPointerException is thrown in case of reliability testing of load, compaction and query

2020-09-01 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189011#comment-17189011 ] Akash R Nilugal commented on CARBONDATA-3966: - this issue might not happ

[GitHub] [carbondata] akashrn5 commented on pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
akashrn5 commented on pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#issuecomment-685326743 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] QiangCai commented on a change in pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
QiangCai commented on a change in pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#discussion_r481766413 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ## @@ -624,9 +625,7 @@ class Tabl

[GitHub] [carbondata] akashrn5 commented on pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#issuecomment-685325305 @ajantha-bhat with recent changes, we are taking modified time from metadata details, so for metadata details already null check is present in getValidSegments API, so may b

[GitHub] [carbondata] akashrn5 closed pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 closed pull request #3907: URL: https://github.com/apache/carbondata/pull/3907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481755396 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher g

[GitHub] [carbondata] kunal642 commented on a change in pull request #3893: [CARBONDATA-3959] Added new property to set the value of executor LRU cache size to 70% of the total executor memory in Inde

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#discussion_r481745121 ## File path: core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ## @@ -148,19 +148,39 @@ private void createLRULevelCacheInstanc

[GitHub] [carbondata] kunal642 commented on a change in pull request #3893: [CARBONDATA-3959] Added new property to set the value of executor LRU cache size to 70% of the total executor memory in Inde

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#discussion_r481745121 ## File path: core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ## @@ -148,19 +148,39 @@ private void createLRULevelCacheInstanc

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#discussion_r481737995 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala ## @@ -373,6 +375,146 @@ object CarbonFilters {

[GitHub] [carbondata] kunal642 commented on pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEventListenerForF

2020-09-01 Thread GitBox
kunal642 commented on pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685313907 @vikramahuja1001 please fix the build This is an automated message from the Apache Git Service. To respond t

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEventListene

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685312703 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3958/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEventListene

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685312203 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2218/

[jira] [Created] (CARBONDATA-3969) Fix Deserialization issue with DataType class

2020-09-01 Thread Indhumathi Muthumurugesh (Jira)
Indhumathi Muthumurugesh created CARBONDATA-3969: Summary: Fix Deserialization issue with DataType class Key: CARBONDATA-3969 URL: https://issues.apache.org/jira/browse/CARBONDATA-3969

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
ajantha-bhat edited a comment on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-685310097 @kunal642 : Also please add some report in the description on how much was the performance with and without this change. ---

[GitHub] [carbondata] ajantha-bhat commented on pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
ajantha-bhat commented on pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#issuecomment-685310097 @kunal : Also please add some report in the description on how much was the performance with and without this change. --

[GitHub] [carbondata] vikramahuja1001 commented on pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEventListe

2020-09-01 Thread GitBox
vikramahuja1001 commented on pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685308575 Added new properties in docs as well This is an automated message from the Apache Git Service. To res

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#discussion_r481694795 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala ## @@ -373,6 +375,146 @@ object CarbonFilters {

[GitHub] [carbondata] ajantha-bhat commented on pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
ajantha-bhat commented on pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#issuecomment-685305774 @kunal642 : PR is ready. please check and merge This is an automated message from the Apache Git Service

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-685115973 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3957/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-685113587 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2217/

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-09-01 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-685054651 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] kunal642 commented on pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEventListenerForF

2020-09-01 Thread GitBox
kunal642 commented on pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#issuecomment-685023276 please add the new properties in docs This is an automated message from the Apache Git Service. To respond t

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#issuecomment-685022558 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2216/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#issuecomment-685020692 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3956/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#issuecomment-685018314 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2215/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#issuecomment-685014264 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3955/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#issuecomment-684994151 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3953/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#issuecomment-684993460 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2213/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684965465 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2212/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684963426 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3952/ -

[GitHub] [carbondata] akashrn5 commented on pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#issuecomment-684943246 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#issuecomment-684938297 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3954/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481226211 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher getTa

[GitHub] [carbondata] akashrn5 commented on pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
akashrn5 commented on pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684935390 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] akashrn5 commented on pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#issuecomment-684934937 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481226211 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher getTa

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481226211 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher getTa

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481221931 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher g

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481221931 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher g

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
akashrn5 commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481198186 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher getTa

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#discussion_r481197993 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala ## @@ -684,21 +7

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#discussion_r481146873 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala ## @@ -824,6 +90

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEventListene

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#issuecomment-684902776 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2210/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILoadEventListene

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#issuecomment-684900945 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3950/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3910: [WIP] Fix Deserialization issue with DataType class

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3910: URL: https://github.com/apache/carbondata/pull/3910#issuecomment-684896877 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3949/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3910: [WIP] Fix Deserialization issue with DataType class

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3910: URL: https://github.com/apache/carbondata/pull/3910#issuecomment-684895757 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2209/

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3907: [CARBONDATA-3966]Fix NullPointerException issue in case of reliability testing of load and compaction

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3907: URL: https://github.com/apache/carbondata/pull/3907#discussion_r481175661 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexStoreManager.java ## @@ -515,15 +516,16 @@ public TableSegmentRefresher g

[GitHub] [carbondata] kunal642 commented on a change in pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#discussion_r481170533 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala ## @@ -684,21 +730,7

[GitHub] [carbondata] kunal642 commented on a change in pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#discussion_r481168720 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala ## @@ -824,6 +926,42

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684847720 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3948/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684845760 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3947/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684838466 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2207/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3894: [CARBONDATA-3957] Added property to enable disable the repair logic and provide a limit to number of segments in SILo

2020-09-01 Thread GitBox
vikramahuja1001 commented on a change in pull request #3894: URL: https://github.com/apache/carbondata/pull/3894#discussion_r481107503 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/SILoadEventListenerForFailedSegments.scala ## @@ -57

[GitHub] [carbondata] Indhumathi27 opened a new pull request #3910: [WIP] Fix Deserialization issue with DataType class

2020-09-01 Thread GitBox
Indhumathi27 opened a new pull request #3910: URL: https://github.com/apache/carbondata/pull/3910 ### Why is this PR needed? When DataType(For eg, StringType) object is serialized and deserialized using Gson, DataType object after deserialization, gets changed to Main class (DataType)

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-684811094 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3945/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3876: TestingCI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-684810505 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2205/

[jira] [Resolved] (CARBONDATA-3956) Implementing a new Reindex command to repair the missing SI Segments

2020-09-01 Thread Kunal Kapoor (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-3956. -- Fix Version/s: 2.1.0 Resolution: Fixed > Implementing a new Reindex command

[GitHub] [carbondata] asfgit closed pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-09-01 Thread GitBox
asfgit closed pull request #3873: URL: https://github.com/apache/carbondata/pull/3873 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] akashrn5 commented on pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-09-01 Thread GitBox
akashrn5 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-684785341 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] kunal642 commented on pull request #3873: [CARBONDATA-3956] Reindex command on SI table

2020-09-01 Thread GitBox
kunal642 commented on pull request #3873: URL: https://github.com/apache/carbondata/pull/3873#issuecomment-684781373 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3893: [CARBONDATA-3959] Added new property to set the value of executor LRU cache size to 70% of the total executor memory in IndexServer

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#issuecomment-684774434 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2204/

[GitHub] [carbondata] akashrn5 commented on pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
akashrn5 commented on pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#issuecomment-684773205 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3893: [CARBONDATA-3959] Added new property to set the value of executor LRU cache size to 70% of the total executor memory in IndexServer

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3893: URL: https://github.com/apache/carbondata/pull/3893#issuecomment-684773131 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3944/ -

[GitHub] [carbondata] Indhumathi27 commented on pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
Indhumathi27 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684738151 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684734917 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2202/

[GitHub] [carbondata] Karan980 commented on pull request #3876: TestingCI

2020-09-01 Thread GitBox
Karan980 commented on pull request #3876: URL: https://github.com/apache/carbondata/pull/3876#issuecomment-684736007 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#issuecomment-684727237 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3942/ -

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#discussion_r481024238 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala ## @@ -824,6 +90

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3861: [CARBONDATA-3922] Support order by limit push down for secondary index queries

2020-09-01 Thread GitBox
ajantha-bhat commented on a change in pull request #3861: URL: https://github.com/apache/carbondata/pull/3861#discussion_r481013721 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/optimizer/CarbonSecondaryIndexOptimizer.scala ## @@ -824,6 +90

[GitHub] [carbondata] asfgit closed pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

2020-09-01 Thread GitBox
asfgit closed pull request #3901: URL: https://github.com/apache/carbondata/pull/3901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] QiangCai commented on pull request #3901: [CARBONDATA-3820] CDC update as new segment should use target table sort_scope

2020-09-01 Thread GitBox
QiangCai commented on pull request #3901: URL: https://github.com/apache/carbondata/pull/3901#issuecomment-684628244 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] VenuReddy2103 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-09-01 Thread GitBox
VenuReddy2103 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-684567252 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#discussion_r480961113 ## File path: integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java ## @@ -243,46 +25

[GitHub] [carbondata] QiangCai commented on a change in pull request #3902: [CARBONDATA-3961] reorder filter expression based on storage ordinal

2020-09-01 Thread GitBox
QiangCai commented on a change in pull request #3902: URL: https://github.com/apache/carbondata/pull/3902#discussion_r480958551 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala ## @@ -373,6 +375,146 @@ object CarbonFilters {

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#discussion_r480960162 ## File path: integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java ## @@ -243,46 +25

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-684545809 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3941/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-684545249 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2201/

[GitHub] [carbondata] kunal642 commented on a change in pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#discussion_r480922354 ## File path: integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java ## @@ -243,46 +258,11

[GitHub] [carbondata] kunal642 commented on a change in pull request #3778: [CARBONDATA-3916] Support array complex type with SI

2020-09-01 Thread GitBox
kunal642 commented on a change in pull request #3778: URL: https://github.com/apache/carbondata/pull/3778#discussion_r480920128 ## File path: integration/spark/src/main/java/org/apache/spark/sql/secondaryindex/query/SecondaryIndexQueryResultProcessor.java ## @@ -243,46 +258,11

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-684508598 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3940/ -

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-09-01 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-684508344 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2200/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3898: [CARBONDATA-3960] Default comment should be null when adding columns

2020-09-01 Thread GitBox
akashrn5 commented on a change in pull request #3898: URL: https://github.com/apache/carbondata/pull/3898#discussion_r480909454 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ## @@ -624,9 +625,7 @@ class Tabl