[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-01 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533962334 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed to

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-01 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533961464 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonListExpression.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-01 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533960629 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonListExpression.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-01 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533960531 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoOperationType.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-12-01 Thread GitBox
shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533959413 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoHashUtils.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [carbondata] ajantha-bhat opened a new pull request #4034: [WIP] support prestosql 333

2020-12-01 Thread GitBox
ajantha-bhat opened a new pull request #4034: URL: https://github.com/apache/carbondata/pull/4034 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737051141 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3257/

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-01 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r533948673 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/MajorCompactionIgnoreInMinorTest.scala ## @@ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737047075 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5013/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r533944878 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/MajorCompactionIgnoreInMinorTest.scala ## @@ -186

[GitHub] [carbondata] nihal0107 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-12-01 Thread GitBox
nihal0107 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-737030967 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-737029820 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5010/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4023: [CARBONDATA-4059] added testcase for custom compaction, compression and range column for SI table

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4023: URL: https://github.com/apache/carbondata/pull/4023#issuecomment-737029308 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3256/

[jira] [Resolved] (CARBONDATA-4052) Select query on SI table after insert overwrite is giving wrong result.

2020-12-01 Thread Akash R Nilugal (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash R Nilugal resolved CARBONDATA-4052. - Fix Version/s: 2.2.0 Resolution: Fixed > Select query on SI table aft

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4023: [CARBONDATA-4059] added testcase for custom compaction, compression and range column for SI table

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4023: URL: https://github.com/apache/carbondata/pull/4023#issuecomment-737028313 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5012/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-737027155 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3255/

[GitHub] [carbondata] asfgit closed pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
asfgit closed pull request #4015: URL: https://github.com/apache/carbondata/pull/4015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#issuecomment-737021905 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3253/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#issuecomment-737021680 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5008/ -

[GitHub] [carbondata] akashrn5 commented on pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
akashrn5 commented on pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#issuecomment-737001258 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] vikramahuja1001 closed pull request #4007: [WIP]: Clean files behaviour change

2020-12-01 Thread GitBox
vikramahuja1001 closed pull request #4007: URL: https://github.com/apache/carbondata/pull/4007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [carbondata] nihal0107 commented on pull request #4027: [WIP]added compression and range column based FT for SI

2020-12-01 Thread GitBox
nihal0107 commented on pull request #4027: URL: https://github.com/apache/carbondata/pull/4027#issuecomment-736993272 Added in #4023 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [carbondata] nihal0107 closed pull request #4027: [WIP]added compression and range column based FT for SI

2020-12-01 Thread GitBox
nihal0107 closed pull request #4027: URL: https://github.com/apache/carbondata/pull/4027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [carbondata] Indhumathi27 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-12-01 Thread GitBox
Indhumathi27 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-736988368 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
nihal0107 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533892078 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -398,6 +404,22 @@ object Se

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736961603 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3252/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736961311 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5007/ -

[GitHub] [carbondata] asfgit closed pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
asfgit closed pull request #4005: URL: https://github.com/apache/carbondata/pull/4005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] Zhangshunyu commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-01 Thread GitBox
Zhangshunyu commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736928238 @akashrn5 handled This is an automated message from the Apache Git Service. To respond to the message, pl

Inbox (2) | New Cloud Notification

2020-12-01 Thread Cloud-carbondata . apache . org
Dear User2 New documents assigned to 'issues@carbondata.apache.org ' are available on carbondata.apache.org Cloudclick here to retrieve document(s) now Powered by carbondata.apache.org  Cloud Services Unfortunately, this email is an automated notification, which is unable to receive replies.

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-736810208 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5006/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #3988: [CARBONDATA-4037] Improve the table status and segment file writing

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #3988: URL: https://github.com/apache/carbondata/pull/3988#issuecomment-736807198 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3251/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736790887 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3250/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736789397 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5005/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736788185 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3249/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736787550 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5004/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#issuecomment-736748233 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3248/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4025: [WIP] Make TableStatus/UpdateTableStatus/SegmentFile Smaller

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4025: URL: https://github.com/apache/carbondata/pull/4025#issuecomment-736747782 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3247/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#issuecomment-736744974 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5003/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4025: [WIP] Make TableStatus/UpdateTableStatus/SegmentFile Smaller

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4025: URL: https://github.com/apache/carbondata/pull/4025#issuecomment-736744592 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5002/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-736742888 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3245/

[GitHub] [carbondata] akashrn5 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736739075 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533628020 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Softw

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4004: [WIP] update actomity

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#issuecomment-736734171 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3246/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-736733971 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5000/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4007: [WIP]: Clean files behaviour change

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4007: URL: https://github.com/apache/carbondata/pull/4007#issuecomment-736733142 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3244/

[GitHub] [carbondata] akashrn5 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
akashrn5 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736731895 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4007: [WIP]: Clean files behaviour change

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4007: URL: https://github.com/apache/carbondata/pull/4007#issuecomment-736731831 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4999/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4004: [WIP] update actomity

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#issuecomment-736730411 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5001/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533614590 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -398,6 +404,22 @@ object Sec

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r533604921 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -998,6 +998,34 @@ public long getMajorCompactionSize() {

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533611032 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533599288 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533599288 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533599088 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533598665 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736708005 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3243/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533596340 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533596098 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533595909 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736705103 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4998/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533593984 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533593984 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: Presto UT optimization

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-736696049 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3242/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: Presto UT optimization

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-736695799 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4997/ -

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
nihal0107 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533571838 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -398,6 +404,28 @@ object Se

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
nihal0107 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533571712 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -398,6 +404,28 @@ object Se

[GitHub] [carbondata] marchpure commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-12-01 Thread GitBox
marchpure commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-736672478 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [carbondata] ajantha-bhat commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
ajantha-bhat commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736668554 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] QiangCai commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
QiangCai commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736650399 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Resolved] (CARBONDATA-4064) TPCDS queries are failing with NOne.get exception when table has SI configured

2020-12-01 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-4064. -- Fix Version/s: 2.2.0 Resolution: Fixed > TPCDS queries are failing with NOn

[GitHub] [carbondata] asfgit closed pull request #4030: [CARBONDATA-4064] Fix tpcds query failure with SI

2020-12-01 Thread GitBox
asfgit closed pull request #4030: URL: https://github.com/apache/carbondata/pull/4030 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Resolved] (CARBONDATA-4066) data mismatch observed with SI and without SI when SI global sort and SI segment merge is true

2020-12-01 Thread Ajantha Bhat (Jira)
[ https://issues.apache.org/jira/browse/CARBONDATA-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-4066. -- Fix Version/s: 2.2.0 Resolution: Fixed > data mismatch observed with SI and

[GitHub] [carbondata] asfgit closed pull request #4033: [CARBONDATA-4066] data mismatch observed with SI and without SI when SI global sort and SI segment merge is true

2020-12-01 Thread GitBox
asfgit closed pull request #4033: URL: https://github.com/apache/carbondata/pull/4033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] ajantha-bhat commented on pull request #4033: [CARBONDATA-4066] data mismatch observed with SI and without SI when SI global sort and SI segment merge is true

2020-12-01 Thread GitBox
ajantha-bhat commented on pull request #4033: URL: https://github.com/apache/carbondata/pull/4033#issuecomment-736644576 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736640874 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3240/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736639647 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4995/ -

[GitHub] [carbondata] akashrn5 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
akashrn5 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736634922 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533511617 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -398,6 +404,28 @@ object Sec

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
akashrn5 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533508633 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -398,6 +404,28 @@ object Sec

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736622862 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4996/ -

[GitHub] [carbondata] akashrn5 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data

2020-12-01 Thread GitBox
akashrn5 commented on pull request #4018: URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736621452 @kunal642 handled for CTAS and added test cases, please review and merge This is an automated message from t

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#issuecomment-736618751 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4993/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4013: [CARBONDATA-4062] Make clean files feature become data trash manager

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#issuecomment-736618531 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3239/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4013: [CARBONDATA-4062] Make clean files feature become data trash manager

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#issuecomment-736618069 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4994/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#issuecomment-736617364 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3238/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736570532 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3236/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736569211 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4991/ -

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
nihal0107 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533409267 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -385,7 +392,26 @@ object Se

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
nihal0107 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533409156 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -385,7 +392,26 @@ object Se

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
nihal0107 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533408885 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/rdd/SecondaryIndexCreator.scala ## @@ -371,11 +377,12 @@ object S

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-12-01 Thread GitBox
nihal0107 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r533408559 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/index/CarbonIndexUtil.scala ## @@ -299,6 +300,13 @@ object CarbonIndexUtil {

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4033: [CARBONDATA-4066] data mismatch observed with SI and without SI when SI global sort and SI segment merge is true

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4033: URL: https://github.com/apache/carbondata/pull/4033#issuecomment-736539558 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3235/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4033: [CARBONDATA-4066] data mismatch observed with SI and without SI when SI global sort and SI segment merge is true

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4033: URL: https://github.com/apache/carbondata/pull/4033#issuecomment-736539051 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4990/ -

[GitHub] [carbondata] QiangCai commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533390359 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [carbondata] QiangCai commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533390359 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736507588 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3234/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-12-01 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736502949 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4989/ -

[GitHub] [carbondata] Pickupolddriver commented on pull request #4032: [CARBONDATA-4065] Support MERGE INTO SQL Command

2020-12-01 Thread GitBox
Pickupolddriver commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-736463924 > @Pickupolddriver : PR shows 37KLOC code, please rebase and keep only required changes. I saw some codegen file of 24KLOC Yes, lots of codes are auto-generated

[GitHub] [carbondata] maheshrajus opened a new pull request #4033: [CARBONDATA-4066] data mismatch observed with SI and without SI when SI global sort and SI segment merge is true

2020-12-01 Thread GitBox
maheshrajus opened a new pull request #4033: URL: https://github.com/apache/carbondata/pull/4033 ### Why is this PR needed? data mismatch observed with SI and without SI when SI global sort and SI segment merge is true. After merge si data files position reference is also sorted a

  1   2   >