Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
@KanakaKumar @jackylk @QiangCai @ajantha-bhat @kunal642 Rebased, Please
review it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2919
Rebased and CI passï¼@KanakaKumar @jackylk @QiangCai @ajantha-bhat
@kunal642 Please review it.
---
xubo245 created CARBONDATA-3144:
---
Summary: CarbonData support spark-2.4.0
Key: CARBONDATA-3144
URL: https://issues.apache.org/jira/browse/CARBONDATA-3144
Project: CarbonData
Issue Type: New
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2919
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2940
CI passï¼ please review it. @jackylk @manishgupta88 @kunal642
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
@jackylk @ravipesala @kunal642 @KanakaKumar @chenliang613 @sraghunandan CI
pass, please review.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@jackylk @chenliang613 CI pass, please handle it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2930
@KanakaKumar @jackylk @QiangCai @ajantha-bhat @kunal642 Please review it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@kunal642 @jackylk Please review it.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238188148
--- Diff: integration/spark2/pom.xml ---
@@ -105,6 +105,11 @@
+
+ org.apache.httpcomponents
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238166894
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2940#discussion_r238156400
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2931
@KanakaKumar @jackylk @QiangCai @ajantha-bhat @kunal642 Rebased, Please
review it.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238154723
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2969
LGTM
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2940
@jackylk @ravipesala @KanakaKumar @kunal642 This is a bug, please review
it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2946
@KanakaKumar @ravipesala @jackylk @kunal642 @ajantha-bhat CI pass, Please
review it.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238085518
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerde.java
---
@@ -1,133 +1,133 @@
-///*
-// * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238085516
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerde.java
---
@@ -1,133 +1,133 @@
-///*
-// * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238085487
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerde.java
---
@@ -1,133 +1,133 @@
-///*
-// * Licensed
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
@xuchuanyin I rebased about 5 hours ago. already rebase the latest master
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
@jackylk @ravipesala @kunal642 @KanakaKumar @chenliang613 @sraghunandan CI
pass, please review.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2961#discussion_r237782459
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -180,7 +183,7 @@ object CarbonSession {
val
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2915
@sraghunandan @KanakaKumar @kunal642 CI pass, please check it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2482#discussion_r237740112
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2482#discussion_r237740134
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2482#discussion_r237740164
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2482#discussion_r237739793
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CarbonIndexFileMergeTestCase.scala
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2954
LGTM
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r237726325
--- Diff:
core/src/test/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFileTest.java
---
@@ -108,12 +121,12 @@ public void
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r237722288
--- Diff:
integration/hive/src/test/scala/org/apache/carbondata/hiveexampleCI/RunHiveExample.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2961#discussion_r237722035
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -248,7 +248,7 @@ object CarbonSession
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2961#discussion_r237722028
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -180,7 +180,7 @@ object CarbonSession {
val
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2915
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2961#discussion_r237345420
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -248,7 +248,7 @@ object CarbonSession
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2961#discussion_r237334369
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -248,7 +248,7 @@ object CarbonSession
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2961
Please optimize the title, for example: [CARBONDATA-3119]Fix the error of
getOrCreateCarbonSession method parameter is an empty string
Please optimize the PR content, keep the checklist
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2915#discussion_r237331893
--- Diff: docs/sdk-guide.md ---
@@ -709,37 +749,7 @@ Find example code at
[CarbonReaderExample](https://github.com/apache/carbondata/
public
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2915#discussion_r237330717
--- Diff: docs/sdk-guide.md ---
@@ -478,6 +489,16 @@ public CarbonWriter build() throws IOException,
InvalidLoadOptionException
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039743
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -80,32 +81,32 @@ class CarbonSession(@transient val sc
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039754
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -80,32 +81,32 @@ class CarbonSession(@transient val sc
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039728
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -114,8 +115,8 @@ class CarbonSession(@transient val sc
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039659
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -171,7 +173,7 @@ object CarbonSession
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039594
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -269,9 +271,9 @@ object CarbonSession {
session
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039483
--- Diff: pom.xml ---
@@ -496,7 +496,7 @@
integration/spark2
integration/hive
-integration/presto
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039377
--- Diff: pom.xml ---
@@ -614,7 +614,7 @@
integration/spark2
integration/hive
-integration/presto
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039395
--- Diff: pom.xml ---
@@ -556,7 +556,7 @@
integration/spark2
integration/hive
-integration/presto
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039520
--- Diff: pom.xml ---
@@ -463,7 +463,7 @@
integration/spark2
examples/spark2
integration/hive
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039260
--- Diff: integration/presto/Presto_Cluster_Setup_For_Carbondata.md ---
@@ -1,135 +0,0 @@
-# Presto Multinode Cluster setup For Carbondata
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2959#discussion_r237039136
--- Diff: format/pom.xml ---
@@ -15,58 +15,59 @@
See the License for the specific language governing permissions and
limitations under
[
https://issues.apache.org/jira/browse/CARBONDATA-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701717#comment-16701717
]
xubo245 commented on CARBONDATA-3119:
-
Please use English in carbondata-error.doc because
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2959
Please optimize the title: [CARBONDATA-3119]Fix the error of
getOrCreateCarbonSession method parameter is an empty string
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2955
LGTM
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2954
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2954
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236695520
--- Diff: pom.xml ---
@@ -200,12 +199,29 @@
+
--- End diff --
Please add scope
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2954
add to whitelist
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2954
Please optimize the title, likeï¼ Fix the HiveExample exception
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2954
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236623474
--- Diff:
integration/hive/src/test/scala/org/apache/carbondata/hiveexampleCI/RunHiveExample.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236622117
--- Diff:
integration/hive/src/test/scala/org/apache/carbondata/hiveexampleCI/RunHiveExample.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236622183
--- Diff:
integration/hive/src/test/scala/org/apache/carbondata/hiveexampleCI/RunHiveExample.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2955
Please optimize the title: Update build document
---
xubo245 created CARBONDATA-3135:
---
Summary: Remove sub-module profile， which can avoid multiple
version jar
Key: CARBONDATA-3135
URL: https://issues.apache.org/jira/browse/CARBONDATA-3135
Project
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2955#discussion_r236563581
--- Diff: build/README.md ---
@@ -29,10 +29,40 @@ Build with different supported versions of Spark, by
default using Spark 2.2.1 t
```
mvn
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2955#discussion_r236563388
--- Diff: build/README.md ---
@@ -29,10 +29,40 @@ Build with different supported versions of Spark, by
default using Spark 2.2.1 t
```
mvn
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236555834
--- Diff: pom.xml ---
@@ -100,7 +100,6 @@
processing
hadoop
integration/spark-common
-integration/spark-datasource
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236547455
--- Diff: pom.xml ---
@@ -545,16 +557,14 @@
spark-2.2
-
--- End diff --
It seems don't support
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2954
Can you add HiveExample to CI test? please refer
examples/spark2/src/test/scala/org/apache/carbondata/examplesCI/RunExamples.scala
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236545789
--- Diff: pom.xml ---
@@ -100,7 +100,6 @@
processing
hadoop
integration/spark-common
-integration/spark-datasource
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236544211
--- Diff: pom.xml ---
@@ -545,16 +557,14 @@
spark-2.2
-
--- End diff --
If user haven't selected
[
https://issues.apache.org/jira/browse/CARBONDATA-3123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1669#comment-1669
]
xubo245 commented on CARBONDATA-3123:
-
I can't reproduce the issue with the code, how
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2945#discussion_r236539095
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -66,9 +63,6 @@
this.readers = readers
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2945#discussion_r236538137
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -66,9 +63,6 @@
this.readers = readers
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2945#discussion_r236182445
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -66,9 +63,6 @@
this.readers = readers
[
https://issues.apache.org/jira/browse/CARBONDATA-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3128:
Description:
HiveExample has some exception:
org.apache.carbondata.hiveexample.HiveExample
[
https://issues.apache.org/jira/browse/CARBONDATA-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3128:
Description:
HiveExample has some exception:
org.apache.carbondata.hiveexample.HiveExample
[
https://issues.apache.org/jira/browse/CARBONDATA-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3128:
Description:
HiveExample has some exception:
org.apache.carbondata.hiveexample.HiveExample
[
https://issues.apache.org/jira/browse/CARBONDATA-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698375#comment-16698375
]
xubo245 commented on CARBONDATA-3126:
-
Yes, you can correct all spell error in CarbonData
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2946
@KanakaKumar @ravipesala @jackylk @kunal642 @ajantha-bhat CI pass, Please
review it.
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697739#comment-16697739
]
xubo245 commented on CARBONDATA-3125:
-
1. Update the document to add spark 2.3.2 :
https
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
xubo245 created CARBONDATA-3129:
---
Summary: Finish the TODO work
Key: CARBONDATA-3129
URL: https://issues.apache.org/jira/browse/CARBONDATA-3129
Project: CarbonData
Issue Type: Bug
Affects
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3127:
Description:
Hive module test case has been commented off，can' t run:
/Users/xubo/Desktop
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
[
https://issues.apache.org/jira/browse/CARBONDATA-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3125:
Description:
Find minor bug or raise some small requirements/features, and then implement
xubo245 created CARBONDATA-3128:
---
Summary: HiveExample has some exception
Key: CARBONDATA-3128
URL: https://issues.apache.org/jira/browse/CARBONDATA-3128
Project: CarbonData
Issue Type: Bug
401 - 500 of 2151 matches
Mail list logo
