xubo245 created CARBONDATA-3094:
---
Summary: Support concurrent read carbondata for CSDK
Key: CARBONDATA-3094
URL: https://issues.apache.org/jira/browse/CARBONDATA-3094
Project: CarbonData
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@jackylk @chenliang613 CI pass, please handle it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
@KanakaKumar CI pass, please review it.
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3092:
Description:
optimize configure carbon properties.
1. Add annotation for it
2. Provide
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2914#discussion_r232632794
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1237,10 +1238,12 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2914#discussion_r232632711
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1237,10 +1238,12 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2914#discussion_r232632618
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1237,10 +1238,12 @@ private CarbonCommonConstants
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2914
[WIP][CARBONDATA-3093] Provide property builder for carbon properties.
[CARBONDATA-3093] Provide property builder for carbon properties.
Optimize the String implementation, we can provide
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
retest this please
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3092:
Description:
optimize configure carbon properties.
1. Add annotation for it
2. Provide
[
https://issues.apache.org/jira/browse/CARBONDATA-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3038:
Summary: Add annotation for carbon properties and mark whether is dynamic
configuration
[
https://issues.apache.org/jira/browse/CARBONDATA-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3093:
Summary: Provide property builder for carbon properties. (was: Refactor
dynamic
xubo245 created CARBONDATA-3093:
---
Summary: Refactor dynamic configuration
Key: CARBONDATA-3093
URL: https://issues.apache.org/jira/browse/CARBONDATA-3093
Project: CarbonData
Issue Type
[
https://issues.apache.org/jira/browse/CARBONDATA-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3093:
Issue Type: Sub-task (was: Improvement)
Parent: CARBONDATA-3092
> Refactor dyna
[
https://issues.apache.org/jira/browse/CARBONDATA-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3038:
Description:
Refactor dynamic configuration for carbon:
1. Decide and collect all dynamic
[
https://issues.apache.org/jira/browse/CARBONDATA-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3038:
Issue Type: Sub-task (was: Improvement)
Parent: CARBONDATA-3092
> Refactor dyna
xubo245 created CARBONDATA-3092:
---
Summary: Refactor dynamic configuration
Key: CARBONDATA-3092
URL: https://issues.apache.org/jira/browse/CARBONDATA-3092
Project: CarbonData
Issue Type
[
https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 reopened CARBONDATA-3063:
-
> Support set carbon property in C
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
rebase
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 closed CARBONDATA-2129.
---
Resolution: Won't Fix
> Carbon should give a remind when user use old syntax to cre
[
https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 resolved CARBONDATA-3063.
-
Resolution: Fixed
> Support set carbon property in C
[
https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 closed CARBONDATA-3063.
---
Resolution: Fixed
> Support set carbon property in C
[
https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 reopened CARBONDATA-3063:
-
> Support set carbon property in C
[
https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 closed CARBONDATA-3063.
---
Resolution: Resolved
> Support set carbon property in C
[
https://issues.apache.org/jira/browse/CARBONDATA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683368#comment-16683368
]
xubo245 commented on CARBONDATA-3073:
-
we also should support withTableProperty, withLoadOption
[
https://issues.apache.org/jira/browse/CARBONDATA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3073:
Summary: Support other interface in carbon writer of C++ SDK (was:
Support configure
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2912
[WIP][CARBONDATA-3079] Improve the C++ SDK read performance by merging
column in JNI
supprt readNextStringRow and readNextBatchStringRow
Be sure to do all of the following
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
@KanakaKumar CI pass, please check it.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231108134
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231107900
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -144,4 +246,28 @@ public static Schema
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231107288
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231105573
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r231101081
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,122 @@ public static Schema
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2875
@jacky CI pass, please check it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
@KanakaKumar CI pass, Please review it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
@KanakaKumar @kunal642 CI pass, please check it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@chenliang613 @jackylk How to handle this PR?
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2875
retest thi please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2875
test it by âInserting table: support boolean and other data type, big
fileâ test case in
org.apache.carbondata.spark.testsuite.booleantype.BooleanDataTypesBigFileTest.
when run "i
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230991320
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1744,89 +2021,101 @@ private
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230983007
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,121 @@ public static Schema
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230982799
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -61,14 +65,121 @@ public static Schema
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230982638
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java
---
@@ -101,18 +104,30 @@ public boolean accept
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r230982398
--- Diff: docs/sdk-guide.md ---
@@ -685,6 +685,31 @@ Find example code at
[CarbonReaderExample](https://github.com/apache/carbondata
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2818
why haven't test case in this PR?
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2818#discussion_r230977735
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -1558,4 +1564,6 @@ private void validateStringCharacterLimit
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
@KanakaKumar @ajantha-bhat @jackylk Please help to review it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2816
retest this please
---
xubo245 created CARBONDATA-3079:
---
Summary: Improve the C++ SDK read performance by merging column in
JNI
Key: CARBONDATA-3079
URL: https://issues.apache.org/jira/browse/CARBONDATA-3079
Project
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2899
[CARBONDATA-3073] Support configure TableProperties in carbon writer of C++
SDK
Support configure TableProperties in carbon writer of C++ SDK
Be sure to do all of the following
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2816
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2875
@jackylk CI pass, please check it.
---
xubo245 created CARBONDATA-3073:
---
Summary: Support configure TableProperties in carbon writer of C++
SDK
Key: CARBONDATA-3073
URL: https://issues.apache.org/jira/browse/CARBONDATA-3073
Project
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2816
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629905
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -975,16 +1140,39 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629760
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629803
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -897,7 +1041,8 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629792
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -435,53 +520,77 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629800
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -594,6 +713,7 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629669
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629658
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -117,77 +126,106 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230629266
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/HDFSLeaseUtils.java ---
@@ -164,22 +157,25 @@ private static boolean
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230626185
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -722,17 +723,19 @@ private void loadProperties
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2875#discussion_r230626228
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -722,17 +723,19 @@ private void loadProperties
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2816
@KanakaKumar CI pass, please check
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
@KanakaKumar @kunal642 @ajantha-bhat CI pass, Please check.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r230312203
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1521,4 +1521,294 @@ public boolean accept(File dir
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2875
@jackylk Please review it.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230286721
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -158,14 +173,31 @@ public CarbonReaderBuilder
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2875
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2875
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230264659
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1723,6 +1724,92 @@ public void
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2884
@kanaka yes, sorry
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2884
@KanakaKumar CI PASS .please check
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230256502
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -158,14 +173,31 @@ public CarbonReaderBuilder
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
@KanakaKumar CI pass, please check
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230252316
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230251185
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1737,4 +1738,89 @@ public void
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2884
@kanaka CI PASS .please check
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2842
@jackylk I updated.please check
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2816
@KanakaKumar @ajantha-bhat CI pass, please check.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2842#discussion_r229981151
--- Diff: docs/sdk-guide.md ---
@@ -24,7 +24,8 @@ CarbonData provides SDK to facilitate
# SDK Writer
-In the carbon jars package
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
@KanakaKumar ok, I unify the interface to readSchema
[CARBONDATA-2996] CarbonSchemaReader support read schema from folder path
1.Deprecated readSchemaInIndexFile
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2816
retest this please
---
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2890
[CARBONDATA-3002] Fix some spell error
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user xubo245 closed the pull request at:
https://github.com/apache/carbondata/pull/2836
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2836
OKï¼I testedï¼ it's workã I will close this PR.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r229918994
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
@@ -1723,6 +1724,92 @@ public void
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2816
retest this please
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2807
@KanakaKumar Can we provide C++ interface to read schema in this versionï¼
PR2804 we can discuss how to enhance/optimize in next version, it's ok. provide
C++ interface to read schema is more
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2842
@xuchuanyin @jackylk Please check this PR again
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2816#discussion_r229713578
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/RowBatch.java ---
@@ -100,4 +100,19 @@ public int getSize() {
counter
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2804
@ajantha-bhat @kunal642 @KanakaKumar Please check it again.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2884
@KanakaKumar Please review it.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2804#discussion_r229608660
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -64,11 +66,70 @@ public static Schema
601 - 700 of 2151 matches
Mail list logo