[jira] [Created] (CARBONDATA-3094) Support concurrent read carbondata for CSDK

2018-11-12 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3094: --- Summary: Support concurrent read carbondata for CSDK Key: CARBONDATA-3094 URL: https://issues.apache.org/jira/browse/CARBONDATA-3094 Project: CarbonData

[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error

2018-11-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2890 @jackylk @chenliang613 CI pass, please handle it. ---

[GitHub] carbondata issue #2899: [CARBONDATA-3073] Support configure TableProperties,...

2018-11-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2899 @KanakaKumar CI pass, please review it. ---

[jira] [Updated] (CARBONDATA-3092) Refactor dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3092: Description: optimize configure carbon properties. 1. Add annotation for it 2. Provide

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232632794 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232632711 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2914#discussion_r232632618 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1237,10 +1238,12 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2914: [WIP][CARBONDATA-3093] Provide property build...

2018-11-12 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2914 [WIP][CARBONDATA-3093] Provide property builder for carbon properties. [CARBONDATA-3093] Provide property builder for carbon properties. Optimize the String implementation, we can provide

[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error

2018-11-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2890 retest this please ---

[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error

2018-11-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2890 retest this please ---

[GitHub] carbondata issue #2899: [CARBONDATA-3073] Support configure TableProperties,...

2018-11-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2899 retest this please ---

[jira] [Updated] (CARBONDATA-3092) Refactor dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3092: Description: optimize configure carbon properties. 1. Add annotation for it 2. Provide

[jira] [Updated] (CARBONDATA-3038) Add annotation for carbon properties and mark whether is dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3038: Summary: Add annotation for carbon properties and mark whether is dynamic configuration

[jira] [Updated] (CARBONDATA-3093) Provide property builder for carbon properties.

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3093: Summary: Provide property builder for carbon properties. (was: Refactor dynamic

[jira] [Created] (CARBONDATA-3093) Refactor dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3093: --- Summary: Refactor dynamic configuration Key: CARBONDATA-3093 URL: https://issues.apache.org/jira/browse/CARBONDATA-3093 Project: CarbonData Issue Type

[jira] [Updated] (CARBONDATA-3093) Refactor dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3093: Issue Type: Sub-task (was: Improvement) Parent: CARBONDATA-3092 > Refactor dyna

[jira] [Updated] (CARBONDATA-3038) Refactor dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3038: Description: Refactor dynamic configuration for carbon: 1. Decide and collect all dynamic

[jira] [Updated] (CARBONDATA-3038) Refactor dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3038: Issue Type: Sub-task (was: Improvement) Parent: CARBONDATA-3092 > Refactor dyna

[jira] [Created] (CARBONDATA-3092) Refactor dynamic configuration

2018-11-12 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3092: --- Summary: Refactor dynamic configuration Key: CARBONDATA-3092 URL: https://issues.apache.org/jira/browse/CARBONDATA-3092 Project: CarbonData Issue Type

[jira] [Reopened] (CARBONDATA-3063) Support set carbon property in CSDK

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 reopened CARBONDATA-3063: - > Support set carbon property in C

[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error

2018-11-12 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2890 rebase ---

[jira] [Closed] (CARBONDATA-2129) Carbon should give a remind when user use old syntax to create timeseries pre-aggregate table

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 closed CARBONDATA-2129. --- Resolution: Won't Fix > Carbon should give a remind when user use old syntax to cre

[jira] [Resolved] (CARBONDATA-3063) Support set carbon property in CSDK

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3063. - Resolution: Fixed > Support set carbon property in C

[jira] [Closed] (CARBONDATA-3063) Support set carbon property in CSDK

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 closed CARBONDATA-3063. --- Resolution: Fixed > Support set carbon property in C

[jira] [Reopened] (CARBONDATA-3063) Support set carbon property in CSDK

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 reopened CARBONDATA-3063: - > Support set carbon property in C

[jira] [Closed] (CARBONDATA-3063) Support set carbon property in CSDK

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 closed CARBONDATA-3063. --- Resolution: Resolved > Support set carbon property in C

[jira] [Commented] (CARBONDATA-3073) Support configure TableProperties in carbon writer of C++ SDK

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683368#comment-16683368 ] xubo245 commented on CARBONDATA-3073: - we also should support withTableProperty, withLoadOption

[jira] [Updated] (CARBONDATA-3073) Support other interface in carbon writer of C++ SDK

2018-11-12 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 updated CARBONDATA-3073: Summary: Support other interface in carbon writer of C++ SDK (was: Support configure

[GitHub] carbondata pull request #2912: [WIP][CARBONDATA-3079] Improve the C++ SDK re...

2018-11-09 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2912 [WIP][CARBONDATA-3079] Improve the C++ SDK read performance by merging column in JNI supprt readNextStringRow and readNextBatchStringRow Be sure to do all of the following

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-11-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 @KanakaKumar CI pass, please check it. ---

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r231108134 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -61,14 +65,122 @@ public static Schema

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r231107900 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -144,4 +246,28 @@ public static Schema

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r231107288 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -61,14 +65,122 @@ public static Schema

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r231105573 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -61,14 +65,122 @@ public static Schema

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r231101081 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -61,14 +65,122 @@ public static Schema

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

2018-11-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 @jacky CI pass, please check it. ---

[GitHub] carbondata issue #2899: [CARBONDATA-3073] Support configure TableProperties ...

2018-11-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2899 @KanakaKumar CI pass, Please review it. ---

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 @KanakaKumar @kunal642 CI pass, please check it. ---

[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2890 @chenliang613 @jackylk How to handle this PR? ---

[GitHub] carbondata issue #2899: [CARBONDATA-3073] Support configure TableProperties ...

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2899 retest this please ---

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 retest thi please ---

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 test it by “Inserting table: support boolean and other data type, big file” test case in org.apache.carbondata.spark.testsuite.booleantype.BooleanDataTypesBigFileTest. when run "i

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-05 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230991320 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1744,89 +2021,101 @@ private

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-05 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r230983007 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -61,14 +65,121 @@ public static Schema

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-05 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r230982799 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -61,14 +65,121 @@ public static Schema

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-05 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r230982638 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java --- @@ -101,18 +104,30 @@ public boolean accept

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-11-05 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r230982398 --- Diff: docs/sdk-guide.md --- @@ -685,6 +685,31 @@ Find example code at [CarbonReaderExample](https://github.com/apache/carbondata

[GitHub] carbondata issue #2818: [CARBONDATA-3011] Add carbon property to configure v...

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2818 why haven't test case in this PR? ---

[GitHub] carbondata pull request #2818: [CARBONDATA-3011] Add carbon property to conf...

2018-11-05 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2818#discussion_r230977735 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -1558,4 +1564,6 @@ private void validateStringCharacterLimit

[GitHub] carbondata issue #2899: [CARBONDATA-3073] Support configure TableProperties ...

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2899 @KanakaKumar @ajantha-bhat @jackylk Please help to review it. ---

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---

[jira] [Created] (CARBONDATA-3079) Improve the C++ SDK read performance by merging column in JNI

2018-11-05 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3079: --- Summary: Improve the C++ SDK read performance by merging column in JNI Key: CARBONDATA-3079 URL: https://issues.apache.org/jira/browse/CARBONDATA-3079 Project

[GitHub] carbondata pull request #2899: [CARBONDATA-3073] Support configure TableProp...

2018-11-05 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2899 [CARBONDATA-3073] Support configure TableProperties in carbon writer of C++ SDK Support configure TableProperties in carbon writer of C++ SDK Be sure to do all of the following

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 @jackylk CI pass, please check it. ---

[jira] [Created] (CARBONDATA-3073) Support configure TableProperties in carbon writer of C++ SDK

2018-11-05 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3073: --- Summary: Support configure TableProperties in carbon writer of C++ SDK Key: CARBONDATA-3073 URL: https://issues.apache.org/jira/browse/CARBONDATA-3073 Project

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-11-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629905 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -975,16 +1140,39 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629760 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -117,77 +126,106 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629803 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -897,7 +1041,8 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629792 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -435,53 +520,77 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629800 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -594,6 +713,7 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629669 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -117,77 +126,106 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629658 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -117,77 +126,106 @@ private CarbonCommonConstants

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230629266 --- Diff: core/src/main/java/org/apache/carbondata/core/util/path/HDFSLeaseUtils.java --- @@ -164,22 +157,25 @@ private static boolean

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230626185 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -722,17 +723,19 @@ private void loadProperties

[GitHub] carbondata pull request #2875: [CARBONDATA-3038] Refactor dynamic configurat...

2018-11-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2875#discussion_r230626228 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -722,17 +723,19 @@ private void loadProperties

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-11-04 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 @KanakaKumar CI pass, please check ---

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-11-04 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 @KanakaKumar @kunal642 @ajantha-bhat CI pass, Please check. ---

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-11-02 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 retest this please ---

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-11-02 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r230312203 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1521,4 +1521,294 @@ public boolean accept(File dir

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

2018-11-02 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 @jackylk Please review it. ---

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Implement VectorizedReader ...

2018-11-02 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r230286721 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -158,14 +173,31 @@ public CarbonReaderBuilder

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

2018-11-02 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 retest this please ---

[GitHub] carbondata issue #2875: [CARBONDATA-3038] Refactor dynamic configuration

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2875 retest this please ---

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Implement VectorizedReader ...

2018-11-01 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r230264659 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1723,6 +1724,92 @@ public void

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2884 @kanaka yes, sorry ---

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2884 @KanakaKumar CI PASS .please check ---

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Implement VectorizedReader ...

2018-11-01 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r230256502 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java --- @@ -158,14 +173,31 @@ public CarbonReaderBuilder

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 @KanakaKumar CI pass, please check ---

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Implement VectorizedReader ...

2018-11-01 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r230252316 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -0,0 +1,194 @@ +/* + * Licensed

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Implement VectorizedReader ...

2018-11-01 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r230251185 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1737,4 +1738,89 @@ public void

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 retest this please ---

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2884 @kanaka CI PASS .please check ---

[GitHub] carbondata issue #2842: [CARBONDATA-3032] Remove carbon.blocklet.size from p...

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2842 @jackylk I updated.please check ---

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 @KanakaKumar @ajantha-bhat CI pass, please check. ---

[GitHub] carbondata pull request #2842: [CARBONDATA-3032] Remove carbon.blocklet.size...

2018-11-01 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2842#discussion_r229981151 --- Diff: docs/sdk-guide.md --- @@ -24,7 +24,8 @@ CarbonData provides SDK to facilitate # SDK Writer -In the carbon jars package

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 @KanakaKumar ok, I unify the interface to readSchema [CARBONDATA-2996] CarbonSchemaReader support read schema from folder path 1.Deprecated readSchemaInIndexFile

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-11-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---

[GitHub] carbondata pull request #2890: [CARBONDATA-3002] Fix some spell error

2018-10-31 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2890 [CARBONDATA-3002] Fix some spell error Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed

[GitHub] carbondata pull request #2836: [CARBONDATA-3027] Increase unsafe working mem...

2018-10-31 Thread xubo245
Github user xubo245 closed the pull request at: https://github.com/apache/carbondata/pull/2836 ---

[GitHub] carbondata issue #2836: [CARBONDATA-3027] Increase unsafe working memory def...

2018-10-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2836 OK,I tested, it's work。 I will close this PR. ---

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Implement VectorizedReader ...

2018-10-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229918994 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1723,6 +1724,92 @@ public void

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-10-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2816 retest this please ---

[GitHub] carbondata issue #2807: [CARBONDATA-2997] Support read schema from index fil...

2018-10-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2807 @KanakaKumar Can we provide C++ interface to read schema in this version? PR2804 we can discuss how to enhance/optimize in next version, it's ok. provide C++ interface to read schema is more

[GitHub] carbondata issue #2842: [CARBONDATA-3032] Remove carbon.blocklet.size from p...

2018-10-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2842 @xuchuanyin @jackylk Please check this PR again ---

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r229713578 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/RowBatch.java --- @@ -100,4 +100,19 @@ public int getSize() { counter

[GitHub] carbondata issue #2804: [CARBONDATA-2996] CarbonSchemaReader support read sc...

2018-10-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2804 @ajantha-bhat @kunal642 @KanakaKumar Please check it again. ---

[GitHub] carbondata issue #2884: [CARBONDATA-3063] Support set and get carbon propert...

2018-10-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2884 @KanakaKumar Please review it. ---

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-10-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r229608660 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -64,11 +66,70 @@ public static Schema

<    2   3   4   5   6   7   8   9   10   11   >