Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1211
Good. This pr has resolved the problem which i submited on mailing-list:
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/org-apache-spark-sql-catalyst-errors-package
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1206
Thanks, @chenliang613 , @xuchuanyin .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user zzcclp opened a pull request:
https://github.com/apache/carbondata/pull/1221
[CARBONDATA-1351]When 'SORT_SCOPE'='GLOBAL_SORT' and 'enable.unsafe.câ¦
â¦olumnpage'='true', 'ThreadLocalTaskInfo.getCarbonTaskInfo()' return null
When 'SORT_SCOPE'='GLOBAL_SORT
GitHub user zzcclp opened a pull request:
https://github.com/apache/carbondata/pull/1220
[CARBONDATA-1350]When 'SORT_SCOPE'='GLOBAL_SORT', the verification ofâ¦
⦠'single_pass' must be false is invalid.
The value of option 'single_pass' is coverted to low case
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1221
@xuchuanyin Done, please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1224
@jackylk please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1220
Discuss with @jackylk offline, now when 'SORT_SCOPE'='GLOBAL_SORT',
'single_pass' can be 'true', so close this pr and raise another PR-1224 to
remove useless restriction.
---
If your project
Github user zzcclp closed the pull request at:
https://github.com/apache/carbondata/pull/1220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zzcclp opened a pull request:
https://github.com/apache/carbondata/pull/1224
[CARBONDATA-1354]Remove the useless restriction of 'single_pass' can not
be true when 'SORT_SCOPE'='GLOBAL_SORT'
Now when 'SORT_SCOPE'='GLOBAL_SORT', 'single_pass' can be 'true', so remove
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1224
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1226#discussion_r131050377
--- Diff: pom.xml ---
@@ -401,6 +398,9 @@
spark-2.1
+
+true
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1224
@jackylk , I found there is a test case in
org.apache.carbondata.spark.testsuite.dataload.TestGlobalSortDataLoad, but now
it's ignore, just change it to test, OK?
```
// Waiting
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1224
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1228
there are some wrong with apache github, all prs builded with Spark 2.1.0
are failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
@jackylk please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r133619148
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r133619308
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
@jackylk thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user zzcclp opened a pull request:
https://github.com/apache/carbondata/pull/1206
[CARBONDATA-1337] fix error of 'Problem while intermediate merging' wâ¦
â¦hen loading data
With PR-1198(CARBONDATA-1281), when loading data, there was error occuring,
as following
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1206#discussion_r130038378
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortIntermediateFileMerger.java
---
@@ -17,6 +17,7
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1079
@sounakr @ravipesala any progress on this pr? it was merged onto
branch-1.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1079
why this pr is not yet merged, but was merged into branch-1.1 first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zzcclp commented on the issue:
https://github.com/apache/incubator-carbondata/pull/867
LGTM, it works correctly now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
@jackylk @watermen @xuchuanyin thanks for your suggestion, I have added
option 'carbon.global.sort.rdd.storage.level', please review.
---
If your project is set up for it, you can reply
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1205#discussion_r130534145
--- Diff: docs/dml-operation-on-carbondata.md ---
@@ -149,6 +149,50 @@ You can use the following options to load data:
* If this option
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1205#discussion_r130581766
--- Diff: docs/dml-operation-on-carbondata.md ---
@@ -149,6 +149,50 @@ You can use the following options to load data:
* If this option
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1224
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user zzcclp opened a pull request:
https://github.com/apache/carbondata/pull/1245
[CARBONDATA-1366]Change rdd storage level to 'MEMORY_AND_DISK_SER' to
improve loading performance when sort_scope=global_sort
My testing env and configs are as followings:
**Env
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1245
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1242#discussion_r131576451
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/hive/DistributionUtil.scala
---
@@ -115,7 +115,9 @@ object DistributionUtil
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
@ravipesala @jackylk please review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1025
LGTM, I met the same issue:
java.lang.ClassCastException: java.lang.Integer cannot be cast to
java.lang.Long
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1025
@jackylk @ravipesala ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1346
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1273
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
@ravipesala @chenliang613 will this pr be merged into branch-1.2?
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1346
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
what's problem with this pr, it always builds failed with Spark 2.1.0?
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please.
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please.
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
Thanks @ravipesala @jackylk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
LGTM, it works correctly now.
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1337
retest this please
---
GitHub user zzcclp opened a pull request:
https://github.com/apache/carbondata/pull/1340
[CARBONDATA-1462]Add an option 'carbon.update.storage.level' to support
configuring the storage level when updating data with
'carbon.update.persist.enable'='true'
When updating data
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
@jackylk @ravipesala please reivew, thanks.
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
retest this please.
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1340
retest this please
---
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1266#discussion_r134168452
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -105,13 +105,15 @@ private synchronized MemoryBlock
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
rebase, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
@CarbonDataQA @jackylk @ravipesala can anyone review this pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
retest it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1266#discussion_r134106795
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -105,13 +105,15 @@ private synchronized MemoryBlock
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1304
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
@ravipesala, @jackylk I have introduced a boolean flag inside MemoryBlock
to check already cleaned or not, please review , thanks.
---
If your project is set up for it, you can reply
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1304
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1266
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1304#discussion_r136251853
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -774,8 +774,8 @@ case class LoadTable
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152921148
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/CarbonV1toV3CompatabilityTestCase.scala
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1540
@chenliang613 , it seems there are many places about column group need to
be removed, for example:
in TableNewProcessor.process():
`checkColGroupsValidity(cm.columnGroups, allColumns
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1460
please rebase to branch master
---
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152721088
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -42,15 +42,46 @@ class CarbonSession(@transient val sc
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152725691
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -42,15 +42,46 @@ class CarbonSession(@transient val sc
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728263
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -95,11 +165,40 @@ case class
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728246
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -95,11 +165,40 @@ case class
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728384
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -143,52 +246,250 @@ case class
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728991
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/internal/CarbonSqlConf.scala
---
@@ -32,76 +32,6 @@ class CarbonSQLConf(sparkSession
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152729085
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala
---
@@ -17,19 +17,23 @@
package
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152726082
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala
---
@@ -26,13 +26,20 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152725990
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala
---
@@ -42,6 +43,7 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728527
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
@@ -115,18 +121,50 @@ class CarbonFileMetastore
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728579
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonHiveMetaStore.scala
---
@@ -153,8 +153,11 @@ class CarbonHiveMetaStore
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728413
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -143,52 +246,250 @@ case class
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728420
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -143,52 +246,250 @@ case class
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728438
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -143,52 +246,250 @@ case class
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728433
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
@@ -143,52 +246,250 @@ case class
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152728764
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonOptimizer.scala
---
@@ -0,0 +1,161 @@
+/*
+ * Licensed
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152729132
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
@@ -38,7 +40,26 @@ import
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1469#discussion_r152729141
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
@@ -38,7 +40,26 @@ import
1 - 100 of 525 matches
Mail list logo
