[GitHub] [carbondata] marchpure commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-10-01 Thread GitBox
marchpure commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-702129123 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-10-01 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-702125570 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2545/

[GitHub] [carbondata] marchpure commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-10-01 Thread GitBox
marchpure commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-702095077 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-10-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#discussion_r498182999 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -96,20 +100,37 @@ object CarbonStore { *

[GitHub] [carbondata] akashrn5 commented on pull request #3963: [CARBONDATA-4018]Fix CSV header validation not contains dimension columns

2020-10-01 Thread GitBox
akashrn5 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-702078477 i will add one test case This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-10-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#discussion_r498178139 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ## @@ -1881,7 +1881,9 @@ public static TableInfo

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-10-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#discussion_r498176312 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ## @@ -1881,7 +1881,9 @@ public static TableInfo

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-10-01 Thread GitBox
akashrn5 commented on a change in pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#discussion_r498175600 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ## @@ -1881,7 +1881,9 @@ public static TableInfo

[GitHub] [carbondata] marchpure commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-10-01 Thread GitBox
marchpure commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-702062616 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-10-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#discussion_r498158964 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondryIndex.scala ## @@

[GitHub] [carbondata] kunal642 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

2020-10-01 Thread GitBox
kunal642 commented on pull request #3952: URL: https://github.com/apache/carbondata/pull/3952#issuecomment-702057242 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] marchpure commented on a change in pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-10-01 Thread GitBox
marchpure commented on a change in pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#discussion_r498155406 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala ## @@ -477,13

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-10-01 Thread GitBox
Indhumathi27 commented on a change in pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#discussion_r498084784 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -96,20 +100,31 @@ object CarbonStore { *

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be copied to after

2020-10-01 Thread GitBox
CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-701971400 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4288/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3917: [CARBONDATA-3978] Clean files refactor and added support for a trash folder where all the carbondata files will be copied to after

2020-10-01 Thread GitBox
CarbonDataQA1 commented on pull request #3917: URL: https://github.com/apache/carbondata/pull/3917#issuecomment-701970889 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2541/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-01 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-701926728 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2540/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3695: [WIP] partition optimization

2020-10-01 Thread GitBox
CarbonDataQA1 commented on pull request #3695: URL: https://github.com/apache/carbondata/pull/3695#issuecomment-701923605 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4287/

[GitHub] [carbondata] kunal642 opened a new pull request #3695: [WIP] partition optimization

2020-09-30 Thread GitBox
kunal642 opened a new pull request #3695: URL: https://github.com/apache/carbondata/pull/3695 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-30 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701401558 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2539/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-30 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701400075 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4286/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox
CarbonDataQA1 commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701347623 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4282/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox
CarbonDataQA1 commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701346331 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2537/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-09-30 Thread GitBox
CarbonDataQA1 commented on pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#issuecomment-701346144 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2538/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-09-30 Thread GitBox
CarbonDataQA1 commented on pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#issuecomment-701344984 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4283/

[GitHub] [carbondata] marchpure commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-30 Thread GitBox
marchpure commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701334249 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox
Kejian-Li commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701243192 > please check the following files. > CarbonDataRDDFactory 977 line > CarbonAlterTableCompactionCommand 324 line Done

[GitHub] [carbondata] QiangCai commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox
QiangCai commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701213375 please check the following files. CarbonDataRDDFactory 977 line CarbonAlterTableCompactionCommand 324 line

[GitHub] [carbondata] QiangCai commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-09-30 Thread GitBox
QiangCai commented on a change in pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#discussion_r497268957 ## File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java ## @@ -106,6 +108,11 @@ */

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701160608 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4280/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701160434 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2535/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701129169 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2533/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701128059 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4278/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-701128054 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4277/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-701127913 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2532/

[GitHub] [carbondata] Zhangshunyu commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox
Zhangshunyu commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701106628 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] Klaus-xjp commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox
Klaus-xjp commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701105544 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Klaus-xjp commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
Klaus-xjp commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-701097047 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700906032 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4276/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700900738 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2530/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700899917 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2531/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700894338 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4275/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700844396 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2529/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3965: URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700843530 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4274/

[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
Klaus-xjp commented on a change in pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#discussion_r496864594 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java ## @@ -421,6 +421,12 @@ public boolean

[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
Klaus-xjp commented on a change in pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#discussion_r496853936 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala ## @@ -507,17

[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox
marchpure commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700805019 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700804521 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4273/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700803544 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2528/

[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
Klaus-xjp commented on a change in pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#discussion_r496844035 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java ## @@ -293,6 +293,32 @@ public static boolean

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700787176 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4271/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700785754 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2526/

[GitHub] [carbondata] marchpure opened a new pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox
marchpure opened a new pull request #3965: URL: https://github.com/apache/carbondata/pull/3965 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox
Kejian-Li commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700722195 > Or change the pr title to "Remove hardcode of Lock configuration in Update and Delete" > Or change the pr title to "Remove hardcode of Lock configuration

[GitHub] [carbondata] Kejian-Li edited a comment on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox
Kejian-Li edited a comment on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700722195 > Or change the pr title to "Remove hardcode of Lock configuration in Update and Delete" Ok

[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox
marchpure commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700720893 Or change the pr title to "Remove hardcode of Lock configuration in Update and Delete" This is an

[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox
marchpure commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700719957 In description: it is neccessary to be fixed in code => it is not neccessary to be fixed in code

[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox
Kejian-Li commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700719022 > Change the PR Title to 'Support Lock Configuration can be configured in Update and Delete' Ok

[GitHub] [carbondata] marchpure edited a comment on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default val

2020-09-29 Thread GitBox
marchpure edited a comment on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312 Change the PR Title to 'Support Lock configuration can be configured in Update and Delete' This is

[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox
marchpure commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312 Change the PR Title to 'Support Lock configuration can be configured in Update and Delete' This is an

[GitHub] [carbondata] marchpure edited a comment on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default val

2020-09-29 Thread GitBox
marchpure edited a comment on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312 Change the PR Title to 'Support Lock Configuration can be configured in Update and Delete' This is

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700716620 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4272/

[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox
Kejian-Li commented on pull request #3964: URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700713068 @marchpure please help review this PR This is an automated message from the Apache Git Service. To respond

[GitHub] [carbondata] Kejian-Li opened a new pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox
Kejian-Li opened a new pull request #3964: URL: https://github.com/apache/carbondata/pull/3964 ### Why is this PR needed? Retrycount and retryInterval of compactLock and updateLock is fixed as "3" when they try to get lcok, default values of these two parameters is exactly "3",

[GitHub] [carbondata] Kejian-Li closed pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
Kejian-Li closed pull request #3947: URL: https://github.com/apache/carbondata/pull/3947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
Kejian-Li commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700697188 > @Kejian-Li i can just see the test file changes and no source file changes for the issue which you described. So im confused what exactly or how exactly

[GitHub] [carbondata] Kejian-Li edited a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
Kejian-Li edited a comment on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700697188 > @Kejian-Li i can just see the test file changes and no source file changes for the issue which you described. So im confused what exactly or how exactly the

[GitHub] [carbondata] marchpure commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
marchpure commented on a change in pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#discussion_r496708385 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala ## @@ -507,17

[GitHub] [carbondata] marchpure commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox
marchpure commented on a change in pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#discussion_r495646765 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java ## @@ -421,6 +421,12 @@ public boolean

[GitHub] [carbondata] asfgit closed pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
asfgit closed pull request #3960: URL: https://github.com/apache/carbondata/pull/3960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] kunal642 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
kunal642 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700659418 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700650642 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2524/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700647666 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4269/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700553209 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2523/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700545126 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4268/

[GitHub] [carbondata] akashrn5 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
akashrn5 commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700534709 @Kejian-Li i can just see the test file changes and no source file changes for the issue which you described. So im confused what exactly or how exactly the problem is

[GitHub] [carbondata] akashrn5 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
akashrn5 commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700503471 @Kejian-Li from the PR description, you have mentioned the problem is we cannot run the update to table when the insert is in progress, which is valid, that's because we

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3952: URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700502890 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4267/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

2020-09-29 Thread GitBox
CarbonDataQA1 commented on pull request #3952: URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700501338 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2522/

[GitHub] [carbondata] kunal642 commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
kunal642 commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r496461049 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala ##

[GitHub] [carbondata] marchpure commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
marchpure commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700490385 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] akashrn5 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox
akashrn5 commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700489664 > please check mail list: > http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html > > How

[GitHub] [carbondata] Zhangshunyu commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox
Zhangshunyu commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700485310 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700451914 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2521/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700440309 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4266/

[GitHub] [carbondata] vikramahuja1001 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

2020-09-28 Thread GitBox
vikramahuja1001 commented on pull request #3952: URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700432240 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700407129 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700406306 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4265/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700405441 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2520/

[GitHub] [carbondata] QiangCai edited a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox
QiangCai edited a comment on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270 please check mail list: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html How

[GitHub] [carbondata] QiangCai commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox
QiangCai commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270 please check mail list: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html How do you

[GitHub] [carbondata] Kejian-Li removed a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox
Kejian-Li removed a comment on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456 @ajantha-bhat @akashrn5 please help review this PR This is an automated message from the Apache

[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r496323043 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox
Klaus-xjp commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r496322133 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox
Kejian-Li commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456 @ajantha-bhat @akashrn5 please help review this PR This is an automated message from the Apache Git

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-09-28 Thread GitBox
VenuReddy2103 commented on a change in pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659 ## File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java ## @@ -106,6 +108,11 @@ */

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-09-28 Thread GitBox
VenuReddy2103 commented on a change in pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659 ## File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java ## @@ -106,6 +108,11 @@ */

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700226423 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4264/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700223919 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2519/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700218552 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4263/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-09-28 Thread GitBox
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700208844 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2518/

  1   2   3   4   5   6   7   8   9   10   >