[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-30 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701401558


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2539/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-30 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701400075


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4286/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox


CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701347623


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4282/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox


CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701346331


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2537/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-09-30 Thread GitBox


CarbonDataQA1 commented on pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962#issuecomment-701346144


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2538/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [CARBONDATA-4017]Fix the insert issue when the column name contains '\' and fix SI creation issue

2020-09-30 Thread GitBox


CarbonDataQA1 commented on pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962#issuecomment-701344984


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4283/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-30 Thread GitBox


marchpure commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701334249


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox


Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701243192


   > please check the following files.
   > CarbonDataRDDFactory 977 line
   > CarbonAlterTableCompactionCommand 324 line
   
   Done



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] QiangCai commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-30 Thread GitBox


QiangCai commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701213375


   please check the following files.
   CarbonDataRDDFactory 977 line
   CarbonAlterTableCompactionCommand 324 line



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] QiangCai commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-09-30 Thread GitBox


QiangCai commented on a change in pull request #3953:
URL: https://github.com/apache/carbondata/pull/3953#discussion_r497268957



##
File path: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java
##
@@ -106,6 +108,11 @@
*/
   boolean isNaturalSorted;
 
+  /**
+   * date direct dictionary generator
+   */
+  private DirectDictionaryGenerator dateDictionaryGenerator;
+
   public RowLevelFilterExecutorImpl(List 
dimColEvaluatorInfoList,

Review comment:
   in my opinion, when we need to use RowLevelFilterExecutorImpl,  better 
to consider why we pushdown this predicate into the create relation at first.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701160608


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4280/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701160434


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2535/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701129169


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2533/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-701128059


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4278/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-701128054


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4277/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-701127913


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2532/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Zhangshunyu commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox


Zhangshunyu commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701106628


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Klaus-xjp commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox


Klaus-xjp commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-701105544


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Klaus-xjp commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


Klaus-xjp commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-701097047


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700906032


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4276/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700900738


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2530/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700899917


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2531/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700894338


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4275/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700844396


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2529/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965#issuecomment-700843530


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4274/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496864594



##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission 
permission) throws IOException {
 return file.createNewFile();
   }
 
+  @Override
+  public boolean createNewFile(Boolean overwrite, final FsPermission 
permission)
+  throws IOException {
+return file.createNewFile();

Review comment:
   i have changed this function





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496853936



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala
##
@@ -507,17 +507,17 @@ case class CarbonInsertFromStageCommand(
 override def call(): (CarbonFile, CarbonFile, Boolean) = {
   try {
 // Get the loading files path
-val stageLoadingFile =
-  FileFactory.getCarbonFile(stagePath +
-File.separator + files._1.getName + 
CarbonTablePath.LOADING_FILE_SUFFIX);
+val stageLoadingFilePath = stagePath + File.separator + 
files._1.getName +
+   CarbonTablePath.LOADING_FILE_SUFFIX

Review comment:
   i have reformat this line





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox


marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700805019


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700804521


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4273/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015] Remove hardcode of Lock configuration in Update and Delete

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700803544


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2528/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496844035



##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
##
@@ -293,6 +293,32 @@ public static boolean createNewFile(
 return getCarbonFile(filePath).createNewFile(permission);
   }
 
+  public static boolean createNewFile(String filePath, Boolean overwrite,
+  final FsPermission permission) throws IOException {
+return getCarbonFile(filePath).createNewFile(overwrite, permission);
+  }
+
+  public static long setCurrentTimetoLastModifiedTime(String filePath) throws 
IOException {

Review comment:
   i have renamed this function





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700787176


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4271/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700785754


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2526/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure opened a new pull request #3965: [CARBONDATA-4016] NPE and FileNotFound in Show Segments and Insert Stage

2020-09-29 Thread GitBox


marchpure opened a new pull request #3965:
URL: https://github.com/apache/carbondata/pull/3965


### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox


Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700722195


   > Or change the pr title to "Remove hardcode of Lock configuration in Update 
and Delete"
   
   
   
   > Or change the pr title to "Remove hardcode of Lock configuration in Update 
and Delete"
   
   Ok



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li edited a comment on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox


Kejian-Li edited a comment on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700722195


   > Or change the pr title to "Remove hardcode of Lock configuration in Update 
and Delete"
   
   Ok



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox


marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700720893


   Or change the pr title to "Remove hardcode of Lock configuration in Update 
and Delete"



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015]Support Lock Configuration can be configured in Update and Delete

2020-09-29 Thread GitBox


marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700719957


   In description:
   
   it is neccessary to be fixed in code
   => it is not neccessary to be fixed in code



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox


Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700719022


   > Change the PR Title to 'Support Lock Configuration can be configured in 
Update and Delete'
   
   Ok



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure edited a comment on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default val

2020-09-29 Thread GitBox


marchpure edited a comment on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312


   Change the PR Title to 'Support Lock configuration can be configured in 
Update and Delete'



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox


marchpure commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312


   Change the PR Title to 'Support Lock configuration can be configured in 
Update and Delete'



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure edited a comment on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default val

2020-09-29 Thread GitBox


marchpure edited a comment on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700718312


   Change the PR Title to 'Support Lock Configuration can be configured in 
Update and Delete'



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700716620


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4272/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li commented on pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox


Kejian-Li commented on pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964#issuecomment-700713068


   @marchpure please help review this PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li opened a new pull request #3964: [CARBONDATA-4015]Allow retryCount and retryInterval of updateLock and compactLock to be configured by users or using default value.

2020-09-29 Thread GitBox


Kejian-Li opened a new pull request #3964:
URL: https://github.com/apache/carbondata/pull/3964


   ### Why is this PR needed?
   
   Retrycount and retryInterval of compactLock and updateLock is fixed as "3" 
when they try to get lcok, default values of these two parameters is exactly 
"3", therefore, it is neccessary to be fixed in code, it is also good to allow 
users to configure them in the carbon.properties by removing them.

### What changes were proposed in this PR?
   
   Removed the parameters of compactLock and updateLock when they try to get 
lock.
   Besides, I made some obvious but trivial changes and modified or added some 
testcases.
   
### Does this PR introduce any user interface change?
   
- No
   
### Is any new testcase added?
   
- No
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li closed pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


Kejian-Li closed pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700697188


   
   
   
   
   > @Kejian-Li i can just see the test file changes and no source file changes 
for the issue which you described. So im confused what exactly or how exactly 
the problem is solved. can you please explain?
   
   My idea and implementation is not considerable, so I just removed the 
relative code concurrency
   
   > @Kejian-Li i can just see the test file changes and no source file changes 
for the issue which you described. So im confused what exactly or how exactly 
the problem is solved. can you please explain?
   
   My idea and implementation is not considerable, I will explain this later.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li edited a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


Kejian-Li edited a comment on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700697188


   > @Kejian-Li i can just see the test file changes and no source file changes 
for the issue which you described. So im confused what exactly or how exactly 
the problem is solved. can you please explain?
   
   My idea and implementation is not considerable, I will explain this later.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


marchpure commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r496708385



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertFromStageCommand.scala
##
@@ -507,17 +507,17 @@ case class CarbonInsertFromStageCommand(
 override def call(): (CarbonFile, CarbonFile, Boolean) = {
   try {
 // Get the loading files path
-val stageLoadingFile =
-  FileFactory.getCarbonFile(stagePath +
-File.separator + files._1.getName + 
CarbonTablePath.LOADING_FILE_SUFFIX);
+val stageLoadingFilePath = stagePath + File.separator + 
files._1.getName +
+   CarbonTablePath.LOADING_FILE_SUFFIX

Review comment:
   take care about format





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-29 Thread GitBox


marchpure commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495646765



##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission 
permission) throws IOException {
 return file.createNewFile();
   }
 
+  @Override
+  public boolean createNewFile(Boolean overwrite, final FsPermission 
permission)
+  throws IOException {
+return file.createNewFile();

Review comment:
   we can't discard parameters like this

##
File path: 
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
##
@@ -293,6 +293,32 @@ public static boolean createNewFile(
 return getCarbonFile(filePath).createNewFile(permission);
   }
 
+  public static boolean createNewFile(String filePath, Boolean overwrite,
+  final FsPermission permission) throws IOException {
+return getCarbonFile(filePath).createNewFile(overwrite, permission);
+  }
+
+  public static long setCurrentTimetoLastModifiedTime(String filePath) throws 
IOException {

Review comment:
   setLastModifiedTimetoCurrentTimeto





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] asfgit closed pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


asfgit closed pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] kunal642 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


kunal642 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700659418


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700650642


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2524/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700647666


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4269/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700553209


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2523/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700545126


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4268/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


akashrn5 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700534709


   @Kejian-Li i can just see the test file changes and no source file changes 
for the issue which you described. So im confused what exactly or how exactly 
the problem is solved. can you please explain?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


akashrn5 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700503471


   @Kejian-Li from the PR description, you have mentioned the problem is we 
cannot run the update to table when the insert is in progress, which is valid, 
that's because we want to maintain the data consistency. But you suggest we 
remove that check to allow the update. How do you plan to manage the data 
consistency when the insert in progress? You have not mentioned clearly in the 
description and its not clear from changes also. 
   
   As @Zhangshunyu asked same doubt in above comments, there is no clear reply. 
Can you please explain the solution you have given here?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700502890


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4267/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

2020-09-29 Thread GitBox


CarbonDataQA1 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700501338


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2522/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] kunal642 commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


kunal642 commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r496461049



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
@@ -150,45 +141,50 @@ private[sql] case class 
CarbonAlterTableColRenameDataTypeChangeCommand(
   }
   val newColumnPrecision = 
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.precision
   val newColumnScale = 
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.scale
-  if (alterTableColRenameAndDataTypeChangeModel.isColumnRename) {
-// validate the columns to be renamed
-validColumnsForRenaming(carbonColumns, oldCarbonColumn.head, 
carbonTable)
-// if the datatype is source datatype, then it is just a column rename 
operation, else set
-// the isDataTypeChange flag to true
-if (oldCarbonColumn.head.getDataType.getName
-  
.equalsIgnoreCase(alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.dataType))
 {
-  val newColumnPrecision =
-alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.precision
-  val newColumnScale = 
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.scale
-  // if the source datatype is decimal and there is change in 
precision and scale, then
-  // along with rename, datatype change is also required for the 
command, so set the
-  // isDataTypeChange flag to true in this case
-  if 
(oldCarbonColumn.head.getDataType.getName.equalsIgnoreCase("decimal") &&
-  
(oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getPrecision !=
-   newColumnPrecision ||
-   
oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getScale !=
-   newColumnScale)) {
-isDataTypeChange = true
-  }
-} else {
+  // set isDataTypeChange flag
+  if (oldCarbonColumn.head.getDataType.getName
+
.equalsIgnoreCase(alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.dataType))
 {
+val newColumnPrecision =
+  alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.precision
+val newColumnScale = 
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.scale
+// if the source datatype is decimal and there is change in precision 
and scale, then
+// along with rename, datatype change is also required for the 
command, so set the
+// isDataTypeChange flag to true in this case
+if 
(oldCarbonColumn.head.getDataType.getName.equalsIgnoreCase("decimal") &&
+
(oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getPrecision !=
+ newColumnPrecision ||
+ 
oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getScale !=
+ newColumnScale)) {
   isDataTypeChange = true
 }
   } else {
 isDataTypeChange = true
   }
-  if (isDataTypeChange) {
-// if column datatype change operation is on partition column, then 
fail the datatype change
-// operation
-if (null != carbonTable.getPartitionInfo) {
-  val partitionColumns = 
carbonTable.getPartitionInfo.getColumnSchemaList
-  partitionColumns.asScala.foreach {
-col =>
-  if (col.getColumnName.equalsIgnoreCase(oldColumnName)) {
-throw new MalformedCarbonCommandException(
-  s"Alter datatype of the partition column $newColumnName is 
not allowed")
-  }
-  }
+  // If there is no columnrename and datatype change and comment change
+  // return directly without execution
+  if (!isColumnRename && !isDataTypeChange && !newColumnComment.isDefined) 
{
+return Seq.empty
+  }
+  // if column datatype change operation is on partition column, then fail 
the
+  // chang column operation
+  if (null != carbonTable.getPartitionInfo) {
+val partitionColumns = carbonTable.getPartitionInfo.getColumnSchemaList
+partitionColumns.asScala.foreach {
+  col =>
+if (col.getColumnName.equalsIgnoreCase(oldColumnName)) {
+  throw new MalformedCarbonCommandException(
+s"Change Column Operation failed. Renaming or ChangeType or " +

Review comment:
   Please change this to 
   
   `throw new InvalidOperationException("Alter on partition columns is not 
supported")`
   
   And add a test case for this





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


marchpure commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700490385


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-29 Thread GitBox


akashrn5 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700489664


   > please check mail list:
   > 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html
   > 
   > How do we process the parallel compaction(not only loading) and update?
   
   I involved in that solution derivation, But its recommended and community's 
suggestion to start working on it after segment refactoring.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Zhangshunyu commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-29 Thread GitBox


Zhangshunyu commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700485310


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700451914


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2521/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700440309


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4266/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] vikramahuja1001 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

2020-09-28 Thread GitBox


vikramahuja1001 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700432240


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700407129


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700406306


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4265/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700405441


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2520/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] QiangCai edited a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox


QiangCai edited a comment on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270


   please check mail list: 
   
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html
   
   How do we process the parallel compaction(not only loading) and update?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] QiangCai commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox


QiangCai commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270


   please check mail list: 
   
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html
   
   How do you process the parallel compaction(not only loading) and update?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li removed a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox


Kejian-Li removed a comment on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456


   @ajantha-bhat @akashrn5 please help review this PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r496323043



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
@@ -258,7 +262,7 @@ private[sql] case class 
CarbonAlterTableColRenameDataTypeChangeCommand(
   }
 } catch {
   case e: Exception =>
-if (carbonTable != null) {
+   if ( carbonTable != null) {

Review comment:
   I have modified code according to you suggestion.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


Klaus-xjp commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r496322133



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
@@ -258,7 +262,7 @@ private[sql] case class 
CarbonAlterTableColRenameDataTypeChangeCommand(
   }
 } catch {
   case e: Exception =>
-if (carbonTable != null) {
+   if ( carbonTable != null) {

Review comment:
   there has a blank between the '(' and carbonTable





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox


Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456


   @ajantha-bhat @akashrn5 please help review this PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-09-28 Thread GitBox


VenuReddy2103 commented on a change in pull request #3953:
URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659



##
File path: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java
##
@@ -106,6 +108,11 @@
*/
   boolean isNaturalSorted;
 
+  /**
+   * date direct dictionary generator
+   */
+  private DirectDictionaryGenerator dateDictionaryGenerator;
+
   public RowLevelFilterExecutorImpl(List 
dimColEvaluatorInfoList,

Review comment:
   Have checked this. We are using IncludeFilterExecutorImpl as long as 
their is no cast expression involved. Cast is involved only when the data type 
of column to compare is  not same as the literal values it is compared with.
 Each literal value in the InFilter can be of different type. Spark 
chooses one datatype for the entire list of literal values.  
   For example, with i as int column
   i IN (3, 2, 1.0) -> all values treated as decimal
   i IN (3, 2.0, '1.0') -> all values are treated as string. Note: 2.0 is not 
same as 2 when casted as string.
When the cast operation is present, `SparkUnknownExpression` with spark 
cast(`SparkExpression`) is used. `SparkUnknownExpression.evaluate()` takes 
row's column value.  Using spark cast expression, validates it and converts it 
to datatype of literal value it chose. And then compare the converted column 
value against literal values. So validation and type conversions are handled 
with spark cast expression.
   IMO, IncludeFilterExecutorImpl is already used when possible.
   
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true

2020-09-28 Thread GitBox


VenuReddy2103 commented on a change in pull request #3953:
URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659



##
File path: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java
##
@@ -106,6 +108,11 @@
*/
   boolean isNaturalSorted;
 
+  /**
+   * date direct dictionary generator
+   */
+  private DirectDictionaryGenerator dateDictionaryGenerator;
+
   public RowLevelFilterExecutorImpl(List 
dimColEvaluatorInfoList,

Review comment:
   Have checked this. We are using IncludeFilterExecutorImpl as long as 
their is no cast expression involved. Cast operation is involved only when the 
data type of column to compare is  not same as the literal values it is 
compared with.
 Each literal value in the InFilter can be of different type. Spark 
chooses one datatype for the entire list of literal values.  
   For example,
   i IN (3, 2, 1.0) -> all values treated as decimal
   i IN (3, 2.0, '1.0') -> all values are treated as string. Note: 2.0 is not 
same as 2 when casted as string.
When the cast operation is present, `SparkUnknownExpression` with spark 
cast(`SparkExpression`) is used. `SparkUnknownExpression.evaluate()` takes 
row's column value.  Using spark cast expression, validates it and converts it 
to datatype of literal value it chose. And then compare the converted column 
value against literal values. So validation and type conversions are handled 
with spark cast expression.
   IMO, IncludeFilterExecutorImpl is already used when possible.
   
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700226423


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4264/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700223919


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2519/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700218552


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4263/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700208844


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2518/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700202083


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4262/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700181171


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2517/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [wip]Fix the insert issue when the column name contains \ or backslash

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962#issuecomment-700169378


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2514/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [wip]Fix the insert issue when the column name contains \ or backslash

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962#issuecomment-700164625


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4259/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3961: [wip]Fix cdc merge when there are multiple bucket and join columns and AND or OR join expressions

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3961:
URL: https://github.com/apache/carbondata/pull/3961#issuecomment-700164154







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700160169


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4258/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700157254


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2513/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700142851


   Build Failed  with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4261/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700143229


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2516/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700109547


   > if alter column change nothing, the command should return directly without 
execution.
   
   I have modified code according to you suggestion.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700098125


   Build Success with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2512/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700093868


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4256/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 opened a new pull request #3963: [WIP]Fix CSV header validation not contains dimension columns

2020-09-28 Thread GitBox


akashrn5 opened a new pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963


### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 opened a new pull request #3962: [wip]Fix the insert issue when the column name contains \ or backslash

2020-09-28 Thread GitBox


akashrn5 opened a new pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962


### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] akashrn5 opened a new pull request #3961: [wip]Fix cdc merge when there are multiple bucket and join columns and AND or OR join expressions

2020-09-28 Thread GitBox


akashrn5 opened a new pull request #3961:
URL: https://github.com/apache/carbondata/pull/3961


   Fix cdc merge when there are multiple bucket and join columns and AND or OR 
join expressions
   
### Why is this PR needed?


### What changes were proposed in this PR?
   
   
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
   
### Is any new testcase added?
- No
- Yes
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] Klaus-xjp commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-28 Thread GitBox


Klaus-xjp commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700055644


   retest this please
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700054701


   Build Success with Spark 2.3.4, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4255/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…

2020-09-28 Thread GitBox


CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700050277


   Build Failed  with Spark 2.4.5, Please check CI 
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2510/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   3   4   5   6   7   8   9   10   >