[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-11-25 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 @chenliang613 please review this pr ---

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-10-28 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 @chenliang613 ---

[GitHub] carbondata pull request #1409: [CARBODNATA-1377] support hive partition

2017-10-10 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1409 [CARBODNATA-1377] support hive partition support hive partition ```sql create table if not exists temp.hash_partition_table(col_A String) partitioned by (col_B Long) stored

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-10-03 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 @anubhav100 ---

[GitHub] carbondata issue #1363: [CARBONDATA-1378] support creating table in hive

2017-09-21 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1363 OK ---

[GitHub] carbondata issue #1363: [CARBONDATA-1378] support creating table in hive

2017-09-17 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1363 retest please ---

[GitHub] carbondata pull request #1363: [CARBONDATA-1378] support creating table in h...

2017-09-17 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1363 [CARBONDATA-1378] support creating table in hive support creating table in hive You can merge this pull request into a Git repository by running: $ git pull https://github.com/cenyuhai

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-09-16 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 @chenliang613 @anubhav100 ---

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-09-16 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 I find the root cause, AbstractQueryExecutor will call `freeMemoryAll(ThreadLocalTaskInfo.getCarbonTaskInfo().getTaskId())`. We should use another taskId for UnsafeMemoryDMStore ---

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-09-16 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 {code} hive> select * from temp.yuhai_carbon; OK 2 runlin 2 china 33000.2 1 yuhai 2 china 33000.1 Time taken: 1.696 seconds, Fetched: 2 ro

[GitHub] carbondata pull request #1356: [CARBONDATA-1477] corrected the bug for wrong...

2017-09-13 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1356#discussion_r138654019 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java --- @@ -228,9 +229,13 @@ private Writable

[GitHub] carbondata pull request #985: [CARBONDATA-1090] added integration test cases...

2017-09-10 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/985#discussion_r137942979 --- Diff: integration/hive/pom.xml --- @@ -126,20 +126,20 @@ +src/test/scala

[GitHub] carbondata pull request #985: [CARBONDATA-1090] added integration test cases...

2017-09-10 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/985#discussion_r137942968 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java --- @@ -231,11 +231,11 @@ private Writable

[GitHub] carbondata issue #1312: [CARBONDATA-1441]resolved the bug for schema not ref...

2017-08-31 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1312 It looks good, I will test it on my computer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata pull request #1286: [CARBONDATA-1404] Added Unit test cases for H...

2017-08-30 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1286#discussion_r136081693 --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonHiveRecordReader.java --- @@ -0,0 +1,232 @@ +/* + * Licensed

[GitHub] carbondata pull request #1286: [CARBONDATA-1404] Added Unit test cases for H...

2017-08-30 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1286#discussion_r136079374 --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonHiveRecordReader.java --- @@ -0,0 +1,232 @@ +/* + * Licensed

[GitHub] carbondata pull request #1286: [CARBONDATA-1404] Added Unit test cases for H...

2017-08-30 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1286#discussion_r136076518 --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/CarbonObjectInspectorTest.java --- @@ -0,0 +1,159 @@ +/* + * Licensed

[GitHub] carbondata issue #1286: [CARBONDATA-1404] Added Unit test cases for Hive Int...

2017-08-30 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1286 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-27 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 @anubhav100 @chenliang613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-27 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1291: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-27 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1291 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1239: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-27 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1239 I make a mistake, I use an old branch to commit code... So close this pr, use another pr #1291 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] carbondata pull request #1239: [CARBONDATA-1343] Hive can't query data when ...

2017-08-27 Thread cenyuhai
Github user cenyuhai closed the pull request at: https://github.com/apache/carbondata/pull/1239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] carbondata pull request #1291: [CARBONDATA-1343] Hive can't query data when ...

2017-08-27 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1291 [CARBONDATA-1343] Hive can't query data when the carbon table info is store in hive metastore add tableInfo to CarbonHiveInputSplit and no need to get schema from file in map process. You

[GitHub] carbondata issue #1239: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-27 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1239 @anubhav100 hive example is ok because #1231 is merged. But this exception still exists. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] carbondata issue #1239: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-26 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1239 @anubhav100 I try the latest master, it still throws exception. {code} java.io.IOException: File does not exist: hdfs://bipcluster/user/master/carbon/store/temp/yuhai_carbon/Metadata

[GitHub] carbondata issue #1239: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-26 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1239 @anubhav100 It is a sad story --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1255: [CARBONDATA-1375] clean hive pom

2017-08-26 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1255 retest please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata pull request #1255: [CARBONDATA-1375] clean hive pom

2017-08-21 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1255#discussion_r134194865 --- Diff: integration/hive/pom.xml --- @@ -36,122 +36,96 @@ -org.apache.hive -hive-exec

[GitHub] carbondata issue #1255: [CARBONDATA-1375] clean hive pom

2017-08-16 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1255 1.use hadoop.version instead of 2.6.0 2.use hive.version instead of 1.2.1 3.remove thrift 4.remove zookeeper 5.remove spark-hive and spark-sql --- If your project is set up

[GitHub] carbondata issue #1255: [CARBONDATA-1375] clean hive pom

2017-08-13 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1255 retest please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1239: [CARBONDATA-1343] Hive can't query data when the car...

2017-08-13 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1239 retest please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1005: [CARBONDATA-1139] Added testcases for CarbonHiveReco...

2017-08-13 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1005 Is Shivangi and anubhav100 your colleagues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata pull request #1005: [CARBONDATA-1139] Added testcases for CarbonH...

2017-08-13 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1005#discussion_r132841101 --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonHiveRecordReader.java --- @@ -0,0 +1,687 @@ +/* + * Licensed

[GitHub] carbondata pull request #1005: [CARBONDATA-1139] Added testcases for CarbonH...

2017-08-13 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1005#discussion_r132841087 --- Diff: integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonHiveRecordReader.java --- @@ -0,0 +1,687 @@ +/* + * Licensed

[GitHub] carbondata pull request #1255: [CARBONDATA-1375] clean hive pom

2017-08-13 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1255 [CARBONDATA-1375] clean hive pom clean hive pom You can merge this pull request into a Git repository by running: $ git pull https://github.com/cenyuhai/incubator-carbondata CARBONDATA

[GitHub] carbondata pull request #1239: [CARBONDATA-1343] Hive can't query data when ...

2017-08-11 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1239#discussion_r132695250 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -84,47 +92,66 @@ * @param

[GitHub] carbondata pull request #1239: [CARBONDATA-1343] Hive can't query data when ...

2017-08-11 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1239#discussion_r132691664 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -84,47 +92,66 @@ * @param

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-09 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1239: [CARBONDATA-1338] add tableInfo to CarbonHiveInputSp...

2017-08-06 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1239 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-06 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1231 @anubhav100 you are right, I also encounter your problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-05 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1231 can you try this pr: https://github.com/apache/carbondata/pull/1239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] carbondata pull request #1239: [CARBONDATA-1338] add tableInfo to CarbonHive...

2017-08-05 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1239 [CARBONDATA-1338] add tableInfo to CarbonHiveInputSplit and no need to get schema from file add tableInfo to CarbonHiveInputSplit and no need to get schema from file in map process. You can

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-05 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1231: [CARBONDATA-1359] Unable to use carbondata on hive

2017-08-05 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1231 I am also woking on it. Not just this issue make hive unable to use, but also store tableinfo in hive metastore --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-05 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-04 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-03 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 @chenliang613 why it will failed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-03 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-02 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 yes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-02 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-02 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 You can try what will happen after you create the table in spark with or without the listener. And then use this comand "desc table1" to see the difference --- If your project

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-08-02 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 @chenliang613 just do as the hive-guild.md said --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata pull request #1214: [CARBONDATA-1008] use MetastoreListener to sy...

2017-08-01 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1214#discussion_r130773318 --- Diff: integration/hive/pom.xml --- @@ -136,6 +142,12 @@ org.apache.carbondata carbondata-hadoop

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-07-30 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 @chenliang613 @jackylk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-07-30 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] carbondata issue #1214: [CARBONDATA-1008] use MetastoreListener to sync sche...

2017-07-30 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1214 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Carbon table schema compatible...

2017-07-30 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/984 I open another pr https://github.com/apache/carbondata/pull/1214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] carbondata pull request #1214: [CARBONDATA-1008] use MetastoreListener to sy...

2017-07-30 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1214 [CARBONDATA-1008] use MetastoreListener to sync schema between spark and hive use MetastoreListener to sync schema between spark and hive You can merge this pull request into a Git

[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Carbon table schema compatible...

2017-07-29 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/984 I will try to handle it by MetaStoreEventListener --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Carbon table schema compatible...

2017-07-29 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/984 @ravipesala if I create table by hive, spark can't read table‘s cols, because spark read cols in TBLPROPERTIES 'spark.sql.sources.schema.part', the cols are empty. It is hard to construct

[GitHub] carbondata issue #1210: [CARBONDATA-1338] deserialized tableInfo at executor...

2017-07-29 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1210 can you merge this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #1210: [CARBONDATA-1338] deserialized tableInfo at executor...

2017-07-29 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1210 @chenliang613 @QiangCai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata pull request #1210: [CARBONDATA-1338] deserialized tableInfo at e...

2017-07-29 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1210 [CARBONDATA-1338] deserialized tableInfo at executor side deserialized TableInfo at executor side You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] carbondata issue #1210: [CARBONDATA-1338] deserialized tableInfo at executor...

2017-07-29 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1210 ok, to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Carbon table schema compatible...

2017-07-25 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/984 @ravipesala ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Carbon table schema compatible...

2017-07-15 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/984 @anubhav100 I will open an issue later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Carbon table schema compatible...

2017-07-15 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/984 If it is ok, please merge to master. I find bugs in the latest code. The result is wrong when I execute "select * from carbon_hive_table" --- If your project is set up for it, you

[GitHub] carbondata pull request #1126: [CARBONDATA-1258] CarbonData should not allow...

2017-07-14 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1126#discussion_r127450363 --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/DateDirectDictionaryGenerator.java --- @@ -154,6

[GitHub] carbondata pull request #984: [CARBONDATA-1008] Make Carbon table schema com...

2017-07-14 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/984#discussion_r127447781 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -189,10 +189,52 @@ case class

[GitHub] carbondata pull request #984: [CARBONDATA-1008] Make Caron table schema comp...

2017-07-10 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/984#discussion_r126469617 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -195,11 +195,43 @@ case class

[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Caron table schema compatible ...

2017-07-09 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/984 @chenliang613 can you review this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] carbondata issue #1142: [CARBONDATA-1271] Enhanced Performance for Hive Inte...

2017-07-09 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1142 Can you provide performance benchmark? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] carbondata pull request #984: [CARBONDATA-1008] Make Caron table schema comp...

2017-07-05 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/984#discussion_r125816477 --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java --- @@ -269,9 +270,9 @@ public ICarbonLock

[GitHub] carbondata pull request #984: [CARBONDATA-1008] Make Caron table schema comp...

2017-07-05 Thread cenyuhai
Github user cenyuhai commented on a diff in the pull request: https://github.com/apache/carbondata/pull/984#discussion_r125815870 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala --- @@ -438,11 +457,24 @@ private[sql

[GitHub] carbondata issue #1096: [WIP] test_spark2.1.1

2017-06-26 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/1096 Now, I use this command to compile carboncata "mvn clean package -DskipTests -Phadoop-2.7.2 -Pspark-2.1 -Dspark.version=2.1.1". it is ok. Why we should alter pom.xml? --- If yo

[GitHub] carbondata pull request #1017: [CARBONDATA-1105] support spark 2.1.1

2017-06-11 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/1017 [CARBONDATA-1105] support spark 2.1.1 support spark 2.1.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cenyuhai/incubator

[GitHub] carbondata pull request #984: [CARBONDATA-1008] Make Caron table schema comp...

2017-05-31 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/carbondata/pull/984 [CARBONDATA-1008] Make Caron table schema compatible with HIVE Make Caron table schema compatible with HIVE You can merge this pull request into a Git repository by running: $ git pull

[GitHub] carbondata issue #890: [CARBONDATA-1008] Make Caron table schema compatible ...

2017-05-24 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/890 ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] carbondata issue #890: [CARBONDATA-1008] Make Caron table schema compatible ...

2017-05-22 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/890 @anubhav100 can you try this pr? I am busy these days. set carbon.hive.schema.compatibility.enable=true in carbon.properties --- If your project is set up for it, you can reply to this email

[GitHub] carbondata issue #890: [CARBONDATA-1008] Make Caron table schema compatible ...

2017-05-19 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/890 why it will failed ? I test it in my mac, it is ok... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] carbondata issue #821: [CARBONDATA-921] resolved bug for unable to select ou...

2017-05-14 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/821 LGTM @QiangCai @chenliang613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] carbondata issue #890: [CARBONDATA-1008] Make Hive table schema compatible w...

2017-05-11 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/890 @anubhav100 It looks like I can't change the string type to int type. I will review your code [CARBONDATA-921] --- If your project is set up for it, you can reply to this email and have your

[GitHub] carbondata issue #890: [CARBONDATA-1008] Make Hive table schema compatible w...

2017-05-10 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/carbondata/pull/890 The test suite failed because of the carbon core module can't find the class in carbondata-hive module. I test in hive 2.1, I can't alter column type... Anyone can give a me some advise

[GitHub] incubator-carbondata pull request #890: [CARBONDATA-1008] Make Hive table sc...

2017-05-07 Thread cenyuhai
GitHub user cenyuhai opened a pull request: https://github.com/apache/incubator-carbondata/pull/890 [CARBONDATA-1008] Make Hive table schema compatible with spark sql Make Hive table schema compatible with spark sql You can merge this pull request into a Git repository by running

[GitHub] incubator-carbondata issue #839: [CARBONDATA-950] Resolved Bug for Class Cas...

2017-05-01 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/incubator-carbondata/pull/839 @QiangCai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #839: [CARBONDATA-950] Resolved Bug for Class Cas...

2017-05-01 Thread cenyuhai
Github user cenyuhai commented on the issue: https://github.com/apache/incubator-carbondata/pull/839 LGTM. @chenliang613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature