Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3065#discussion_r246996198
--- Diff: docs/presto-guide.md ---
@@ -220,7 +220,8 @@ Now you can use the Presto CLI on the coordinator to
query data sources in the c
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/3065
Optimize presto-guide
Some users made mistake: copy the assemble jar. Add more description to
clarify, need to copy many jars from
integration/presto/target/carbondata-presto-x.x.x
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3033
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3033
@sraghunandan please review it.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3021
@chandrasaripaka please let us know 3026 if solved your issues?
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3056
Reviewed, LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3054
the pr title is not consistent with pr content. how about : Add example
for alluxio integration
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3054#discussion_r245676210
--- Diff: README.md ---
@@ -68,8 +68,8 @@ CarbonData is built using Apache Maven, to [build
CarbonData](https://github.com
* [FAQs](https
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3036
LGTM, thanks for the good contributions.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3036
@runzhliu please correct the PR title.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3034
LGTM.
One small issue, for pr title, please add one "blank" after
[CARBONDATA-3126]
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3034
add to whitelist
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3030
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3019
remove CarbondataConnector.java in this pr by using hive connector. in
future, if consider contributing carbondata integraton to presto community,
how to handle ?
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3019#discussion_r244003542
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala
---
@@ -72,69 +74,107 @@ object
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3018
Can you please explain , why need to rename?
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/3021
@chandrasaripaka
As I know, spark 2.2.0 is not a stable version, it is better to consider
other more stable versions.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2890
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2978
For 1.5.2:
Whether can consider merging vector code to core module from presto
integration module for example CarbonVectorBatch, or not ?
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2981
@kunal642 please review it
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2978
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2954
@SteNicholas Thanks for your good contribution. can you squash all
commits to one commit
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2961
the pr title is not correct, the format should be : [JIRA NUMBER] PR
description
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2961
add to whitelist
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2963
Can consider writing an example:how to use MinMaxDataMap to build index for
CSV file.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2954
add to whitelist
---
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/2950
[Test PR] How to set PR labels
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2934
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2934
add to whitelist
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2890
LGTM
---
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/2838
[HOTFIX] Upgrade pom version to 1.6-SNAPSHOT
Upgrade pom version to 1.6-SNAPSHOT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2802
please rebase it.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2810
add to whitelist
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2779
LGTM
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221444503
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2779
My comment : only for 4 parameters , copy the whole
file(CarbonDataSourceScan.scala) for spark 2.3 integration, may not require.
see if can add the judgement for different spark version
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221414692
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2779#discussion_r221131678
--- Diff:
integration/spark2/src/main/spark2.3/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
---
@@ -0,0 +1,55
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2777
same as #2779 , so close this pr.
---
Github user chenliang613 closed the pull request at:
https://github.com/apache/carbondata/pull/2777
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2779
retest this please
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2777#discussion_r221129765
--- Diff: pom.xml ---
@@ -608,13 +608,12 @@
spark-2.3
-2.3.1
+2.3.2
2.11
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/2777
[HOXFIX] Upgrade spark integration version to 2.3.2
1. Upgrade spark integration version to 2.3.2
2. Currently, hive integration module is not supported along with spark
2.3.2, so
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2733
https://user-images.githubusercontent.com/8075709/45723721-52736800-bbe5-11e8-853f-30f530156396.png;>
verified!
---
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/2733
[CARBONDATA-2818] Upgrade presto integration version to 0.210
As per the mailing list
discussion:http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/Discussion-Propose
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2607
LGTM, spark 2.3.1 CI is another issue.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2607
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2714
add to whitelist
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2691#discussion_r216216999
--- Diff: integration/spark-common-test/src/test/resources/cars.csv ---
@@ -0,0 +1,4 @@
+name,age
--- End diff --
can you reuse
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2638
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2695
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2693
LGTM
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2693#discussion_r215881276
--- Diff: docs/datamap-developer-guide.md ---
@@ -3,14 +3,28 @@
### Introduction
DataMap is a data structure that can be used
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2693#discussion_r215879697
--- Diff: docs/configuration-parameters.md ---
@@ -235,3 +235,16 @@ RESET
* Success will be recorded in the driver log.
* Failure
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2693#discussion_r215879237
--- Diff: docs/carbondata-architecture-design.md ---
@@ -0,0 +1,140 @@
+## Architecture
+
--- End diff --
Please remove
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2684
@qiuchenjian please update the pr's title, doesn't display completely.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2592
LGTM
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2683#discussion_r215669915
--- Diff: pom.xml ---
@@ -706,6 +706,12 @@
datamap/mv/core
+
+ tool
--- End diff
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2592#discussion_r215659429
--- Diff: docs/configuration-parameters.md ---
@@ -16,152 +16,135 @@
-->
# Configuring CarbonData
- This tutorial guides
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2592#discussion_r215655761
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -470,15 +447,6
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2686
same question as @zzcclp .
It is better to raise one discussion first on mailing list.
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
two comments :
1.In this example, suggest listing all typical cases which be supported
currently and put the performance comparison, how to improve the performance
after creating mv
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2614#discussion_r214526743
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/MVDataMapExample.scala
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2668
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2607
@bhavya411 any new progress ?
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2615
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2637
add to whitelist
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2636
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2636
add to whitelist
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2607
@bhavya411 I tested this pr, the performance(simple aggregation) not
getting any improvement(0.206 compare to 0.187)
Just i checked 0.207 and 0.208, there are fixed many memory
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2607
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2620
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2620
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2620
retest this please
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2620#discussion_r208780697
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CustomCompactionExample.scala
---
@@ -0,0 +1,69 @@
+package
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2620#discussion_r208780252
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CustomCompactionExample.scala
---
@@ -0,0 +1,69 @@
+package
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2620#discussion_r208780123
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CustomCompactionExample.scala
---
@@ -0,0 +1,69 @@
+package
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2620
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2590
LGTM
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2576
retest this please
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2590#discussion_r206553068
--- Diff: docs/data-management-on-carbondata.md ---
@@ -126,20 +126,33 @@ This tutorial is going to introduce all commands and
data operations
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2582
LGTM
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2568#discussion_r206490628
--- Diff: integration/presto/Presto-integration-in-carbondata.md ---
@@ -0,0 +1,132 @@
+
+
+# PRESTO INTEGRATION IN CARBONDATA
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2582#discussion_r206487262
--- Diff: docs/data-management-on-carbondata.md ---
@@ -284,6 +286,20 @@ This tutorial is going to introduce all commands and
data operations
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2590#discussion_r206486006
--- Diff: docs/data-management-on-carbondata.md ---
@@ -508,6 +511,9 @@ Users can specify which columns to include and exclude
for local
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2590#discussion_r206485782
--- Diff: docs/data-management-on-carbondata.md ---
@@ -126,20 +126,20 @@ This tutorial is going to introduce all commands and
data operations
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2590#discussion_r206485268
--- Diff: docs/data-management-on-carbondata.md ---
@@ -126,20 +126,20 @@ This tutorial is going to introduce all commands and
data operations
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2590#discussion_r206484679
--- Diff: docs/data-management-on-carbondata.md ---
@@ -126,20 +126,20 @@ This tutorial is going to introduce all commands and
data operations
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r206481821
--- Diff: docs/s3-guide.md ---
@@ -0,0 +1,63 @@
+
+
+#S3 Guide (Alpha Feature 1.4.1)
+Amazon S3 is a cloud storage service
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r206481369
--- Diff: docs/s3-guide.md ---
@@ -0,0 +1,63 @@
+
+
+#S3 Guide (Alpha Feature 1.4.1)
+Amazon S3 is a cloud storage service
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2576#discussion_r206480055
--- Diff: docs/datamap/preaggregate-datamap-guide.md ---
@@ -7,6 +24,7 @@
* [Querying Data](#querying-data)
* [Compaction](#compacting
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2576
retest this please
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2589
Can you explain "CTable" for what ?
---
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2589#discussion_r206458466
--- Diff: store/core/pom.xml ---
@@ -48,8 +48,8 @@
org.apache.maven.plugins
maven-compiler-plugin
1 - 100 of 780 matches
Mail list logo
