[GitHub] carbondata issue #3053: [CARBONDATA-3233]Fix JVM crash issue in snappy compr...

2019-01-09 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3053 @kumarvishal09 ...I agree with you that it is a functional issue and we need to merge it. My point was before merging we can do one load performance test to see if there is any

[GitHub] carbondata issue #3053: [CARBONDATA-3233]Fix JVM crash issue in snappy compr...

2019-01-09 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3053 @akashrn5 .I agree with @xuchuanyin before merging the PR it is better to get the PR tested for performance. We can observe 2 things during the benchmark test - performance

[GitHub] carbondata issue #3047: [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize...

2019-01-06 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3047 LGTM ---

[GitHub] carbondata issue #3044: [CARBONDATA-3149]Documentation for alter table colum...

2019-01-04 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3044 LGTM ---

[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...

2019-01-03 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r245224509 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,24 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...

2019-01-03 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r245224386 --- Diff: docs/ddl-of-carbondata.md --- @@ -47,7 +47,8 @@ CarbonData DDL statements are documented here,which includes: * [RENAME TABLE

[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...

2019-01-03 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r245224565 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,24 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata issue #3047: [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize...

2019-01-03 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3047 LGTM...can be merged once build passes ---

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244920921 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -46,9 +47,9 @@ object CarbonStore

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3047#discussion_r244922117 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -101,14 +102,23 @@ object CarbonStore

[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...

2019-01-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r244919178 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,28 @@ Users can specify which columns to include and exclude for local dictionary gene

[GitHub] carbondata pull request #3039: [CARBONDATA-3217] Optimize implicit filter ex...

2019-01-01 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3039#discussion_r244668804 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java --- @@ -0,0 +1,109

[GitHub] carbondata pull request #3039: [CARBONDATA-3217] Optimize implicit filter ex...

2019-01-01 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3039#discussion_r244668632 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java --- @@ -0,0 +1,109

[GitHub] carbondata pull request #3039: [WIP] Optimize implicit filter expression per...

2018-12-31 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/3039 [WIP] Optimize implicit filter expression performance by removing extra serialization Fixed performance issue for Implicit filter column 1. Removed serialization all the implicit

[GitHub] carbondata issue #3027: [CARBONDATA-3202]update the schema to session catalo...

2018-12-30 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3027 LGTM ---

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-28 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3027#discussion_r244306298 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata issue #3022: [CARBONDATA-3196] [CARBONDATA-3203]Fixed Compaction ...

2018-12-28 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3022 LGTM ---

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3027#discussion_r244271907 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3027#discussion_r244271865 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableAddColumnCommand.scala --- @@ -93,11

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3027#discussion_r244272092 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3027#discussion_r244271732 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableAddColumnCommand.scala --- @@ -93,11

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3027#discussion_r244270219 --- Diff: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonSessionState.scala --- @@ -105,47 +106,37 @@ class

[GitHub] carbondata pull request #3027: [CARBONDATA-3202]update the schema to session...

2018-12-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3027#discussion_r244270598 --- Diff: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/CarbonSessionUtil.scala --- @@ -93,4 +98,34 @@ object

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244085418 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244086878 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -699,4 +701,33 @@ public static

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244086110 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -356,9 +359,20 @@ public static

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244087077 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -699,4 +701,33 @@ public static

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244086909 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -699,4 +701,33 @@ public static

[GitHub] carbondata issue #2990: [CARBONDATA-3149]Support alter table column rename

2018-12-20 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2990 LGTM ---

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r243164028 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r243163786 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -1511,7 +1514,15 @@ abstract

[GitHub] carbondata issue #3002: [CARBONDATA-3182] Fixed SDV Testcase failures

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3002 LGTM ---

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242860813 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala --- @@ -171,11 +171,12

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242837854 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapSuite.scala --- @@ -641,7

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242870689 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala --- @@ -249,32 +249,99 @@ object AlterTableUtil

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242863058 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242861256 --- Diff: integration/spark2/src/main/commonTo2.2And2.3/org/apache/spark/sql/hive/SqlAstBuilderHelper.scala --- @@ -38,25 +37,27 @@ trait

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242870325 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala --- @@ -318,15 +322,27 @@ class

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242865160 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242871800 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala --- @@ -249,32 +249,99 @@ object AlterTableUtil

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242871412 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala --- @@ -249,32 +249,99 @@ object AlterTableUtil

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242837109 --- Diff: core/src/main/java/org/apache/carbondata/core/features/TableOperation.java --- @@ -21,7 +21,7 @@ ALTER_RENAME, ALTER_DROP

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242849005 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -1487,31 +1487,46 @@ abstract

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242870457 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonHiveMetaStore.scala --- @@ -199,11 +202,22 @@ class

[GitHub] carbondata pull request #2990: [CARBONDATA-3149]Support alter table column r...

2018-12-19 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2990#discussion_r242869441 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala

[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r242423291 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -94,10 +93,9

[GitHub] carbondata issue #2980: [CARBONDATA-3017] Map DDL Support

2018-12-14 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2980 LGTM ---

[GitHub] carbondata issue #2980: [CARBONDATA-3017] Map DDL Support

2018-12-14 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2980 @manishnalla1994 ...Please rebase and remove the commit for PR 2979 as it is already merged ---

[GitHub] carbondata issue #2980: [CARBONDATA-3017] Map DDL Support

2018-12-12 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2980 LGTM...check for test case failures if any and fix ---

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240886853 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -631,7 +620,9 @@ public void

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-11 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240886665 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -65,8 +65,7 @@ private

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240152242 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/parser/CarbonParserFactory.java --- @@ -51,23 +54,37 @@ public

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240126484 --- Diff: examples/spark2/src/main/resources/maptest2.csv --- @@ -0,0 +1,2 @@ +1\002Nalla\0012\002Singh\0011\002Gupta\0014\002Kumar +10

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240151744 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java --- @@ -119,6 +119,10

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240150644 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -188,11 +188,13

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240153125 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/parser/impl/RowParserImpl.java --- @@ -34,8 +37,12 @@ private

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240151175 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/DataLoadProcessBuilder.java --- @@ -222,8 +222,8 @@ public static

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240126217 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -338,12 +338,15 @@ public static

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240147303 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateDDLForComplexMapType.scala

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240145684 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -338,12 +338,15 @@ public static

[GitHub] carbondata pull request #2980: [CARBONDATA-3017] Map DDL Support

2018-12-10 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2980#discussion_r240151368 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java --- @@ -631,7 +651,7 @@ public void

[GitHub] carbondata issue #2968: [CARBONDATA-3141] Removed Carbon Table Detail Comman...

2018-12-04 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2968 LGTM ---

[GitHub] carbondata pull request #2940: [CARBONDATA-3116] Support set carbon.query.di...

2018-12-02 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2940#discussion_r238152763 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala

[GitHub] carbondata issue #2956: [CARBONDATA-3134] fixed null values when cachelevel ...

2018-11-28 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2956 LGTM ---

[GitHub] carbondata pull request #2956: [CARBONDATA-3134] fixed null values when cach...

2018-11-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2956#discussion_r236644573 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java --- @@ -332,13 +334,42 @@ public

[GitHub] carbondata pull request #2956: [CARBONDATA-3134] fixed null values when cach...

2018-11-27 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2956#discussion_r236646004 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java --- @@ -332,13 +334,42 @@ public

[GitHub] carbondata issue #2923: [CARBONDATA-3101] Fixed dataload failure when a colu...

2018-11-22 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2923 LGTM ---

[GitHub] carbondata issue #2872: [CARBONDATA-3113] Fixed Local Dictionary Query Perfo...

2018-11-21 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2872 LGTM ---

[GitHub] carbondata issue #2863: [CARBONDATA-3112] Optimise decompressing while filli...

2018-11-20 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2863 LGTM ---

[GitHub] carbondata issue #2906: [CARBONDATA-3088][Compaction] support prefetch for c...

2018-11-20 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2906 LGTM ---

[GitHub] carbondata issue #2928: [CARBONDATA-3106] Written_by_APPNAME not serialized ...

2018-11-19 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2928 LGTM ---

[GitHub] carbondata pull request #2923: [CARBONDATA-3101] Fixed dataload failure when...

2018-11-18 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2923#discussion_r234499385 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition

[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code

2018-11-16 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2872 @kumarvishal09 ...In general, instead of passing the `ReusableDataBuffer` instance everwhere can we make this class singleton and create a `byte[]` pool and use the concept of object pool

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

2018-11-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2872#discussion_r234176956 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/MeasureColumnChunkReader.java --- @@ -56,13 +57,14

[GitHub] carbondata pull request #2872: [WIP] Added reusable buffer code

2018-11-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2872#discussion_r234201988 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/ZstdCompressor.java --- @@ -74,4 +74,16 @@ public long

[GitHub] carbondata issue #2918: [CARBONDATA-3098] Fix for negative exponents value g...

2018-11-14 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2918 LGTM ---

[GitHub] carbondata issue #2901: [CARBONDATA-3081] Fixed NPE for boolean type column ...

2018-11-13 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2901 LGTM ---

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-13 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2895 LGTM ---

[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...

2018-11-06 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 @ravipesala in this method we are passing the `List` . The list contains the segments file only from the new table. So only the new index files will be loaded and queried and the same

[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...

2018-11-06 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 @ravipesala ...which method exactly you are referring to?...In all `getDataMap` methods latest `carbonTable` object is passed.and used for fetching the dataMaps..there is only one

[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 retest this please ---

[GitHub] carbondata pull request #2902: [CARBONDATA-3083] Fixed data mismatch issue a...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2902#discussion_r231012403 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala --- @@ -772,12

[GitHub] carbondata pull request #2902: [CARBONDATA-3083] Fixed data mismatch issue a...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2902#discussion_r231016130 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java --- @@ -257,7 +265,13

[GitHub] carbondata pull request #2902: [CARBONDATA-3083] Fixed data mismatch issue a...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2902#discussion_r231014429 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/UpdateCarbonTableTestCase.scala --- @@ -772,12

[GitHub] carbondata issue #2901: [CARBONDATA-3081] Fixed NPE for boolean type column ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2901 LGTM...please check the CI failure ---

[GitHub] carbondata pull request #2902: [CARBONDATA-3083] Fixed data mismatch issue a...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2902#discussion_r231009938 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1734,7 +1734,7 @@ private

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2895 LGTM..can be merged once build is passed ---

[GitHub] carbondata pull request #2895: [HOTFIX] Fix NPE in spark, when same vector r...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2895#discussion_r230999455 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -61,10 +61,7

[GitHub] carbondata issue #2901: [CARBONDATA-3081] Fixed NPE for boolean type column ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2901 Add PR description ---

[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 retest this please ---

[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 @xuchuanyin ...yes this scenario will work fine. In case of dropping normal table it will go through CarbonSession flow and drop table command is already taking care of clearing

[GitHub] carbondata pull request #2901: [CARBONDATA-3081] Fixed NPE for boolean type ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2901#discussion_r230818772 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -171,13 +171,20 @@ public Object

[GitHub] carbondata pull request #2901: [CARBONDATA-3081] Fixed NPE for boolean type ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2901#discussion_r230816465 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1844,4 +1844,53 @@ public void testVectorReader

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2895 LGTM apart from a minor comment ---

[GitHub] carbondata pull request #2895: [HOTFIX] Fix NPE in spark, when same vector r...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2895#discussion_r230814030 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -61,10 +61,7

[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 retest this please ---

[GitHub] carbondata issue #2897: [CARBONDATA-3080] Supporting local dictionary enable...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2897 @BJangir ...please go through the discussion and then decide whether for SDK be default we should enable local dictionary or not. We can further discuss on it based on your view http

[GitHub] carbondata issue #2898: [CARBONDATA-3077] Fixed query failure in fileformat ...

2018-11-05 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2898 @xuchuanyin ...your point is correct. To explain this in detail 1. We have already a way to clear the cached DataMaps through API call `DataMapStoreManager.getInstance().clearDataMaps

[GitHub] carbondata pull request #2898: [WIP] Fixed query failure in fileformat due s...

2018-11-05 Thread manishgupta88
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2898 [WIP] Fixed query failure in fileformat due stale cache issue **Problem** While using FileFormat API, if a table created, dropped and then recreated with the same name the query

[GitHub] carbondata issue #2869: [CARBONDATA-3057] Implement VectorizedReader for SDK...

2018-11-04 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2869 LGTM ---

  1   2   3   4   5   6   7   8   >