[GitHub] carbondata pull request #2588: [CARBONDATA-2807] Fixed data load performance...

2018-08-07 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2588#discussion_r208199760 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java --- @@ -111,18

[GitHub] carbondata pull request #2588: [CARBONDATA-2807] Fixed data load performance...

2018-08-07 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2588#discussion_r208199601 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java --- @@ -111,18

[GitHub] carbondata pull request #2588: [CARBONDATA-2807] Fixed data load performance...

2018-08-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2588#discussion_r207162716 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java --- @@ -111,18

[GitHub] carbondata pull request #2571: [CARBONDATA-2792][schema restructure] Create ...

2018-07-31 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2571#discussion_r206525134 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -87,18 +88,20 @@ object

[GitHub] carbondata pull request #2571: [CARBONDATA-2792][schema restructure] Create ...

2018-07-31 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2571#discussion_r206503427 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala --- @@ -87,18 +88,20 @@ object

[GitHub] carbondata pull request #2571: [CARBONDATA-2792][schema restructure] Create ...

2018-07-31 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2571#discussion_r206425523 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateExternalTable.scala

[GitHub] carbondata issue #2571: [CARBONDATA-2792][schema restructure] Create externa...

2018-07-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2571 retest sdv please ---

[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...

2018-07-27 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2517#discussion_r205752516 --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java --- @@ -724,6 +724,7 @@ public void

[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure

2018-07-27 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2553 retest this please ---

[GitHub] carbondata pull request #2571: [CARBONDATA-2792][schema restructure] Create ...

2018-07-27 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2571 [CARBONDATA-2792][schema restructure] Create external table fails post schema restructure. … Be sure to do all of the following checklist to help us incorporate your

[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...

2018-07-26 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2517 retest sdv please ---

[GitHub] carbondata issue #2553: [HOTFIX] Fixed random test failure

2018-07-25 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2553 retest this please ---

[GitHub] carbondata pull request #2553: [HOTFIX] Fixed random test failure

2018-07-25 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2553 [HOTFIX] Fixed random test failure Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [X] Any interfaces

[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...

2018-07-24 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2517#discussion_r204685081 --- Diff: core/src/main/java/org/apache/carbondata/core/fileoperations/AtomicFileOperationsImpl.java --- @@ -70,12 +78,20 @@ public

[GitHub] carbondata issue #2387: [CARBONDATA-2621][BloomDataMap] Lock problem in inde...

2018-07-23 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2387 retest this please ---

[GitHub] carbondata issue #2387: [CARBONDATA-2621][BloomDataMap] Lock problem in inde...

2018-07-23 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2387 Failled test case for the below build is unrelated and random. Checked locally its passing. http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6136/ ---

[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...

2018-07-23 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2517 retest sdv please ---

[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...

2018-07-20 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2517#discussion_r203957912 --- Diff: core/src/main/java/org/apache/carbondata/core/fileoperations/AtomicFileOperationsImpl.java --- @@ -70,12 +78,20 @@ public

[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...

2018-07-18 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2517 The failled test case is unrelated and random. SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5903/ ---

[GitHub] carbondata issue #2387: [CARBONDATA-2621][BloomDataMap] Lock problem in inde...

2018-07-18 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2387 Failled test case for the below build is unrelated. The same testcase is passing locally. http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7258/ ---

[GitHub] carbondata issue #2387: [CARBONDATA-2621][BloomDataMap] Lock problem in inde...

2018-07-17 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2387 retest SDV please ---

[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...

2018-07-17 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2517 retest SDV please ---

[GitHub] carbondata issue #2466: [CARBONDATA-2710][Spark Integration] Refactor Carbon...

2018-07-17 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2466 retest SDV please ---

[GitHub] carbondata issue #2466: [CARBONDATA-2710][Spark Integration] Refactor Carbon...

2018-07-17 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2466 Failled test case for the below build is unrelated. The same testcase is passing locally. http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7247/ ---

[GitHub] carbondata pull request #2517: [CARBONDATA-2749][dataload] In HDFS Empty tab...

2018-07-17 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2517 [CARBONDATA-2749][dataload] In HDFS Empty tablestatus file is written during datalaod, iud or compaction when disk is full. … Be sure to do all of the following

[GitHub] carbondata issue #2466: [CARBONDATA-2710][Spark Integration] Refactor Carbon...

2018-07-15 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2466 retest this please ---

[GitHub] carbondata pull request #2498: [CARBONDATA-2729][file-format] Schema Compati...

2018-07-12 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2498 [CARBONDATA-2729][file-format] Schema Compatibility problem between version 1.3.0 and 1.4.0 **Problem**: In TableSchema the field Name schemaEvaluation is changed

[GitHub] carbondata issue #2466: [WIP][CARBONDATA-2710][Spark Integration] Refactor C...

2018-07-10 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2466 retest SDV please ---

[GitHub] carbondata issue #2387: [CARBONDATA-2621][BloomDataMap] Lock problem in inde...

2018-07-09 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2387 retest this please ---

[GitHub] carbondata pull request #2466: [WIP][CARBONDATA-2710][Spark Integration] Ref...

2018-07-09 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2466 [WIP][CARBONDATA-2710][Spark Integration] Refactor CarbonSparkSqlParser for better code reuse. … Be sure to do all of the following checklist to help us incorporate

[GitHub] carbondata issue #2387: [CARBONDATA-2621][BloomDataMap] Lock problem in inde...

2018-07-03 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2387 retest this please ---

[GitHub] carbondata pull request #2429: [CARBONDATA-2674][Streaming]Streaming with me...

2018-07-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2429#discussion_r199685424 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -341,21 +343,32 @@ public CarbonTable

[GitHub] carbondata pull request #2429: [CARBONDATA-2674][Streaming]Streaming with me...

2018-07-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2429#discussion_r199685364 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -341,21 +343,32 @@ public CarbonTable

[GitHub] carbondata pull request #2429: [CARBONDATA-2674][Streaming]Streaming with me...

2018-07-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2429#discussion_r199685348 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java --- @@ -341,21 +343,32 @@ public CarbonTable

[GitHub] carbondata issue #2387: [CARBONDATA-2621][BloomDataMap] Lock problem in inde...

2018-07-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2387 retest this please ---

[GitHub] carbondata issue #2429: [CARBONDATA-2674][Streaming]Streaming with merge ind...

2018-06-29 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2429 retest this please ---

[GitHub] carbondata pull request #2429: [CARBONDATA-2674][Streaming]Streaming with me...

2018-06-29 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2429 [CARBONDATA-2674][Streaming]Streaming with merge index enabled does not consider the merge index file while pruning. … Be sure to do all of the following checklist

[GitHub] carbondata pull request #2389: [CARBONDATA-2623][DataMap] Add DataMap pre an...

2018-06-21 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2389#discussion_r197026107 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala --- @@ -272,6 +284,13 @@ class

[GitHub] carbondata pull request #2389: [CARBONDATA-2623][DataMap] Add DataMap pre an...

2018-06-21 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2389#discussion_r197025960 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala --- @@ -272,6 +284,13 @@ class

[GitHub] carbondata pull request #2387: [CARBONDATA-2621][BloomDataMap] Lock problem ...

2018-06-20 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2387#discussion_r197014465 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -1530,6 +1531,22 @@ public String

[GitHub] carbondata pull request #2389: [CARBONDATA-2623][DataMap] Add DataMap Pre an...

2018-06-20 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2389 [CARBONDATA-2623][DataMap] Add DataMap Pre and Pevent listener Added Pre and Post Execution Events for index datamap - [X] Any interfaces changed? None - [X] Any

[GitHub] carbondata pull request #2387: [CARBONDATA-2621][BloomDataMap] Lock problem ...

2018-06-20 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2387 [CARBONDATA-2621][BloomDataMap] Lock problem in index datamap Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily

[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...

2018-05-21 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1942 LGTM ---

[GitHub] carbondata issue #2014: [CARBONDATA-2198] Fixed bug for streaming data for b...

2018-05-21 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2014 LGTM ---

[GitHub] carbondata pull request #2263: [WIP] Refactored SegmentPropertiesFetcher to ...

2018-05-03 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2263 [WIP] Refactored SegmentPropertiesFetcher to resolve pruning problem post the carbon schema restructure. … Be sure to do all of the following checklist to help us

[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...

2018-05-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2243 Failled test is unrelated ---

[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...

2018-05-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2243 restricted parsed data display in the exception using parserSettings.setErrorContentLength(0) ---

[GitHub] carbondata pull request #2232: [CARBONDATA-2406][dataload]-Dictionary Server...

2018-05-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2232#discussion_r185411161 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/dictionary/server/SecureDictionaryServer.java --- @@ -63,7

[GitHub] carbondata issue #2243: [CARBONDATA-2410] Error message correction when colu...

2018-04-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2243 retest this please ---

[GitHub] carbondata pull request #2243: [CARBONDATA-2410] Error message correction wh...

2018-04-27 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2243 [CARBONDATA-2410] Error message correction when column value length exceeds 32 character The raw is displayed in the client, to avoid the same the exception message

[GitHub] carbondata pull request #2232: [CARBONDATA-2406][dataload]-Dictionary Server...

2018-04-26 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2232 [CARBONDATA-2406][dataload]-Dictionary Server and Dictionary Client MD5 Validation failed with hive.server2.enable.doAs = true With conf hive.server2.enable.doAs = true

[GitHub] carbondata pull request #2118: [CARBONDATA-2289] If carbon merge index is en...

2018-03-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan closed the pull request at: https://github.com/apache/carbondata/pull/2118 ---

[GitHub] carbondata pull request #2117: [CARBONDATA-2285] Spark integration code refa...

2018-03-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan closed the pull request at: https://github.com/apache/carbondata/pull/2117 ---

[GitHub] carbondata pull request #2118: [CARBONDATA-2289] If carbon merge index is en...

2018-03-30 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2118 [CARBONDATA-2289] If carbon merge index is enabled then after IUD ope… …ration if some blocks of a segment is deleted, then during query and IUD operation the driver is throwing

[GitHub] carbondata pull request #2117: [CARBONDATA-2285] Spark integration code refa...

2018-03-30 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2117 [CARBONDATA-2285] Spark integration code refactor Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [X] Any

[GitHub] carbondata pull request #71: [CARBONDATA-155] Code refactor to avoid the Typ...

2018-03-29 Thread mohammadshahidkhan
Github user mohammadshahidkhan closed the pull request at: https://github.com/apache/carbondata/pull/71 ---

[GitHub] carbondata pull request #2104: [CARBONDATA-2285] Spark integration code refa...

2018-03-29 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2104#discussion_r178051841 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/ICarbonSessionCatalog.scala --- @@ -0,0 +1,67

[GitHub] carbondata issue #2110: [CARBONDATA-2289] If carbon merge index is enabled t...

2018-03-28 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/2110 retest SDV please ---

[GitHub] carbondata pull request #2110: [CARBONDATA-2289] If carbon merge index is en...

2018-03-28 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2110 [CARBONDATA-2289] If carbon merge index is enabled then after IUD ope… …ration if some blocks of a segment is deleted, then during query and IUD operation the driver is throwing

[GitHub] carbondata pull request #2104: [CARBONDATA-2285] Spark integration code refa...

2018-03-27 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2104#discussion_r177426177 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/ICarbonSessionCatalog.scala --- @@ -0,0 +1,59

[GitHub] carbondata pull request #2104: [CARBONDATA-2285] Spark integration code refa...

2018-03-27 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2104#discussion_r177423796 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/ICarbonSessionCatalog.scala --- @@ -0,0 +1,59

[GitHub] carbondata pull request #2104: [CARBONDATA-2285] Spark integration code refa...

2018-03-27 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2104#discussion_r177416365 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1297,6 +1297,12 @@ public

[GitHub] carbondata pull request #2104: [CARBONDATA-2285] Spark integration code refa...

2018-03-26 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/2104 [CARBONDATA-2285] Spark integration code refactor Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [X] Any

[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...

2018-02-28 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1942 +1 The streaming issue is handled in PR #2014 ---

[GitHub] carbondata issue #1942: [CARBONDATA-2136] Fixed bug related to data load for...

2018-02-20 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1942 @geetikagupta16 Please handle the same issue in case of Stream Record writer as well. Currently there no test case for the bucketing flow to validate the issue handled

[GitHub] carbondata pull request #1942: [CARBONDATA-2136] Fixed bug related to data l...

2018-02-14 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1942#discussion_r168394055 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataConverterProcessorStepImpl.java --- @@ -100,10

[GitHub] carbondata pull request #1942: [CARBONDATA-2136] Fixed bug related to data l...

2018-02-14 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1942#discussion_r168395269 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataConverterProcessorStepImpl.java --- @@ -100,10

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-02-12 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1104 retest this please ---

[GitHub] carbondata issue #1831: [CARBONDATA-1993] Carbon properties default values f...

2018-02-03 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1831 retest this please ---

[GitHub] carbondata pull request #1831: [CARBONDATA-1993] Carbon properties default v...

2018-02-03 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1831#discussion_r165810447 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1264,18 +1231,7

[GitHub] carbondata issue #1831: [CARBONDATA-1993] Carbon properties default values f...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1831 retest SDV please ---

[GitHub] carbondata pull request #1104: [CARBONDATA-1239] Add validation for set comm...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1104#discussion_r165763372 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java --- @@ -307,17 +307,11 @@ public static

[GitHub] carbondata pull request #71: [CARBONDATA-155] Code refactor to avoid the Typ...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan closed the pull request at: https://github.com/apache/carbondata/pull/71 ---

[GitHub] carbondata pull request #71: [CARBONDATA-155] Code refactor to avoid the Typ...

2018-02-02 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan reopened a pull request: https://github.com/apache/carbondata/pull/71 [CARBONDATA-155] Code refactor to avoid the Type Casting in compareTo method … You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] carbondata pull request #1831: [CARBONDATA-1993] Carbon properties default v...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1831#discussion_r165743860 --- Diff: conf/carbon.properties.template --- @@ -17,29 +17,25 @@ # System Configuration

[GitHub] carbondata pull request #1831: [CARBONDATA-1993] Carbon properties default v...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1831#discussion_r165743651 --- Diff: conf/carbon.properties.template --- @@ -76,22 +72,16 @@ carbon.enable.quick.filter=false

[GitHub] carbondata pull request #1831: [CARBONDATA-1993] Carbon properties default v...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1831#discussion_r165743745 --- Diff: docs/configuration-parameters.md --- @@ -32,10 +32,10 @@ This section provides the details of all the configurations required

[GitHub] carbondata pull request #1831: [CARBONDATA-1993] Carbon properties default v...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1831#discussion_r165742856 --- Diff: conf/carbon.properties.template --- @@ -110,7 +100,7 @@ carbon.enable.quick.filter=false ##Percentage to identify whether

[GitHub] carbondata pull request #1831: [CARBONDATA-1993] Carbon properties default v...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1831#discussion_r165741342 --- Diff: conf/carbon.properties.template --- @@ -76,22 +72,16 @@ carbon.enable.quick.filter=false

[GitHub] carbondata issue #1834: [CARBONDATA-2056] Hadoop Configuration with access k...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1834 closing this PR as per @ravipesala this fix will be handled for all the I/O operation together with S3 support implementation ---

[GitHub] carbondata pull request #1834: [CARBONDATA-2056] Hadoop Configuration with a...

2018-02-02 Thread mohammadshahidkhan
Github user mohammadshahidkhan closed the pull request at: https://github.com/apache/carbondata/pull/1834 ---

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-02-01 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1104 retest this please ---

[GitHub] carbondata issue #1822: [CARBONDATA-2043] Configurable wait time for request...

2018-01-31 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1822 retest this please ---

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-01-31 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1104 retest this please ---

[GitHub] carbondata issue #1822: [CARBONDATA-2043] Configurable wait time for request...

2018-01-31 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1822 retest this please ---

[GitHub] carbondata issue #1822: [CARBONDATA-2043] Configurable wait time for request...

2018-01-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1822 retest SDV please ---

[GitHub] carbondata issue #1831: [CARBONDATA-1993] Carbon properties default values f...

2018-01-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1831 retest this please ---

[GitHub] carbondata issue #1834: [CARBONDATA-2056] Hadoop Configuration with access k...

2018-01-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1834 retest SDV please ---

[GitHub] carbondata issue #1834: [CARBONDATA-2056] Hadoop Configuration with access k...

2018-01-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1834 Failed test case is random ---

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-01-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1104 retest SDV please ---

[GitHub] carbondata issue #1831: [CARBONDATA-1993] Carbon properties default values f...

2018-01-30 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1831 retest this please ---

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-01-29 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1104 retest this please ---

[GitHub] carbondata issue #1834: [CARBONDATA-2056] Hadoop Configuration with access k...

2018-01-29 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1834 retest SDV please ---

[GitHub] carbondata pull request #1841: [CARBONDATA-2062] Configure the temp director...

2018-01-22 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1841#discussion_r163154276 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala --- @@ -941,4 +943,39 @@ object

[GitHub] carbondata issue #1104: [CARBONDATA-1239] Add validation for set command par...

2018-01-22 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1104 retest this please ---

[GitHub] carbondata issue #1828: [CARBONDATA-2049] CarbonCleanFilesCommand table path...

2018-01-22 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on the issue: https://github.com/apache/carbondata/pull/1828 retest sdv please ---

[GitHub] carbondata pull request #1834: [CARBONDATA-2056] Hadoop Configuration with a...

2018-01-18 Thread mohammadshahidkhan
GitHub user mohammadshahidkhan opened a pull request: https://github.com/apache/carbondata/pull/1834 [CARBONDATA-2056] Hadoop Configuration with access key and secret key should be passed while creating InputStream of distributed carbon file. … Be sure to do all

[GitHub] carbondata pull request #1828: [CARBONDATA-2049] CarbonCleanFilesCommand tab...

2018-01-18 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1828#discussion_r162357297 --- Diff: integration/spark2/src/main/scala/org/apache/spark/util/CleanFiles.scala --- @@ -33,15 +33,19 @@ object CleanFiles

[GitHub] carbondata pull request #1828: [CARBONDATA-2049] CarbonCleanFilesCommand tab...

2018-01-18 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1828#discussion_r162357455 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala --- @@ -98,34 +98,44 @@ object CarbonStore

[GitHub] carbondata pull request #1828: [CARBONDATA-2049] CarbonCleanFilesCommand tab...

2018-01-18 Thread mohammadshahidkhan
Github user mohammadshahidkhan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1828#discussion_r162357211 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonCleanFilesCommand.scala --- @@ -70,11

  1   2   3   >