[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent

2021-03-12 Thread GitBox 


Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-797352431


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent

2021-03-11 Thread GitBox 


Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-797199630


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent

2021-03-02 Thread GitBox 


Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-789482217


   @QiangCai i think you can refactor fireEevents in  SIRebuildSegmentRunner 
class



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent

2021-02-08 Thread GitBox 


Indhumathi27 commented on pull request #4078:
URL: https://github.com/apache/carbondata/pull/4078#issuecomment-775715984


   @QiangCai please rebase



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org