[GitHub] [carbondata] QiangCai commented on pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-12 Thread GitBox 


QiangCai commented on pull request #3924:
URL: https://github.com/apache/carbondata/pull/3924#issuecomment-707080395


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] QiangCai commented on pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-09 Thread GitBox 


QiangCai commented on pull request #3924:
URL: https://github.com/apache/carbondata/pull/3924#issuecomment-706004725


   I don't understand the advantage of this change.
   maybe we need to improve the use logic of both SI and the main index.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] QiangCai commented on pull request #3924: [CARBONDATA-3988] Allow SI creation on first dimension column

2020-10-08 Thread GitBox 


QiangCai commented on pull request #3924:
URL: https://github.com/apache/carbondata/pull/3924#issuecomment-706004725


   I don't understand the advantage of this change.
   maybe we need to improve the use logic of both SI and the main index.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org