[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3966: [CARBONDATA-4023] Create MV failed on table with geospatial index using carbonsession.

2020-10-09 Thread GitBox 


ShreelekhyaG commented on a change in pull request #3966:
URL: https://github.com/apache/carbondata/pull/3966#discussion_r501611619



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParserUtil.scala
##
@@ -562,8 +562,11 @@ object CarbonSparkSqlParserUtil {
* @return returns  if lower case conversion is needed else 
*/
   def needToConvertToLowerCase(key: String): Boolean = {
-val noConvertList = Array(CarbonCommonConstants.COMPRESSOR, "PATH", 
"bad_record_path",
+var noConvertList = Array(CarbonCommonConstants.COMPRESSOR, "PATH", 
"bad_record_path",
   "timestampformat", "dateformat")
+if (key.startsWith(CarbonCommonConstants.SPATIAL_INDEX) && 
key.endsWith("class")) {

Review comment:
   Done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #3966: [CARBONDATA-4023] Create MV failed on table with geospatial index using carbonsession.

2020-10-08 Thread GitBox 


ShreelekhyaG commented on a change in pull request #3966:
URL: https://github.com/apache/carbondata/pull/3966#discussion_r501611619



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParserUtil.scala
##
@@ -562,8 +562,11 @@ object CarbonSparkSqlParserUtil {
* @return returns  if lower case conversion is needed else 
*/
   def needToConvertToLowerCase(key: String): Boolean = {
-val noConvertList = Array(CarbonCommonConstants.COMPRESSOR, "PATH", 
"bad_record_path",
+var noConvertList = Array(CarbonCommonConstants.COMPRESSOR, "PATH", 
"bad_record_path",
   "timestampformat", "dateformat")
+if (key.startsWith(CarbonCommonConstants.SPATIAL_INDEX) && 
key.endsWith("class")) {

Review comment:
   Done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org