[GitHub] [carbondata] ajantha-bhat commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support
ajantha-bhat commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-674940989 @akkio-97 : Thanks for working on this. Based on the above comments (array design is not vectorized, fill vector need to be dissolved and keep it as original, interface need to have a default implementation, all the data types not handled, delta flows were not handled) **it will be very hard to stabilize this based on the current design**. **I have analyzed and reworked on the new design in #3887,** **I will add you as co-Author to the same.** **you can close this PR** and later raise PR for local dict support, multi level array & struct support and map support. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support
ajantha-bhat commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-669844507 @akkio-97 : update limitations and TODO clearly a. with local dictionary arrays cannot be read now b. arrays with other complex type is not supported yet I also feel arrayStreamRader and some interface need to cleaned up [I will do it with struct support] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support
ajantha-bhat commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-668138965 @akkio-97 : I think this doesn't work with local dictionary enable. Please test it with local dictionary enable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3773: [CARBONDATA-3830]Presto array columns read support
ajantha-bhat commented on pull request #3773: URL: https://github.com/apache/carbondata/pull/3773#issuecomment-667088775 @akkio-97 : please also do manual test with huge rows (millions). So that it can cover multiple pages This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
