[GitHub] carbondata pull request #1013: [CARBONDATA-1154] IUD Performance Changes
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/1013 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1013: [CARBONDATA-1154] IUD Performance Changes
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1013#discussion_r121572395 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -340,23 +340,37 @@ private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration List result = new LinkedList(); FilterExpressionProcessor filterExpressionProcessor = new FilterExpressionProcessor(); +UpdateVO invalidBlockVOForSegmentId = null; +Boolean IUDTable = false; --- End diff -- Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] carbondata pull request #1013: [CARBONDATA-1154] IUD Performance Changes
Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1013#discussion_r121572267
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/SegmentTaskIndexStore.java
---
@@ -184,22 +184,29 @@ private SegmentTaskIndexWrapper
loadAndGetTaskIdToSegmentsMap(
SegmentUpdateStatusManager updateStatusManager =
new SegmentUpdateStatusManager(absoluteTableIdentifier);
String segmentId = null;
+UpdateVO updateVO = null;
TaskBucketHolder taskBucketHolder = null;
try {
while (iteratorOverSegmentBlocksInfos.hasNext()) {
+// Initialize the UpdateVO to Null for each segment.
+updateVO = null;
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1013: [CARBONDATA-1154] IUD Performance Changes
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1013#discussion_r121486113 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java --- @@ -340,23 +340,37 @@ private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration List result = new LinkedList(); FilterExpressionProcessor filterExpressionProcessor = new FilterExpressionProcessor(); +UpdateVO invalidBlockVOForSegmentId = null; +Boolean IUDTable = false; --- End diff -- Use `isIUDTable` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
