[GitHub] carbondata pull request #2578: Fix Dictionary_Include for ComplexDataType

[kunal642]

Github user kunal642 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2578#discussion_r206396378
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java
 ---
@@ -236,7 +236,7 @@
   }
 }
 
-if (carbonLoadModel.isCarbonTransactionalTable() && 
!CarbonDataProcessorUtil
+if (hadoopConf != null && !CarbonDataProcessorUtil
--- End diff --

why hadoopConf null check is needed?


---

[GitHub] carbondata pull request #2578: Fix Dictionary_Include for ComplexDataType

[kunal642]

Github user kunal642 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2578#discussion_r206091924
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java
 ---
@@ -172,7 +191,7 @@ public void setSurrogateIndex(int surrIndex) {
 
   @Override
   public void fillCardinality(List dimCardWithComplex) {
-if (children.getIsColumnDictionary()) {
+if (this.isDictionaryColumn) {
--- End diff --

return isDictionaryColumn from getIsColumnDictionary() also.


---

[GitHub] carbondata pull request #2578: Fix Dictionary_Include for ComplexDataType

[Indhumathi27]

GitHub user Indhumathi27 opened a pull request:

https://github.com/apache/carbondata/pull/2578

Fix Dictionary_Include for ComplexDataType

Why this PR for?
Check if a column is given as Dictionary_Include and fill cardinality for 
that column
 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Indhumathi27/carbondata dict_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2578.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2578


commit bab79be62af7ffecb9dc1fcfe520fd0288c0281a
Author: Indhumathi27 
Date:   2018-07-30T08:48:44Z

Fix Dictionary_Include for ComplexDataType




---