[GitHub] carbondata pull request #2745: [CARBONDATA-2958] Compaction with CarbonPrope...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2745


---

[GitHub] carbondata pull request #2745: [CARBONDATA-2958] Compaction with CarbonPrope...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2745#discussion_r219496698
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java
 ---
@@ -289,6 +289,10 @@ private DimensionColumnPage 
decodeDimensionLegacy(DimensionRawColumnChunk rawCol
 int[] rlePage;
 int[] invertedIndexes = new int[0];
 int[] invertedIndexesReverse = new int[0];
+if (compressor == null) {
--- End diff --

Move this logic to 
CompressedDimChunkFileBasedPageLevelReaderV3.decodeColumnPage please refer 
CompressedDimensionChunkFileBasedReaderV3 .decodeColumnPage 


---

[GitHub] carbondata pull request #2745: [CARBONDATA-2958] Compaction with CarbonPrope...

[Indhumathi27]

GitHub user Indhumathi27 opened a pull request:

https://github.com/apache/carbondata/pull/2745

[CARBONDATA-2958] Compaction with CarbonProperty 
'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is 
null

**Problem:**
When CarbonProperty 'carbon.enable.page.level.reader.in.compaction' is 
enabled, compaction fails throwing Null Pointer Exception as compressor is Null
**Solution:**
Set compressor from pageMetaData
 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [x] Testing done
Test case added
  
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Indhumathi27/carbondata page_compaction

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2745


commit 1c0a6fc8435c582cefa00bcd8d6979e89f1d886d
Author: Indhumathi27 
Date:   2018-09-21T09:54:39Z

[CARBONDATA-2958] Compaction with CarbonProperty 
'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is 
null




---