[GitHub] ravipesala commented on issue #3068: [HOTFIX] Fixed NPE during query with Local Dictionary

2019-01-18 Thread GitBox
ravipesala commented on issue #3068: [HOTFIX] Fixed NPE during query with Local 
Dictionary
URL: https://github.com/apache/carbondata/pull/3068#issuecomment-455573538
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ravipesala commented on issue #3068: [HOTFIX] Fixed NPE during query with Local Dictionary

2019-01-16 Thread GitBox
ravipesala commented on issue #3068: [HOTFIX] Fixed NPE during query with Local 
Dictionary
URL: https://github.com/apache/carbondata/pull/3068#issuecomment-454802540
 
 
   > @ravipesala I remember if the local dictionary value count reach 
threshold, it will fallback to original value, right?
   > what level does it fallback? blocklet, page or block ?
   
   The fallback is at page level.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services