[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-17 Thread GitBox 


Indhumathi27 commented on a change in pull request #3885:
URL: https://github.com/apache/carbondata/pull/3885#discussion_r471912427



##
File path: 
integration/presto/src/main/prestodb/org/apache/carbondata/presto/impl/CarbonTableReader.java
##
@@ -281,7 +287,11 @@ private CarbonTableCacheModel 
getValidCacheBySchemaTableName(SchemaTableName sch
   createInputFormat(jobConf, carbonTable.getAbsoluteTableIdentifier(),
   new IndexFilter(carbonTable, filters, true), filteredPartitions);
   Job job = Job.getInstance(jobConf);
+  CarbonProperties.getInstance()
+  .addProperty(CarbonCommonConstants.IS_QUERY_FROM_PRESTO, "true");

Review comment:
   i think we can add only in connector classes. Moved to carbonDataModule. 
Please check if it is ok @ajantha-bhat @kunal642 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-12 Thread GitBox 


Indhumathi27 commented on a change in pull request #3885:
URL: https://github.com/apache/carbondata/pull/3885#discussion_r469307444



##
File path: 
integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexJobs.scala
##
@@ -55,14 +57,27 @@ class DistributedIndexJob extends AbstractIndexJob {
 val (response, time) = logTime {
   try {
 val spark = SparkSQLUtil.getSparkSession
-indexFormat.setTaskGroupId(SparkSQLUtil.getTaskGroupId(spark))
-indexFormat.setTaskGroupDesc(SparkSQLUtil.getTaskGroupDesc(spark))
+// In case of presto with index server flow, sparksession will be null
+if (null != spark) {

Review comment:
   handled





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3885: [CARBONDATA-3946] Support IndexServer with Presto Engine

2020-08-11 Thread GitBox 


Indhumathi27 commented on a change in pull request #3885:
URL: https://github.com/apache/carbondata/pull/3885#discussion_r468518151



##
File path: 
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonLocalInputSplit.java
##
@@ -127,7 +128,8 @@ public CarbonLocalInputSplit(@JsonProperty("segmentId") 
String segmentId,
   @JsonProperty("deleteDeltaFiles") String[] deleteDeltaFiles,
   @JsonProperty("blockletId") String blockletId,
   @JsonProperty("detailInfo") String detailInfo,
-  @JsonProperty("fileFormatOrdinal") int fileFormatOrdinal) {
+  @JsonProperty("fileFormatOrdinal") int fileFormatOrdinal,
+  boolean isDistributedPruningEnabled) {

Review comment:
   done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org