[GitHub] [carbondata] Pickupolddriver commented on a change in pull request #3611: [CARBONDATA-3692] Support NoneCompression during loading data.

2020-02-15 Thread GitBox 
Pickupolddriver commented on a change in pull request #3611: [CARBONDATA-3692] 
Support NoneCompression during loading data.
URL: https://github.com/apache/carbondata/pull/3611#discussion_r379815554
 
 

 ##
 File path: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
 ##
 @@ -272,6 +272,79 @@ class TestLoadDataWithCompression extends QueryTest with 
BeforeAndAfterEach with
 }
   }
 
+  test("test current none compressor on legacy store with snappy") {
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
 "true")
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR, 
"snappy")
+createTable()
+loadData()
+
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
 "true")
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR, 
"none")
+loadData()
+checkAnswer(sql(s"SELECT count(*) FROM $tableName"), Seq(Row(16)))
 
 Review comment:
   So you want to change all the test cases in this class from select count(*) 
to *? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [carbondata] Pickupolddriver commented on a change in pull request #3611: [CARBONDATA-3692] Support NoneCompression during loading data.

2020-02-14 Thread GitBox 
Pickupolddriver commented on a change in pull request #3611: [CARBONDATA-3692] 
Support NoneCompression during loading data.
URL: https://github.com/apache/carbondata/pull/3611#discussion_r379335042
 
 

 ##
 File path: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
 ##
 @@ -272,6 +272,79 @@ class TestLoadDataWithCompression extends QueryTest with 
BeforeAndAfterEach with
 }
   }
 
+  test("test current none compressor on legacy store with snappy") {
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
 "true")
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR, 
"snappy")
+createTable()
+loadData()
+
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
 "true")
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR, 
"none")
+loadData()
+checkAnswer(sql(s"SELECT count(*) FROM $tableName"), Seq(Row(16)))
 
 Review comment:
   Sure


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [carbondata] Pickupolddriver commented on a change in pull request #3611: [CARBONDATA-3692] Support NoneCompression during loading data.

2020-02-14 Thread GitBox 
Pickupolddriver commented on a change in pull request #3611: [CARBONDATA-3692] 
Support NoneCompression during loading data.
URL: https://github.com/apache/carbondata/pull/3611#discussion_r379335042
 
 

 ##
 File path: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataWithCompression.scala
 ##
 @@ -272,6 +272,79 @@ class TestLoadDataWithCompression extends QueryTest with 
BeforeAndAfterEach with
 }
   }
 
+  test("test current none compressor on legacy store with snappy") {
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
 "true")
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR, 
"snappy")
+createTable()
+loadData()
+
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
 "true")
+
CarbonProperties.getInstance().addProperty(CarbonCommonConstants.COMPRESSOR, 
"none")
+loadData()
+checkAnswer(sql(s"SELECT count(*) FROM $tableName"), Seq(Row(16)))
 
 Review comment:
   Sure


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services