[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-23 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r510813895 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -139,7 +139,7 @@

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-23 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r510810713 ## File path: integration/presto/src/test/prestosql/org/apache/carbondata/presto/server/PrestoTestUtil.scala ## @@ -114,4 +114,60 @@ object

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-23 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r510810498 ## File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/readers/ComplexTypeStreamReader.java ## @@ -139,7 +139,7 @@

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-21 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r509009526 ## File path: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java ## @@ -156,6 +159,14 @@ public

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-21 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r509008562 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala ## @@

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r509008144 ## File path: integration/presto/src/test/prestodb/org/apache/carbondata/presto/server/PrestoTestUtil.scala ## @@ -114,4 +114,60 @@ object

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r509004845 ## File path: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java ## @@ -81,6 +82,8 @@

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r509004084 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java ## @@ -325,6 +327,21 @@

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r509002285 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java ## @@ -64,6 +66,14

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3987: [CARBONDATA-4039] Support Local dictionary for Presto complex datatypes

2020-10-20 Thread GitBox
ajantha-bhat commented on a change in pull request #3987: URL: https://github.com/apache/carbondata/pull/3987#discussion_r509001513 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/DimensionChunkReaderV3.java ## @@ -296,6 +297,12