[GitHub] [carbondata] ajantha-bhat commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-21 Thread GitBox 


ajantha-bhat commented on pull request #3950:
URL: https://github.com/apache/carbondata/pull/3950#issuecomment-713528503


   Merging it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] ajantha-bhat commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-21 Thread GitBox 


ajantha-bhat commented on pull request #3950:
URL: https://github.com/apache/carbondata/pull/3950#issuecomment-713526336


   ok, I verified it as latest build. As people are restarting CI for checking 
random failures, report is not coming here.
   
   ![Screenshot from 2020-10-21 
17-44-17](https://user-images.githubusercontent.com/5889404/96718156-37c3dc80-13c5-11eb-8baa-3ec51ad21970.png)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] ajantha-bhat commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-21 Thread GitBox 


ajantha-bhat commented on pull request #3950:
URL: https://github.com/apache/carbondata/pull/3950#issuecomment-713521651


   LGTM.
   
   Appreciate your concern on clean code and making code more readable and 
maintainable !!
   
   I will merge once 2.3 build is passed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] ajantha-bhat commented on pull request #3950: [CARBONDATA-3889] Enable scalastyle check for all scala test code

2020-10-18 Thread GitBox 


ajantha-bhat commented on pull request #3950:
URL: https://github.com/apache/carbondata/pull/3950#issuecomment-711561462


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org