[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3807: [HOTFIX] Fix module problems of mv and spark with spark binary version

2020-11-11 Thread GitBox 


ajantha-bhat edited a comment on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-725813922


   > How will an external application specify spark version if they add 
carbondata-spark dependency?
   
   @kunal642 : Yeah, it cannot be added. Now only benefit from this change is 
jar name is proper. I will move to WIP and check if I get any other solution.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] ajantha-bhat edited a comment on pull request #3807: [HOTFIX] Fix module problems of mv and spark with spark binary version

2020-07-16 Thread GitBox 


ajantha-bhat edited a comment on pull request #3807:
URL: https://github.com/apache/carbondata/pull/3807#issuecomment-659305724


   @QiangCai : Developer should not manually modify pom to make it work for 
spark2.4.
   After this PR both 2.4 and 2.5 works without any manual change and jar names 
also will have binary version.
   
   so I fixed like above. 
   
   But some testcase failed to find CSV file after this change. so, I stopped 
it. Need to analyze why CSV files unable to find because of my change.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org