[GitHub] [carbondata] akashrn5 commented on a change in pull request #3879: [CARBONDATA-3943] Handling the addition of geo column to hive at the time of table creation.

2020-08-17 Thread GitBox 


akashrn5 commented on a change in pull request #3879:
URL: https://github.com/apache/carbondata/pull/3879#discussion_r471903933



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/CarbonSource.scala
##
@@ -281,10 +281,22 @@ object CarbonSource {
   isExternal)
 val updatedFormat = CarbonToSparkAdapter
   .getUpdatedStorageFormat(storageFormat, updatedTableProperties, 
tableInfo.getTablePath)

Review comment:
   if its handled, may be in `GeoTableExampleWithCarbonSession.scala` 
please add some validations just to check if the geo hash column is added in 
schema for the hive table.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3879: [CARBONDATA-3943] Handling the addition of geo column to hive at the time of table creation.

2020-08-17 Thread GitBox 


akashrn5 commented on a change in pull request #3879:
URL: https://github.com/apache/carbondata/pull/3879#discussion_r471902010



##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/CarbonSource.scala
##
@@ -281,10 +281,22 @@ object CarbonSource {
   isExternal)
 val updatedFormat = CarbonToSparkAdapter
   .getUpdatedStorageFormat(storageFormat, updatedTableProperties, 
tableInfo.getTablePath)

Review comment:
   here i can see the handking for `createCatalogTableForCarbonExtension` 
only, is it handled for `createCatalogTableForCarbonSession`?

##
File path: 
integration/spark/src/main/scala/org/apache/spark/sql/CarbonSource.scala
##
@@ -281,10 +281,22 @@ object CarbonSource {
   isExternal)
 val updatedFormat = CarbonToSparkAdapter
   .getUpdatedStorageFormat(storageFormat, updatedTableProperties, 
tableInfo.getTablePath)

Review comment:
   here i can see the handling for `createCatalogTableForCarbonExtension` 
only, is it handled for `createCatalogTableForCarbonSession`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org