[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-02-05 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r569996310 ## File path: docs/mv-guide.md ## @@ -1,3 +1,4 @@ + Review comment: remove this empty line change ## File path: docs/mv-guide.md

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-02-03 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r569996744 ## File path: docs/mv-guide.md ## @@ -241,6 +242,11 @@ The current information includes: | Refresh Mode | FULL / INCREMENTAL refresh to MV

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-02-03 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r569996310 ## File path: docs/mv-guide.md ## @@ -1,3 +1,4 @@ + Review comment: remove this empty line change

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-02-02 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r568501151 ## File path: docs/mv-guide.md ## @@ -241,6 +242,10 @@ The current information includes: | Refresh Mode | FULL / INCREMENTAL refresh to MV

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-02-02 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r568501151 ## File path: docs/mv-guide.md ## @@ -241,6 +242,10 @@ The current information includes: | Refresh Mode | FULL / INCREMENTAL refresh to MV

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

2021-01-26 Thread GitBox
akashrn5 commented on a change in pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#discussion_r565042150 ## File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ## @@ -1222,6 +1222,11 @@ private