[GitHub] [carbondata] akashrn5 commented on pull request #3786: [CARBONDATA-3842] Fix incorrect results on mv with limit (Missed code during mv refcatory)

2020-07-09 Thread GitBox 


akashrn5 commented on pull request #3786:
URL: https://github.com/apache/carbondata/pull/3786#issuecomment-655974118


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on pull request #3786: [CARBONDATA-3842] Fix incorrect results on mv with limit (Missed code during mv refcatory)

2020-07-08 Thread GitBox 


akashrn5 commented on pull request #3786:
URL: https://github.com/apache/carbondata/pull/3786#issuecomment-655912151


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on pull request #3786: [CARBONDATA-3842] Fix incorrect results on mv with limit (Missed code during mv refcatory)

2020-07-07 Thread GitBox 


akashrn5 commented on pull request #3786:
URL: https://github.com/apache/carbondata/pull/3786#issuecomment-654788035


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] akashrn5 commented on pull request #3786: [CARBONDATA-3842] Fix incorrect results on mv with limit (Missed code during mv refcatory)

2020-06-15 Thread GitBox 


akashrn5 commented on pull request #3786:
URL: https://github.com/apache/carbondata/pull/3786#issuecomment-643985798


   @Indhumathi27 why the test cases didnt catch this. If we do not have test 
cases, please add a test case for the limit case.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org