[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470463 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470537 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470422 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387470463 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ## @@

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387469426 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/compression/Compressor.java ##

[GitHub] [carbondata] jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer

2020-03-03 Thread GitBox
jackylk commented on a change in pull request #3638: [CARBONDATA-3731] Avoid data copy in Writer URL: https://github.com/apache/carbondata/pull/3638#discussion_r387469248 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/compression/AbstractCompressor.java