[GitHub] [carbondata] kevinjmh commented on a change in pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-30 Thread GitBox
kevinjmh commented on a change in pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#discussion_r462763715 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java ## @@ -722,15 +719,11 @@ public int

[GitHub] [carbondata] kevinjmh commented on a change in pull request #3868: [CARBONDATA-3889] Cleanup code in carbondata-core module

2020-07-29 Thread GitBox
kevinjmh commented on a change in pull request #3868: URL: https://github.com/apache/carbondata/pull/3868#discussion_r461986247 ## File path: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java ## @@ -283,8 +283,8 @@ public BigDecimal