[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700407129


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700109547


   > if alter column change nothing, the command should return directly without 
execution.
   
   I have modified code according to you suggestion.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment

2020-09-28 Thread GitBox


marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699854890


   > 1. do we support alter column without any change?
   > 2. how to remove comment from column
   
   1. now, we support alter column without any change.
   2. now. we don't support remove comment.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org