[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
LGTM


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6423/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/5355/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6417/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5252/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
retest this please


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6413/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5247/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
retest this please


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
rebased


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
@xuchuanyin Please rebase


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
created a jira CARBONDATA-2613 to do this automatically


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/5344/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5233/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-20 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6399/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
@kumarvishal09 If the string is too long, the user have to adjust the page 
size manually. We cannot do it dynamic for now.


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
@xuchuanyin then number of rows will depend on number of character in long 
string columns right?


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
@kumarvishal09 I asked someone who has the longstring requirement and get 
the response that the length of string is about 100K.
Since we don't want to change the internal implementation of column page, 
decreasing the row number in a page may be the only way to solve the problem.


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
@xuchuanyin I think better to restrict based on number of bytes 67104 for 
each column value, as user may not know how many character will be present , so 
its hard for the user to configure blocklet size. 


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5215/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6380/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/5321/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
retest this please


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
retest it please


---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5211/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6373/



---


[GitHub] carbondata issue #2383: [CARBONDATA-2615][32K] Support page size less than 3...

2018-06-19 Thread xuchuanyin
Github user xuchuanyin commented on the issue:

https://github.com/apache/carbondata/pull/2383
  
This PR depends on #2382


---